aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-08-20stats: send real last value if no new values comeOliver Smith5-1/+15
Background: * Individual values can be added to osmo_stat_item.values at any time. * Stats are reported at a fixed interval (see vty 'stats interval'), e.g. every 10 seconds. * In order to report a new stat value, we use the maximum of all osmo_stat_item.values added since the last report. * By default, we do not send new stat values if they did not change (see vty 'config-stats' -> 'flush-period' default of 0). Fix the following bug: * If 'flush-period' is 0, and no new osmo_stat_item.values are coming in, the last value that gets reported is not necessarily the last entry in osmo_stat_item.values. * For attached reporters (statsd), it could then be that the given stat stays at the wrong value for a long stretch of time (think of several hours/days/forever). Explanation of how the test shows that it is fixed: * stats get reported (value is irrelevant) * osmo_stat_item gets a new value: 20 * osmo_stat_item gets a new value: 10 * stats get reported (value: 20, the maximum of both new values) * osmo_stat_item gets no new values * stats get reported (value: 10, this is new because of the bug fix, the real last value in osmo_stat_item, different from the 20 sent earlier, without the fix it would not send anything here and the last sent value would be 20) * osmo_stat_item gets no new values * stats get reported (nothing gets sent, since the real last value was already sent and 'flush-period' is 0) Fixes: OS#5215 Change-Id: Ibeefd0e3d1dbe4be454ff05a21df4848b2abfabe
2021-08-20tests/stats: show how last item sent may be wrongOliver Smith2-0/+12
Extend the test to illustrate the bug described in the related issue, which will be fixed with the next patch. Related: OS#5215 Change-Id: I1d26867ac1b837bea6a9754a3203e53c147e7a5f
2021-08-19tests: add 'make update_exp' targetOliver Smith1-0/+179
Add convenience target to update the test output. Change-Id: I7247fffde82ab9195ae03b2ccb30d7aa47543113
2021-08-13gprs_ns2: add recursive anchor to protect against double freeAlexander Couzens2-5/+20
When free'ing a NSE/NSVC/BIND ensure there can't be a double free by using a free anchor in the struct. Recursive free's can happen when the NS user reacts on an event (e.g. GPRS_NS2_AFF_CAUSE_VC_FAILURE) and calls the free(). Or when the user free's a NSVC when the NSE uses SNS as configuration, the fsm tries to free it again. Change-Id: If9823aadaa936e136aa43e88cee925ddd5974841
2021-08-13gprs_ns2_sns: free the NSE if the SIZE PDU is not validAlexander Couzens1-0/+14
The SGSN fsm should be freed when becoming invalid instead of going into the unconfigured state. The unconfigured states should be only used when creating the NSE (on the SGSN side). Change-Id: Ife889091ecba4180a90743deb786767008fe863d
2021-08-13gprs_ns2_sns: refactor SNS failures into a functionAlexander Couzens1-10/+25
The SNS fsm is similar for BSS and SGSN. Terminate the SGSN failures by freeing the NSE. Change-Id: I1896f6c3ddb4f98ca261139c1cc77aa8f1558c6f
2021-08-13gprs_ns2_udp: don't start the NSVC fsm for SNSAlexander Couzens1-1/+3
The SNS code will always create NSVC on it's own. The only case when the SNS dialect allows dynamic NSE/NSVC is on the SGSN side when accepting dynamic NSE and receiving the first SNS SIZE. In this case the NSVC FSM must not be started yet. Prevents sending NS_ALIVE before the SNS configuration has been finished. Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
2021-08-06vty/ports: move pcap server/client portsOliver Smith1-2/+4
Resolve conflict with other Osmocom software by moving ports: osmo-pcap-client 4237 -> 4227 osmo-pcap-server 4238 -> 4228 Remove wrong previous comments that claimed 4240 and 4241 were used. Related: OS#5203 Related: osmo-pcap I3b18b1fbbca2799f868f28104e2f5d513f93d46c Change-Id: I098f211370bba61995ce424ab64029bdd4c49e2d
2021-08-06vty/ports: prepare formatting for a long defineOliver Smith1-22/+22
Add one more tab between the define and the port number, to prepare for longer defines in the next patch. Related: OS#5203 Change-Id: I46655e33651814f41a1fea93406a83334d2fc529
2021-07-28utils: Fix c++ warn in OSMO_STRBUF_APPENDPau Espin Pedrol1-1/+1
It's really a false positive since _sb_l is compared and granted to be psotivie by the time we compare, so we don't really care, but c++ is not happy about it. """ /osmocom/core/utils.h:227:40: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 227 | if (_sb_l < 0 || _sb_l > _sb_remain) \ | ~~~~~~^~~~~~~~~~~~ """ Change-Id: I90e7374aa959468670f1c0ea65a427398d423ddb
2021-07-27vty: clear screen with ^LOliver Smith1-0/+17
Use ANSI escape characters to clear the screen with ^L, like it works in typical Linux shells. I always found it slightly inconvenient that this didn't work in the VTY. Change-Id: Ie2356cd92f39b4dc28b5c20bbe4557fb0d972747
2021-07-27command: fix sourcecode formattingPhilipp Maier1-1/+1
Change-Id: Icc75c3b45821c24360e0fdb4a29077994e73ae05
2021-07-26gb/bssgp: Abort clearly if backward-compat API is used in wrong wayPau Espin Pedrol1-0/+1
Some tests under osmo-pcu (TbfTest) were caught accessning NULL pointer bssgp_nsi in bssgp_tx_llc_discarded triggered by timeout while stepping slowly with the debugger. It seems that test is not properly using neither the old nor the new API. Let's catch such cases easily. Change-Id: I3ea42755c4bfd29e4a01ad57f186f28d58ab466a
2021-07-26cosmetic: gb/gprs_ns.c: fix trailing whitespacePau Espin Pedrol1-2/+2
Change-Id: I842efdb93c9b480d5ab35c78b0bc60697262874a
2021-07-19vty: show uptime: use timespecsubOliver Smith1-5/+7
Related: OS#4609 Change-Id: If94795b3cd74040c49bdcbed8c410bf6e950afff
2021-07-16Make gcc 11.1.0 false positivies happyPau Espin Pedrol2-12/+11
After my system's gcc was upgraded, I get false positivies in a couple places. Let's initialize those to make gcc happy. """ /git/libosmocore/src/socket.c: In function ‘osmo_sock_init’: /git/libosmocore/src/socket.c:958:25: error: ‘sfd’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 958 | close(sfd); | ^~~~~~~~~~ /git/libosmocore/src/gsm/gsm48.c: In function ‘osmo_mobile_identity_decode’: /git/libosmocore/src/gsm/gsm48.c:690:20: error: ‘str_size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 690 | if (rc < 1 || rc >= str_size) { | ~~~~~~~^~~~~~~~~~~~~~~~~ /git/libosmocore/src/gsm/gsm48.c:679:22: error: ‘str’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 679 | rc = osmo_bcd2str(str, str_size, mi_data, 1, 1 + nibbles_len, allow_hex); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ """ Change-Id: I8aacfbc21e23f63a65e8baee3fd536a1fe1bdd8a
2021-07-15vty: add "shutdown"Oliver Smith1-0/+16
Kill programs with SIGTERM with the new vty command, as it would happen with "systemctl stop". I've considered running the select shutdown logic too in order to ensure that pending OSMO_FD_WRITE requests are serviced. But as noted in review, it's better to ensure that the regular SIGTERM code path works as expected and call that instead of introducing an alternative code path. Closes: OS#4609 Change-Id: I3596a35b0f4a24e49484ec3f24a98e4d4f583e1e
2021-07-15vty: add "show pid"Oliver Smith1-0/+8
Related: OS#4609 Change-Id: Ib636050afc1eed134f450f2f1cdd3b51153b0160
2021-07-15vty: add "show uptime"Oliver Smith1-0/+27
Related: OS#4609 Change-Id: Ic7d9d5d3c8a9abd06a7e626aed7679f68406040c
2021-07-13gprs_ns2: ensure the NSE becomes dead when FR link went downAlexander Couzens3-0/+61
The FR code is using force unconfigured to change the state of the NSVC when the FR link goes down. The force unconfigured state didn't notified the NSE when changing into this state. Related: SYS#5533 Change-Id: I4d7bbbbce26f7cde99eebe96995c50b1e812e5bd
2021-07-09Aggregate NSVC stats inside the NSEDaniel Willmann4-13/+45
Change-Id: Ifa3c85ec52bda14596e9d7a8705baa1fd4ee2010 Related: OS#4998
2021-07-09fix api doc of osmo_identifier_sanitize_buf()Neels Hofmeyr1-1/+1
The implementation cleary replaces sep_chars instead of keeping them. Adjust the doc to clarify that. It seems to me that the intention was to *allow* sep_chars instead of replacing them, especially when looking at sep_chars of osmo_separated_identifiers_valid(). But we're stuck with that now. Change-Id: Ia842a7eeb46b49ee364be55c1194e463ebcaf392
2021-07-07linuxlist: add macro to get last element of a listPhilipp Maier1-0/+6
It is not be obvious on the first look that ->prev actually points to the last element of a list, lets add a macro for that to make the API easier to use Change-Id: Icf455bf6ba9d60bd311af17c9e80febaa42cacc9 Related: SYS#4971
2021-07-06gprs_ns2_vty: dump_nsvc: change output depending on NSVCIAlexander Couzens2-18/+17
If the NSVCI is valid, there is no signalling or data weight defined (internally this is 1). For NSVC with NSVCI don't print the signalling or data weight. For NSVC without NSVCI, don't print NSVCI at all. Related: OS#5180 Change-Id: Iaadc806a9136436468e2b02eb0bc1f4570a10ecc
2021-07-06gprs_ns2: fix wrong format string in Tx Size loglineAlexander Couzens1-1/+1
Don't use %u for integer. Change-Id: I324836ec4943c97f0dbc16ade697c468eba02b35
2021-07-06gprs_ns2: use gprs_ns2_free_bind() to clean up a bindAlexander Couzens2-3/+7
gprs_ns2_free_bind() takes care of all required steps to clean up a bind. The driver->free_bind() operation only cleans up the driver internal state but not NSVCs and other generic things. Fixes a crash when free'ing a bind from the vty which has active NSVCs. Related: OS#5195 Change-Id: I0a2ad22905bcacb929b9b5f5b034af0da3081826
2021-07-02gprs_ns2: correct mtu value in the log lineAlexander Couzens1-2/+2
The log line should describe what's reported towards the NS user and not the NSE MTU itself Related: OS#5192 Change-Id: I3f5445a1ba8c89c4023ff48be15a80569a128528
2021-07-02gprs_ns2: fix check of MTU changes for frame relayAlexander Couzens1-3/+7
The frame relay needs 2 byte for data packets. Related: OS#5192 Change-Id: I02d4e81896a473aeb79ea2f2983e12324244048f
2021-07-02gprs_ns2: fix crash when changing the MTUAlexander Couzens2-3/+12
When the MTU changes for any fr device, all NSE will recalculate their MTU. If any NSE is alive, libosmocore will crash. Related: OS#5192 Change-Id: I31ba5cefea7bbb0b74060d6664b42c58815ee2a1
2021-06-30bts_feature: Introduce feature to confiure dyn ts as sdcch8Pau Espin Pedrol2-0/+3
This feature signals support to configure Osmocom Dynamic Timeslot type as SDCCH8, on top of historically supported TCH/H and TCH/F. The idea is that when unneeded, the TS is configured as PDCH, and as soon as there's need for an SDCCH and there's none available, the TS is dynamically reconfigured to SDCCH8. Once all logical channels in the dynamic TS are released and hence becomes free, the BSC will reconfigure it to PDCH. Related: SYS#5309 Change-Id: Ifc0ca8916bd3e93e5a60a7dd7391d2588fdb5532
2021-06-30Rename osmo dyn ts enumsPau Espin Pedrol3-3/+7
They will gain support to be activated as SDCCH/8 soon too. Since new name would start to be too large, use a more generic naming for it. Related: OS#5309 Change-Id: I56dcfe4d17899630b17f80145c3ced72f1e91e68
2021-06-29add fixme: enforce 8 byte length of KcNeels Hofmeyr1-0/+4
Change-Id: I57efb0a24cb71b365189eccb5088b130fad15093
2021-06-29ns2: Ignore NSVC with data_weight 0 for datadaniel/miscDaniel Willmann1-0/+2
Change-Id: If0c2bee285f85110771326e07b513fc3e3f9d3f0 Fixes: OS#5189
2021-06-28cosmetic: gsm_12_21.h: Fix trailing whitespacePau Espin Pedrol1-2/+2
Change-Id: Ifdcdcfe30c41da233899101e1057bfca7d645a66
2021-06-25bts_features: add feature for BCCH carrier power reduction modeVadim Yanitskiy2-0/+3
Change-Id: I69283b3f35988fc7a1a1dcf1a1ad3b67f08ec716 Related: SYS#4919
2021-06-25gsm0808: add Kc128 to Handover RequestNeels Hofmeyr2-1/+9
Change-Id: Ieb6e43eef9e57281d54d4b7c63664668df5aef3e
2021-06-25gprs_ns2_vc_fsm: reset the ALIVE response time when stopping testAlexander Couzens1-0/+1
Prevent showing a response time when the NSVC has failed. Related: OS#5089 Change-Id: I5435077d35ff1ae3d743ea1b1b8ace7f0fb913cf
2021-06-25gprs_ns2: fix missing notify towards the NSE when NSVC become blockedAlexander Couzens3-0/+73
The NSE wasn't notified when a NSVC went into the BLOCKED state from an UNBLOCKED state. Related: OS#5182 Change-Id: I09634e414e9bb966e6b5809b7de1b59fbabd413d
2021-06-25gprs_ns2: use llist_add_tail to keep orderAlexander Couzens3-10/+10
When configuring multiple NSE/BINDs the order of the configuration should be keeped. Related: OS#5181 Change-Id: Ibbc03f0780b49543b5bd97ee059f11cfd6c2a126
2021-06-21add Kc128 to gsm0808 Create Ciphering CommandNeels Hofmeyr5-10/+73
Prepare for A5/4 support in osmo-msc. Add new function gsm0808_create_cipher2() which takes a struct as argument instead of individual fields. This is akin to e.g. gsm0808_create_handover_request() below in the file, and allows backwards compatibly extending the argument list without needing a new function signature every time. Add struct gsm0808_cipher_mode_command, as argument list for gsm0808_create_cipher2(), with kc128 included. Encode the Kc128 IE in gsm0808_create_cipher2(). Implement gsm0808_create_cipher() by calling gsm0808_create_cipher2(). Change-Id: Ib3906085e0c6e5a496a9f755f0f786238a86ca34
2021-06-18vty: make function cmd_range_match() publicPhilipp Maier2-4/+6
Certain control interface commands also may require to verfy a range in their verify function. cmd_range_match() from the VTY does exactly that and the range can be specified as string, the same way as we would specify it in the VTY. Change-Id: I53fc207677f52b1dc748b01d58424839cdba807c related: SYS#5369
2021-06-18osmo_select_shutdown_request(): allow finishing pending writes on SIGTERMNeels Hofmeyr2-1/+72
Allow telling osmo_select_main* to only service pending writes (shutdown mode). Introduce API fuctions to indicate a shutdown request, and find out whether shutdown is complete. Some osmo programs have a curious sleep of few seconds upon receiving SIGTERM. The idea presumably was to finish off pending writes before halting the program. But a sleep() on program exit is annoying, especially when there usually are no pending writes, and when osmo-bsc is launched numerous times for tests. Change-Id: Ib94d4316924103459577087c2214188679db2227
2021-06-16stats_vty: Improve generation of osmo countersDaniel Willmann1-11/+10
Use section for all counter headings, the idea is that the generated doc is included below a chapter describing the implemented counters which can optionally describe individual items. If not osmo_counters are present simply omit the whole section to tidy up the manual. Those are deprecated anyway and not used in the osmo-* projects that I checked. Change-Id: I126b39cb9458e0f62efa338967e07151a0eece0f Related: SYS#5005, OS#4523
2021-06-16control_cmd: fix typoPhilipp Maier1-1/+1
Change-Id: I9deaee42aeb0ab0549cc7c4f180ad9c216b9df39
2021-06-15ctrl: Support recovering from short writePau Espin Pedrol1-1/+7
osmo_wqueue has support for it, so simply handle it correctly in the callback (updating buffer and returning -EAGAIN). Related: OS#5169 Change-Id: I6cbc7ec6ae6832e61cddf4402332ba09b142a7d4
2021-06-15ctrl: Pre-calculate required size before allocating msgbPau Espin Pedrol2-62/+34
This commit fixes crash when response is more than ~4096 chars. Furthermore, we now allocate only the required memory, not 4096 for all messages, which usually don't require it. Test needs to be adapted since it assumed there was more available space at the end of the msgb. Related: OS#5169 Change-Id: I0b8f370f7b08736207f9efed13a0663b5e482824
2021-06-13gprs_ns2_sns: bss: set gss->familyAlexander Couzens1-0/+1
gss->family (and gss->ip) was never set. So IPv6 should have never worked. Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote") Related: OS#5036 Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
2021-06-13gprs_ns2_sns: replace ns2_sns_type with address familyAlexander Couzens1-28/+24
Reduces the code as the conversion between address family (bind) and ns2_sns_type is not needed anymore. Related: OS#5036 Change-Id: I1bcdd43af34c926d4b88491d00669422c299bef7
2021-06-13gprs_ns2_sns: refactor nss_weight_sum_data -> ip46_weight_sum_dataAlexander Couzens1-7/+7
Allow to use ip46_weight_sum_data for local endpoints as well. Related: OS#5036 Change-Id: I75d88f3da89ad13e34a3fd5ae72bd967d81f4abc
2021-06-13gprs_ns2_sns: refactor ip4_weight_sum/ip6_weight_sumAlexander Couzens1-16/+14
Use the new introduced struct ns2_sns_elems instead of the elems seperate. Related: OS#5036 Change-Id: I0956ab6085554210569188f52cae121e32fca19b
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-20 23:56:23 +0000