aboutsummaryrefslogtreecommitdiffstats
path: root/src/xua_asp_fsm.c
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2019-10-22 20:24:14 +0200
committerlaforge <laforge@osmocom.org>2019-11-05 20:50:26 +0000
commitebd2fc60461763e756e5a6c3176a33f3fa005282 (patch)
treee92825f86065ed3f06024456e34624e2eb97600a /src/xua_asp_fsm.c
parent907121b85d50283a7e08eede27fd5d7bb112b89b (diff)
M3UA: Reject ASP activation + RKM registration for incompatible traffic-mode
If the AS is e.g. configured as broadcast, then individual ASPs cannot be activated in loadshare or override. Everyone must agree. Change-Id: Ic73410fbc88d50710202453f759fa132ce14db4c
Diffstat (limited to 'src/xua_asp_fsm.c')
-rw-r--r--src/xua_asp_fsm.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 5814532..16c06d6 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -483,10 +483,7 @@ static void xua_asp_fsm_inactive(struct osmo_fsm_inst *fi, uint32_t event, void
LOGPAS(as, DLSS7, LOGL_INFO,
"ASPAC: Traffic mode set dynamically by peer to %s\n",
osmo_ss7_as_traffic_mode_name(as->cfg.mode));
- } else if (as->cfg.mode != tmode) {
- /*FIXME: ^ properly check if tmode is
- compatible with already set
- as->cfg.mode */
+ } else if (!osmo_ss7_as_tmode_compatible_xua(as, traf_mode)) {
peer_send_error(fi, M3UA_ERR_UNSUPP_TRAF_MOD_TYP);
return;
}