aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bt-utp.c
AgeCommit message (Collapse)AuthorFilesLines
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-16/+6
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-17Remove all preferences related to enabling/disabling heuristic dissectors.Michael Mann1-8/+3
The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-12Add "user presentable" and "unique string ids" to heuristic table entries.Michael Mann1-1/+1
This allows better presentation of heuristic dissectors to the end user. Change-Id: I2ff3985ab914e83c2989880cc0c7b9904045b3f6 Reviewed-on: https://code.wireshark.org/review/9602 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-22Remove more tvb_lengthEvan Huus1-2/+2
Change-Id: I940704e927001b2a051a59fd0738e7a02328472b Reviewed-on: https://code.wireshark.org/review/9031 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-2/+2
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-14Fix warningsJakub Zawadzki1-2/+3
svn path=/trunk/; revision=54089
2013-02-20Fix Coverity CID 751720: Logically dead code.Chris Maynard1-18/+17
In fixing this bug, also fix another: Be sure to use tvb_length() and not tvb_reported_length() in get_utp_version(), since this is essentially where the heuristics are being applied to decide whether to accept the packet or not. svn path=/trunk/; revision=47761
2013-02-04Fix Coverity CID 746734: Dead default in switch. (No need to backport)Chris Maynard1-20/+6
svn path=/trunk/; revision=47461
2012-12-16Strengthen BT-uTP heuristic dissector and add a preference to enable it ↵Pascal Quantin1-11/+34
(disabled by default) svn path=/trunk/; revision=46551
2012-12-04Fix [-Wshadow] warning.Bill Meier1-7/+7
svn path=/trunk/; revision=46379
2012-12-04From Patrik Lundquist Updated V1 header description to reflect corrected ↵Anders Broman1-64/+72
specification (BEP 0029). Removed if(tree) in dissect. New style dissector, right? Added heuristics for V0 header. Removed length checking in heuristics since uTP packets can have any lenght, even odd ones, and they do. Fixed Extensions looping over whole packets and added a Data field for the trailing payload. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8048 svn path=/trunk/; revision=46373
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-02-05From Xiao Xiangquan:Anders Broman1-37/+33
bt-dht and bt-utp should also be common dissectors while not only heuristic ones. So we can use them with "Decode As..." command. Applying the missing part as this seems to be an owerlapping patch. svn path=/trunk/; revision=40868
2011-11-15Remove unneeded #includeBill Meier1-2/+2
svn path=/trunk/; revision=39869
2011-11-01Remove comma at the end of several enumerator lists.Jeff Morriss1-2/+2
svn path=/trunk/; revision=39700
2011-10-28From Xiao Xiangquan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5767Alexis La Goutte1-32/+21
Make bt-utp as heuristic dissectors svn path=/trunk/; revision=39652
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-24/+24
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-6/+6
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-21Fix ex "modeline" so it works;Bill Meier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39081
2011-05-20Add to comment about using a heuristic; Fix a typo.Bill Meier1-1/+3
svn path=/trunk/; revision=37330
2011-04-22Enhance BT-UTP dissector:Alexis La Goutte1-59/+76
* Add type (syn, data, reset...) in column info * Split dissect_utp_header(...) function to * dissect_utp_header_v0(...) * dissect_utp_header_v1(...) * dissect_utp_extensions(...) svn path=/trunk/; revision=36803
2011-04-20Add code to dissect "original uTP header format"Bill Meier1-45/+188
as described in the LibuTP utp.cpp source code; Add a kludgy heuristic to differentiate between original and "V1" header formats. TBD: validity of the heuristic; is there a better way ? svn path=/trunk/; revision=36742
2011-04-20- New-style dissectors need to always return "bytes dissected" (not just ↵Bill Meier1-13/+14
when tree != NULL); - The dissector probably shouldn't return a value for "bytes dissected" which is larger than the tvb length (altho there's actually no harm given the current implementation). - Don't try to do an 'add_item' with an offset past the end of the tvb (altho again there's no actual harm in this case). ToDo: Handle "original format" uTP headers. svn path=/trunk/; revision=36737
2011-04-19Whitespace cleanup; Remove an uneeded col_clear().Bill Meier1-25/+23
svn path=/trunk/; revision=36720
2011-04-19This file had an identical copy appended to the end of it. RemoveStephen Fisher1-355/+1
duplicate. svn path=/trunk/; revision=36719
2011-04-19From Xiao Xiangquan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5846Alexis La Goutte1-0/+710
A new dissector for uTorrent Transport Protocol From me : * Add link to spec BEP-0029 * Add note about type/version * Rework extensions loop * Use 2-space indenting svn path=/trunk/; revision=36716