aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bt-utp.c
diff options
context:
space:
mode:
authorChris Maynard <Christopher.Maynard@GTECH.COM>2013-02-04 02:44:04 +0000
committerChris Maynard <Christopher.Maynard@GTECH.COM>2013-02-04 02:44:04 +0000
commit97af00269332214ad4f3f1e7979db05eabab013d (patch)
treeabcc5fe5dbb26c91f6bcc871acb81986fd3946d8 /epan/dissectors/packet-bt-utp.c
parentf2beeac1d09b518944ace06c3cd909cee4bb9f91 (diff)
Fix Coverity CID 746734: Dead default in switch. (No need to backport)
svn path=/trunk/; revision=47461
Diffstat (limited to 'epan/dissectors/packet-bt-utp.c')
-rw-r--r--epan/dissectors/packet-bt-utp.c26
1 files changed, 6 insertions, 20 deletions
diff --git a/epan/dissectors/packet-bt-utp.c b/epan/dissectors/packet-bt-utp.c
index 4a424f49f6..0053d1f44b 100644
--- a/epan/dissectors/packet-bt-utp.c
+++ b/epan/dissectors/packet-bt-utp.c
@@ -158,7 +158,6 @@ static gint
get_utp_version(tvbuff_t *tvb) {
guint8 v0_flags, v0_ext;
guint8 v1_ver_type, v1_ext;
- gint version;
guint len;
/* Simple heuristics inspired by code from utp.cpp */
@@ -178,31 +177,18 @@ get_utp_version(tvbuff_t *tvb) {
if (((v1_ver_type & 0x0f) == 1) &&
((v1_ver_type>>4) < ST_NUM_STATES) &&
(v1_ext < EXT_NUM_EXT)) {
- version = 1; /* V1 */
+ if (len < V1_FIXED_HDR_SIZE)
+ return -1;
+ return 1;
}
else if ((v0_flags < ST_NUM_STATES) ||
(v0_ext < EXT_NUM_EXT)) {
- version = 0; /* V0 */
- }
- else
- return -1;
-
- switch(version) {
- case 0:
if (len < V0_FIXED_HDR_SIZE)
return -1;
- break;
-
- case 1:
- if (len < V1_FIXED_HDR_SIZE)
- return -1;
- break;
-
- default:
- return -1;
+ return 0;
}
-
- return version;
+ else
+ return -1;
}
static int