Age | Commit message (Collapse) | Author | Files | Lines |
|
For long options, without corresponding short options, to be processed
they need to be assigned a value, preferably outside of the range of
all possible short options. The code in various places tries to stay
clear of these low values, but further coordination is missing, easily
leading to issues when option processing code gets extended and/or
reorganized.
This change introduces a single location from where each catagory of
command line long option can derive a base value, which should minimize
potential option value collisions.
Change-Id: Ic8861a347d0050f74002de3aa1fcfb01202866e5
Reviewed-on: https://code.wireshark.org/review/35459
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Found by clang.
Change-Id: I84359a2f7985bca8b0089200b3c37d04e06effe2
Reviewed-on: https://code.wireshark.org/review/35354
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Tomasz Moń <desowin@gmail.com>
|
|
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Id1d9cd2c1f311247df53f41397169ce0490bf7a7
Reviewed-on: https://code.wireshark.org/review/35443
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
The label stack is its own TLV, which adheres to the same format as
others, with a tag and length (obviously). The length to be used for
this TLV is not the remaining length of this packet, but its own length.
Bug: 16273
Change-Id: I469b55c5d78d1899d87030f3c0a15fd1afdf3f85
Reviewed-on: https://code.wireshark.org/review/35436
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Compressed block acks, in the form of 256 bit bitmaps, are parsed
per 64 bit section. Scanning along a section needs to be done by
indexing this section, not the full 256 bits of the complete bitmap.
Change-Id: Id0e6a7299e14be1ad68dd1cf6d736123008854ac
Reviewed-on: https://code.wireshark.org/review/35440
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
In the expression it seems to simply have been missed this is a 2D array.
Adding the 2nd index, as elsewhere in this function.
Change-Id: I21ce5a6fa70408f84cb61bbd09e7d3aeff9c1d85
Reviewed-on: https://code.wireshark.org/review/35441
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
When listing the SSRCs actually count down the number of SSRCs
when adding tree items.
Change-Id: Iad81dfc2dfd8d611b20d8ad564d8dbacb4a9980f
Reviewed-on: https://code.wireshark.org/review/35438
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Remove the last of our description list term formatting. This is better
handled using CSS. Update the filter expression dialog DL text.
Change-Id: Ib21e2ee5265c9b476d960e7d73ac99b25b646141
Reviewed-on: https://code.wireshark.org/review/35437
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
Remove some formatting and link to the list archives.
Change-Id: I45c5a24b4a6d01234aafab71dc080cf98f4e22cf
Reviewed-on: https://code.wireshark.org/review/35435
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
Change-Id: I71a28535f2c9081e965004f02ec85ff500f9278b
Reviewed-on: https://code.wireshark.org/review/35428
Reviewed-by: Dario Lombardo <lomato@gmail.com>
|
|
Option string composition has grown organically over time and is
depending on compilation options also. This results in somewhat complex
macro definitions and the use of the string concatenation feature of the
C compiler. This change tries to clean up some of this magic by removing
definitions of empty strings and merging of adjacent strings.
Change-Id: I968449ea9b564915bee468a0cac0e114983ceebe
Reviewed-on: https://code.wireshark.org/review/35429
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
Remove if (tree)
Change-Id: I1bb38fd8cdea85e026837ea1dc9bcd72b7432f1e
Reviewed-on: https://code.wireshark.org/review/35430
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Guenther
Change-Id: I62bac46ac43189f7ea07aacf19147d85f6649a5d
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: https://code.wireshark.org/review/35423
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
H.264: fix dissection of se(v).
Change-Id: I38ad153a3f8860726ea3f430433f5202f534a5fa
Reviewed-on: https://code.wireshark.org/review/35419
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Fixes the issue described at
https://www.wireshark.org/lists/wireshark-users/201912/msg00003.html
Change-Id: Ie3fd338ab1c6b216b05eeca002545868d3474bbb
Reviewed-on: https://code.wireshark.org/review/35426
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Ib89a159bbc7125b3afcfd72d1a218cb6d7c4af39
Reviewed-on: https://code.wireshark.org/review/35421
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Ida8f8638ee226b99804293158e57f4be7a045be8
Reviewed-on: https://code.wireshark.org/review/35420
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Check for NULLs in a couple of places found by scan-build. Fix a typo.
Change-Id: Idde75db6031fa9f2ffa36b7fa10b37bf676e0904
Reviewed-on: https://code.wireshark.org/review/35427
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Oct7, Bit 2: TEBUR
Change-Id: If3668ba53b163c692fe81163c5e895fcd38b9539
Reviewed-on: https://code.wireshark.org/review/35422
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Icd18de17e7564b946ea177df252dffd2370ff1a0
Reviewed-on: https://code.wireshark.org/review/35408
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Change-Id: I46df64d47144eb943e8feee192d9bacb137b22c5
Reviewed-on: https://code.wireshark.org/review/35410
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
|
|
Add some null checks identified by scan-build. Switch some dynamic_casts
to qobject_casts.
Change-Id: I2b97ee8cb71db4fc883b4081568f9a5db8af85b3
Reviewed-on: https://code.wireshark.org/review/35403
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Set "LZ4_PDB" instead of "LZ4_pdb" in FindLZ4.cmake so that CMake 3.16
will convert "${LZ4_DLL_DIR}/${LZ4_PDB}" to the full path to the LZ4
.pdb instead of its parent directory.
This in turn ensures that we don't pass a directory as a source argument
to `cmake -E copy_if_different`, which causes it to crash.
Bug: 16271
Change-Id: Id6f37584379bd07bc929bc5cb5e80cbe60a3c77e
Reviewed-on: https://code.wireshark.org/review/35400
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
This works around the lack of a defined radiotap field for 11ad.
Bug: 16272
Change-Id: Ia851c644aee52ff9a138a36b16015d4112b5bf92
Reviewed-on: https://code.wireshark.org/review/35401
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Library was regenerated using g000e963fff596d817d03f366cd49b1fd2d6ec961
to have the proper version info.
Change-Id: I33f26d70ba1ea244aa467e5121b6fb586d8ebd8a
Reviewed-on: https://code.wireshark.org/review/35398
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
|
|
Check the number of remaining bytes before comparing the
next four bytes to the LNet magic number to find out
whether or not this is an LNet layer.
In the case for an RDMA Read Request which does not have
any payload data, the LNet dissector now gracefully will
not process this packet as an LNet layer instead of
labeling it as a malformed packet.
Bug: 16269
Change-Id: I5d6abea8b79619849e8fbc1bc6b585995736b56e
Reviewed-on: https://code.wireshark.org/review/35392
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
|
|
This reverts commit 9910d8c913d2a1874c7f98ef3bf3ad2921dd67e4.
Reasons for revert:
- We need to improve the reliability of extcap-version=x.y detection.
- WSDG_chapter_capture.adoc needs to be more clear about extcap-version=x.y support.
- Our extcap utilities need to be updated.
Change-Id: Ic8dd2018489f5ec03c35b18e6b09faf69defd59b
Reviewed-on: https://code.wireshark.org/review/35393
Reviewed-by: Rafał Kuźnia <rafal.kuznia@protonmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
|
|
Update the minimum version in various documents. Remove some
no-longer-needed code from scripts that call windeployqt.
Change-Id: I16da4bced9780c9f1b1969aae7c52e2fce1968aa
Reviewed-on: https://code.wireshark.org/review/35391
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Remove a comment that's no longer relevant as of g14e4759b56.
Change-Id: I919631810c37e34ebc0cf5b78ab4dfbee5f5c687
Reviewed-on: https://code.wireshark.org/review/35390
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
|
|
Each node maintains one APS counter and not one per conversation.
Therefore, remove the conversation handling and maintain the
counter for each node instead.
Bug: 15021
Change-Id: I3a225db008f5dd716246674aafb9d3d04c7d402f
Reviewed-on: https://code.wireshark.org/review/35371
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
While here:
- some indentation fixes
- add defines for missing ATT_OPCODEs
Bug: 16258
Change-Id: I2cd8172bcff9c209bbddc4729573c008a8e81fec
Reviewed-on: https://code.wireshark.org/review/35339
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
This change makes the --extcap-version argument to be passed to the extcap
script, if it is supported. If the extcap fails with --extcap-version argument,
it is treated as legacy and will not receive the additional argument in all
subsequent runs.
Change-Id: I279aa38d9f39ed85ccb84ba2c09dd93a0492ca51
Reviewed-on: https://code.wireshark.org/review/34914
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Id6b39125a56b95b94d6a0bb6436bf7b2d131f924
Reviewed-on: https://code.wireshark.org/review/35385
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
win32_save_as_statstree was GTK+-only.
Change-Id: Ief029cd1a702b0c17d9602bee8a2d75ee4c3c393
Reviewed-on: https://code.wireshark.org/review/35384
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Add a "title" argument to each of the Win32 file dialog routines, and
pass in one constructed using wsApp->windowTitleString.
Change-Id: I5ff862bd28cd16093d99ae1559ecbaca907350da
Reviewed-on: https://code.wireshark.org/review/35383
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
If actions_ is NULL, it will be dereferenced in the next check.
Found by clang.
Change-Id: I11f1620fae0e330dbbb7e0cc57b398f473261899
Reviewed-on: https://code.wireshark.org/review/35373
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Remove some code that's been #if 0'ed out since 2006 and 2012. Include
file.h instead of globals.h.
Change-Id: Ib4a84c03e112d732b25df4b7b26b54e029f717a4
Reviewed-on: https://code.wireshark.org/review/35378
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Stop using win32_check_save_as_with_comments and just use the
Qt equivalent on Windows. It started out as a static funtion in
file_dlg_win32.c and using the native Windows event loop may have been
required for GTK+, but neither of those apply now.
Change-Id: I66d7f1c6346df65b0fadb3aa9cba823c0e457703
Reviewed-on: https://code.wireshark.org/review/35382
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
This is useful when the NAS 5GS heuristic to decode 5G-EEA0 packets does
a false detection, so as to dissect the rest of the NGAP PDU.
Change-Id: I4eaa3caf06e0ed8923795470a2def7a73438110e
Reviewed-on: https://code.wireshark.org/review/35380
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
|
|
Change-Id: I4d74b7d45058b620e653a22fc4b0c7501ba425dd
Reviewed-on: https://code.wireshark.org/review/35377
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
* add warning of faulty FO flag
* corrected offset of length extraction
Change-Id: Ia5fcec64f5269a48f04999febdcee6076f50313d
Reviewed-on: https://code.wireshark.org/review/35372
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Linux uses SEND first, middle and last for small NFS reads
instead of using the write chunk list. Reassembly is done
using the PSN (packet sequence number) to order the segments
in case one or more segments are sent out of order.
Reassembly uses a single message id per each direction of a
given conversation so it is tied to the destination queue
pair. Also, the PSN given in the SEND First packet is used
as a base so fragment numbers are relative and start at zero.
Furthermore, a previous incomplete reassembly is thrown away
in the SEND First packet so any fragments previously added
to the reassembly table are not included in the current
reassembled message.
Bug: 16225
Change-Id: I8de6a3123676e348d8e893f0f67d4b3ba38db27f
Reviewed-on: https://code.wireshark.org/review/35224
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Add an "Export Specified Packets" section. Update the "Export Packet
Dissections," "Packet Range," and "Packet Format" sections. Update some
markup and text throughout the chapter.
Change-Id: I7b7c6fcc41c4fdc684c86a34364ed9baa5123d15
Reviewed-on: https://code.wireshark.org/review/35359
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Iccc98a8f33d6de0ec466404a4f728442c8a58ea0
Reviewed-on: https://code.wireshark.org/review/35340
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: I489c981e02b2ed0331981003777a5de54ba8221f
Reviewed-on: https://code.wireshark.org/review/35367
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Use same format for "Time to live" as for other ttl values by
appending the time_secs_to_str() output to the number of seconds.
Ping-Bug: 16263
Change-Id: Ie55bbf27bf9c44554d391b395d23c478ad401d98
Reviewed-on: https://code.wireshark.org/review/35358
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
|
|
Fixed names of few reserved fields according to MS spec
See [MS-SMB2] 2.2.32 SMB2 IOCTL Response
Change-Id: I92926b93dd5086559b124497136e0c5979ab37aa
Reviewed-on: https://code.wireshark.org/review/35342
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Display time to live as formatted by unsigned_time_secs_to_str().
This was removed in g42c52d8612 but the commit message for that change
was "Add more filterable fields around EDNS(0)", with no indication
of this change.
Bug: 16263
Change-Id: Ic21f4a4b18d15efbd770c708e37d6e0c15eee6ce
Reviewed-on: https://code.wireshark.org/review/35355
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
In case if SMB IOCTL response packet (seen to happen for FSCTL_PIPE_TRANSCEIVE but applicable for others)
has STATUS_BUFFER_OVERFLOW status code, dissection is done improperly
(wrong offset to IOCTL response body is calculated so content is corrupted).
Packet body with STATUS_BUFFER_OVERFLOW status should be handled in the same way as STATUS_SUCCESS packet.
Bug: 16261
Change-Id: I05d05ed9fa16f8b128590cd505fe9b0270dd74ab
Reviewed-on: https://code.wireshark.org/review/35341
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Add the decoding of some more SZL indices, so that all of the most common
used SZL indices which occur in normal use are decoded. Also some fixes
and extensiond of existing SZL indices. General code style cleanup, where
unneccessary comments, blank lines and commas are removed.
Change-Id: Ic7abfbe1cf3b9aa31380433d3286d111340a3893
Reviewed-on: https://code.wireshark.org/review/35335
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|