aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2015-10-01CMake: OS X packaging updates.Gerald Combs2-8/+7
Add a dmg_package_prep target as an alias to app_bundle. Rename the osx-dmg target to dmg_package. This matches the Windows packaging target names. In osx-app.sh, make sure we rpathify the bundle plugin directory. Change-Id: If41195c9d405ad6bff865625500a8227b77e8092 Reviewed-on: https://code.wireshark.org/review/10734 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-01Treat IPv4 subnet masks as distinct from addressesJeffrey Smith21-29/+63
While IPv4 subnet masks are obviously related and similar to IPv4 addresses, they are distinct enough that they need to be treated seperately in some aspects. For instance, there is no value in attempting to resolve a subnet mask. This change creates a new display type: BASE_NETMASK, which allows distinction from FT_IPv4 (and possible name resolution) where appropriate. Change-Id: I99e19c9a58eb613f8e58d481af84c30e2e5e14d7 Reviewed-on: https://code.wireshark.org/review/10438 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-01Fix crashes related to RTP Streams analysisPeter Wu6-4/+32
The data that describes RTP streams become invalid when packets are re-dissected. This results in a crash in GTK when the "RTP Analyse" option is used and and a crash in Qt when the display filter is changed while the RTP Streams dialog is open. Fix this by adding a tap_reset callback (modelled after mcaststream) to the RTP tap listener that allows the GTK+ and Qt dialogs to clear the displayed list of RTP streams. Bug: 10016 Change-Id: I7478678db63d7ac8110c44c163844e9f66fad9e9 Reviewed-on: https://code.wireshark.org/review/10728 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-01Revert "gtk: Fix crash on Analyze RTP stream"Peter Wu1-6/+0
Qt is affected by a similar issue, a different approach is needed. This reverts commit 01bd832b9df9570ddfd81ab4985f71ff6abd9b12. Change-Id: Ic03807e8d00a3114bac1507762df05870b0346d9 Reviewed-on: https://code.wireshark.org/review/10727 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-01IPv6: Remove two offsetof()sJoão Valverde1-2/+2
Change-Id: I41c93927595be523528d44c263b7028f40e524e2 Reviewed-on: https://code.wireshark.org/review/10706 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-01Add the conversation hash tables internals dialog.Gerald Combs10-0/+255
The GTK+ version dumps "new" and "old" hash values. It looks like neither are valid since the code in conversation.c and conversation_hashtables_dlg.c have diverged. For now just dump the addresses and ports for each hash table in the Qt UI. Change-Id: I832522dff06da769bd4ad3ead3d541206f283a90 Reviewed-on: https://code.wireshark.org/review/10713 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-01Add dissection of 3GPP AVP 655 refactor to use ↵AndersBroman1-139/+176
proto_tree_add_bitmask_with_flags() in some cases. Part 2 Change-Id: I18a17202f1c547b2257549ea0245350227edafa0 Reviewed-on: https://code.wireshark.org/review/10730 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-01OS X: Integrate CMake and osx-dmg.shGerald Combs3-8/+72
Change-Id: Ide608f5e73ecd40c67a6b1c0e16f11233cd49c9d Reviewed-on: https://code.wireshark.org/review/10694 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-01[Diameter] Add dissection of 3GPP AVP 655 refactor to useAndersBroman1-0/+25
proto_tree_add_bitmask_with_flags() in some cases. Change-Id: I280c8f33aeacb84561243b38497276099621bfe9 Reviewed-on: https://code.wireshark.org/review/10729 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-01Revert "SCTP: Add I_DATA support"Michael Tüxen8-228/+79
This reverts commit 4e9361dc88eefef27d031e29e2f8ca9891cc03eb. Change-Id: Ia7aee9ffbe5bc5d3ae88e957c234cbee7b65f457 Reviewed-on: https://code.wireshark.org/review/10723 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2015-10-01Revert "Fix typos."Michael Tüxen2-3/+3
This reverts commit e47ea6d7493c60e1761da4f5fbb6bee68fdb5847. Change-Id: Ia5b7f5cdb1f17705010ac60bd2105156014f6d00 Reviewed-on: https://code.wireshark.org/review/10721 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2015-10-01ZigBee: fix dissection of Link Status Address fieldPascal Quantin1-1/+1
Bug: 11564 Change-Id: I4320c794a0b6ba1693e2729eea424a0a43cf54d8 Reviewed-on: https://code.wireshark.org/review/10715 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-10-01Fix typos.Michael Tüxen2-3/+3
Change-Id: I3c03cbb064d1d7ffd579982b2e670b84b1768db2 Reviewed-on: https://code.wireshark.org/review/10717 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
2015-10-01SCTP: Add I_DATA supportruengeler8-79/+228
Change-Id: Ib8566b7d94fdafdb9735b356d129f378c94af3cf Reviewed-on: https://code.wireshark.org/review/10716 Reviewed-by: Michael Tüxen <tuexen@wireshark.org> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2015-10-01[Diameter] Add 3GPP AVP 652-655AndersBroman1-4/+14
Change-Id: I4db21e3e095f7cb466759a96706ec17c8429386e Reviewed-on: https://code.wireshark.org/review/10714 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-30It's "-Wno-XXX", not "-WnoXXX".Guy Harris1-1/+1
Change-Id: I90ac4872e2a792dac07a6c12c8f059795f7f6bc3 Reviewed-on: https://code.wireshark.org/review/10712 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-09-30Another big hammer to shut Apple's deprecation squealing up.Guy Harris1-1/+4
Change-Id: Ifeb37566468fca0afceab1d74baa23fd05a46057 Reviewed-on: https://code.wireshark.org/review/10711 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-09-30Add more CORBA dissectors back to the dirty list.Gerald Combs2-7/+7
Change-Id: Ic55a2d444b924a6b13bdfd479a38d90589be8a1f Reviewed-on: https://code.wireshark.org/review/10709 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-30[isns] refactor the attribute parsing codeMartin Kaiser1-341/+132
* go through the data only once, increment offset along the way * remove tag, length dissection from the payload functions * handle all undecoded elements in the default case * don't bring up an exception for an invalid ip address length, proto_tree_add_item() already does this for us * replace the payload functions for string, integer, ip address with proto_tree_add_item() Change-Id: I2a96cb0b22961f63256d7bf0dfe138c6d8100fde Reviewed-on: https://code.wireshark.org/review/10682 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2015-09-30DNS: Replace cinfo by pinfo->cinfo (no longer need to check if cinfo is not ↵Alexis La Goutte1-149/+63
NULL) Change-Id: Ib7cebd588924270b2003fad575f4cd0c3ec2678e Reviewed-on: https://code.wireshark.org/review/10698 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-30DNS: Fix Col Info display (Missing space between rcodes)Alexis La Goutte1-4/+4
Change-Id: I79ecb77ac5ab7e18f9986f2987fafeab8a117644 Reviewed-on: https://code.wireshark.org/review/10697 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-30Use a 'recent' setting to persist the checkbox controlling the source of ↵Martin Mathieson3-3/+21
PDUs to use in LTE RLC statistics Change-Id: I20234c3a3bf7761f70b0db5a6acbbf54ffbfcef5 Reviewed-on: https://code.wireshark.org/review/10699 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-30qt: warn when jumping to an invalid packet numberPeter Wu1-0/+1
I was confused when double-clicking a packet number did not work. It turns out that the display filter was hiding the destination. Check the packet number for sanity, just like GTK+ does. Change-Id: If50b2a3091a468f880b42fd2385f1b74c30d2f2b Reviewed-on: https://code.wireshark.org/review/10700 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-09-30wslua: do not pop from empty stack on newer LUA versionsPeter Wu1-2/+0
Fixes this failure: tshark: lapi.c:175: lua_settop: Assertion `(-(idx+1) <= (L->top - (func + 1))) && "invalid new top"' failed. Found using LUA 5.2 compiled with -DLUA_USE_APICHECK. Note that the value returned by luaopen_bit does not affect the size of the stack after using lua_call; if there are excess return values, then these will be dropped after calling lua_call. See http://www.lua.org/pil/26.2.html I also verified that the stack is still empty after calling all wslua_reg_module functions. Change-Id: Ia72635277ca4d8077e47a5c472391a78fe6d311e Reviewed-on: https://code.wireshark.org/review/10664 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-09-30gtk: Fix crash on Analyze RTP streamPeter Wu1-0/+6
When updating the RTP streams list, the data associated with the current selection becomes invalid when the old list is cleared. gtk_list_store_clear somehow triggers the selection callback which attempts to access the invalid memory. Avoid this by disabling selectability while clearing the list. Bug: 10016 Change-Id: Id5126ec5ffa41fa6a65339f4453546223124ed67 Reviewed-on: https://code.wireshark.org/review/10690 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-09-30nwp: add support for NWP packetsCody Doucette6-0/+383
Neighborhood Watch Protocol (NWP) is an XIA protocol for resolving network addresses to link-layer addresses. Hosts on a LAN send NWP Announcement packets with their host identifiers (HIDs), and neighbors in the LAN respond with NWP Neighbor List packets containing their HIDs and associated link-layer addresses. Bug: 11492 Change-Id: Ib1e801474b1aa72f5dd3d8303eeec36b96ee0a99 Reviewed-on: https://code.wireshark.org/review/10316 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-30automake: get docbook builds working for out of (source) tree builds.Jeff Morriss1-8/+12
Change-Id: I483596d21f072b97ae87d5032bd450adcafcf243 Reviewed-on: https://code.wireshark.org/review/10678 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-30IPv6: Remove extra spacing from info arrays.João Valverde1-619/+822
Internal formatting: remove extra spacing from 'hf_register_info' array (as suggested during review), plus indentation changes. Do the same for expert info array. External formatting: Minor cleanups. Change-Id: I4d8db4891824e75d413b0eb53ebcc2e7b128c0bb Reviewed-on: https://code.wireshark.org/review/10683 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-30[ieee80211] Fix: "DSCP Range description user priority" off by 1Bill Meier1-2/+2
Bug: 11555 Change-Id: Ic12c7882dbe4f6eca72f7eed3ee8d0e5618afdd8 Reviewed-on: https://code.wireshark.org/review/10695 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-09-29file.c: do not rescan packets is no capture file is openedPascal Quantin1-4/+6
Otherwise we will end up calling cf_cb_file_rescan_started and cf_cb_file_rescan_finished callbacks while no capture file is available Bug: 11552 Change-Id: Ib6fd7b13ce1b083d5f5b4e05d80152112c1451f6 Reviewed-on: https://code.wireshark.org/review/10692 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-29Add back DIRTY_CORBA_IDL_DISSECTOR_SRC.Gerald Combs3-4/+15
Add DIRTY_CORBA_IDL_DISSECTOR_SRC back to our various makefiles and move packet-cosnaming.c back to it. Change-Id: I2f0427ad47bf0e2f166577608da7f5feaf848a48 Reviewed-on: https://code.wireshark.org/review/10691 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-29NCP2222: change ncp.nds_return_all_classes filter type from FT_STRING to ↵Pascal Quantin1-1/+1
FT_UINT32 Otherwise a call to proto_tree_add_uint_format_value will trigger an assert Bug: 11550 Change-Id: Ic30b07a424cd94b861cee8999b91154ceeb72469 Reviewed-on: https://code.wireshark.org/review/10689 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-29Qt: Add F5 as shortcut to refresh interfacesMichal Labedzki1-0/+3
I am tired to go menu to refresh interfaces. Shortcut make our live easier. Change-Id: Ic2a478d7857b8138897088f0a6610df7988b1be9 Reviewed-on: https://code.wireshark.org/review/10520 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-29lte_rlc_statistics: fix cosmetic issues with data in columnsMartin Mathieson1-7/+14
Change-Id: I2bec8de3d5fe84f0a2287c750c9c9151906fe71e Reviewed-on: https://code.wireshark.org/review/10688 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-29[Diameter] Add command code 8388717 Ericsson Trace-ReportAndersBroman1-1/+67
Change-Id: Ifabb920eb4ddb1a46f2dbf7e03478d0abe10305a Reviewed-on: https://code.wireshark.org/review/10687 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-29[Diameter] Add enum value to 3GPP AVP PDN-Type" code="1456"AndersBroman1-0/+1
<enum name="IPv4_OR_IPv6" code="3"/> Change-Id: I8fa328c0c6915cda835754d12bc4d48608608500 Reviewed-on: https://code.wireshark.org/review/10686 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-29tcp: remove misleading, outdated commentPeter Wu1-4/+0
v1.99.1rc0-717-ga2c2f87 removed pinfo->private_data assignment, but left the comment in place. Since v1.99.1rc0-761-g6d207fe, the member is removed completely, so let's drop the comment. Change-Id: Ib36b6b979abda786202867ea1e6ef0d11487f61c Reviewed-on: https://code.wireshark.org/review/10684 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-09-29Decode as (Qt): fix dereference of null pointer found by Clang analyzerPascal Quantin1-5/+10
Also fix usage of 'Decode As' window when no file is opened (broken by gf189cb8) Change-Id: I06ff83394cf31763cecfbbedd99ce7438488872a Reviewed-on: https://code.wireshark.org/review/10665 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-29LTE RRC: upgrade dissector to v12.7.0Pascal Quantin7-637/+1879
Change-Id: I95660eb302fde06c2034b023e60c7b83c67fe71b Reviewed-on: https://code.wireshark.org/review/10680 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-28[isns] re-indent the AddAttribute() functionMartin Kaiser1-314/+314
hopefully, this will make my further patches easier to review Change-Id: If9fe4aa03c08dd38eccae3d4a0accdcbb5d62111 Reviewed-on: https://code.wireshark.org/review/10681 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2015-09-28Qt: fix OVERRUN error reported by Coverity in LTE MAC statistics window (CID ↵Pascal Quantin1-3/+3
1325078) Change-Id: I281b344ea76418399e2a8038f1220310f6a50bc2 Reviewed-on: https://code.wireshark.org/review/10679 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-28Fix tests to allow selection of suite 10Graham Bloice1-48/+23
The tests only allowed a single character suite selection, which prevented suite 10 from being run on its own. Modified test.sh to now require a newline in addition to the input so that a 2 digit number can be entered. Also fixed test display to remove illusion that an individual step could be run. Only whole suites can be run. Change-Id: I4dee0ec6a8e1f34fa443a6a0a3f2d52a73146e54 Reviewed-on: https://code.wireshark.org/review/10676 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-09-28Cosmetic tidy up for the projects in the Visual Studio solutionGraham Bloice3-1/+3
Change-Id: Ie4ed28ee7e59def2e8a15433334988b4d0225d1d Reviewed-on: https://code.wireshark.org/review/10675 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-09-28idl2wrs: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangMichael Mann8-3733/+1152
It looks like "items" could have contributed to fields/data being at an incorrect level off of a tree. Change-Id: I93616ef8b6b364c578f989882045dee42cb6d3c3 Reviewed-on: https://code.wireshark.org/review/8558 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-28Improve IPv6 routing header dissectionJoão Valverde2-128/+190
Remove size limitation of 23 addresses to Type 0. Add validity checks to Type 0 and Type 2. Add address count vs segments left check to RPL. Use hf_ipv6_routing_* for shared routing header fields and hf_ipv6_routing_<type>_* for the rest. Change-Id: I98796504a0f7643476c4c3550586b5da2cf70f6d Reviewed-on: https://code.wireshark.org/review/10470 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-28WSUG: send readers to the wiki's SSL page for help on decryption.Jeff Morriss1-1/+1
This replaces a question (recently remarked upon on -users) with a link to someplace where we already have documentation on the subject. Change-Id: I6c5cf2b0f674c129aaa017da0ca44176c5be665f Reviewed-on: https://code.wireshark.org/review/10677 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-28editcap/reordercap: rename time to frame_time.Dario Lombardo2-12/+12
According to checkAPI. Change-Id: Iddad6253fc4711ed7870eccadb91d94e5fecd24d Reviewed-on: https://code.wireshark.org/review/10672 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-28IPv6: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: Ibe53f22f4f68efd121b8eae48418bad8baabd1a8 Reviewed-on: https://code.wireshark.org/review/10674 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-28LTE RLC Statistics DialogMartin Mathieson9-1/+878
Change-Id: Id0af0227a398fd06ba37c23097fa6809db432d0f Reviewed-on: https://code.wireshark.org/review/10669 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-09-28NCP2222: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I739262c0d6b8bd961cc75a18e7bdbb794806e2b7 Reviewed-on: https://code.wireshark.org/review/10668 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>