aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2001-11-04Allow a dissector to register preferences that it no longer supports asGuy Harris8-14/+144
obsolete; we silently ignore attempts to set those in a preferences file, so that we don't spam the user with error messages caused by them having saved preferences in an earlier release that contained those preferences. Make the Diameter and iSCSI dissectors register obsolete preferences. Crash if some code tries to register a preferences module with a name that contains something other than lower-case ASCII letters, numbers, or underscores, or that has already been registered, or if some code tries to register a preference with a name that contains something other than lower-case ASCII letters, numbers, underscores, or periods, or that has already been registered, so that we don't put code like that in a release and have to shovel code into "prefs.c" to fix it up later. (The problem with multiple modules or preferences with the same name should be obvious; the problem with names with blanks, or upper-case letters, or punctuation, is that they're a pain to type on the command line.) svn path=/trunk/; revision=4148
2001-11-04Updates from Mark Burton.Guy Harris1-92/+122
svn path=/trunk/; revision=4147
2001-11-04More tvbuffication, from Ronnie Sahlberg.Guy Harris1-760/+437
When converting DOS-date years to "struct tm" years, add 1980 and subtract 1900, to make it clearer what the conversion involves (DOS-date years are (year - 1980); "struct tm" years are (year - 1900)). svn path=/trunk/; revision=4146
2001-11-03Check for a zero word count in LogoffandX requests and replies.Guy Harris1-37/+45
svn path=/trunk/; revision=4145
2001-11-03Clean up the Info column, by leaving the ": " that separates badGuy Harris1-2/+5
packet/flag information from the PDU type if there's no bad packet or flag informatin. svn path=/trunk/; revision=4144
2001-11-03Crash if a dissector tries to create more than one preference with theGuy Harris1-3/+17
same name; if that happens, there's no way to tell to which of them a line in a preferences file, or an option supplied with "-o", refers, so it's clearly a bug in the code. This has happened in the past, and fixing that required some preference renaming *and* code in the preferences-file-reading code to try to preserve the user's settings and not spew warnings when starting Ethereal or Tethereal; let's try to catch it *before* the code gets into the code base. svn path=/trunk/; revision=4143
2001-11-03Cooperative Route Filtering Capability support, and Route RefreshGuy Harris3-5/+80
Message bug fix, in BGP, from Motonori Shindo. svn path=/trunk/; revision=4142
2001-11-03Support for desegmentation of Diameter-over-TCP, from David Frascone.Guy Harris1-11/+77
svn path=/trunk/; revision=4141
2001-11-03Clean up the display of the Flags and Flags2 fields, and add a missingGuy Harris1-52/+63
bit to Flags2. svn path=/trunk/; revision=4140
2001-11-03Tvbuffification of Negotiate Protocol, from Ronnie Sahlberg.Guy Harris2-583/+987
Fix up Info column to put "Request" or "Response" *after* the name of the request. Give the Negotiate Protocol request its full name. svn path=/trunk/; revision=4139
2001-11-03First tvbuffication change, from Ronnie Sahlberg. Also changes SMBGuy Harris3-657/+1137
command names to match later SMB specs. svn path=/trunk/; revision=4138
2001-11-03In "addStaticAVP()", add the new entry to the list of AVP types afterGuy Harris1-1/+5
it's filled in. svn path=/trunk/; revision=4137
2001-11-03TVBUFF_SUBSET tvbuffs share a "ds_name" with the parent tvbuff, so theirGuy Harris1-5/+11
"ds_name"s shouldn't be freed when the tvbuff is freed. (Thanks and a tip of the Hatlo hat to the FreeBSD memory allocator for complaining about multiple frees of the same string.) svn path=/trunk/; revision=4136
2001-11-03More indentation fixes.Guy Harris1-2/+2
svn path=/trunk/; revision=4135
2001-11-03Put the error code into the Info column symbolically, if possible.Guy Harris1-6/+12
Put the error message string into the Info column as well. svn path=/trunk/; revision=4134
2001-11-03Put stuff in the Info column regardless of whether we're building aGuy Harris1-56/+86
protocol tree or not. svn path=/trunk/; revision=4133
2001-11-03Small fix to include the arrow pixmaps in the distribution, from AndrewGuy Harris3-1/+8
C. Feren. svn path=/trunk/; revision=4132
2001-11-03When freeing the "gpa_hfinfo" pointer array, free the array itself, asGuy Harris1-3/+3
well as the structure containing it. svn path=/trunk/; revision=4131
2001-11-03Rename the "private" member of the "packet_info" structure toGuy Harris10-23/+23
"private_data", to keep C++ compilers from getting heartburn. svn path=/trunk/; revision=4130
2001-11-03Fix the indentation.Guy Harris1-4/+4
svn path=/trunk/; revision=4129
2001-11-02Fix leak of ds_name. Thanks to Sirop Erable <matrix_ottawa@yahoo.ca>Gilbert Ramirez1-1/+6
svn path=/trunk/; revision=4128
2001-11-02Ahhh,Richard Sharpe1-2/+30
That feels better. Some real programming for once. Guided by Guy, I have cleaned up tftp a bit and added some useful stuff to the summary line. svn path=/trunk/; revision=4127
2001-11-02Support DLT_CISCO_IOS.Gilbert Ramirez2-3/+6
svn path=/trunk/; revision=4126
2001-11-02Add support for 64-bit signed integers in "int-64bit.[ch]", add anGuy Harris7-37/+479
FT_INT64 type, and make the Diameter dissector use it. Handle the 64-bit integer types in the display filter semantics checks. svn path=/trunk/; revision=4125
2001-11-02Don't assume that all UNIX platforms have <iconv.h> - explicitly checkGuy Harris3-5/+7
whether it's present. This puts HAVE_ICONV_H in the "config.h" file, so put in an entry for it in "config.h.win32" - an entry that doesn't define it - and get rid of the check for WIN32 in "xmlstub.h". svn path=/trunk/; revision=4124
2001-11-01Install the files for the XML Diameter dictionary.Guy Harris1-1/+6
svn path=/trunk/; revision=4123
2001-11-01From David Frascone: duUpdate to Diameter dissector to load theGuy Harris11-130/+3317
dictionary as an XML file rather than building it in, and various Diameter updates. svn path=/trunk/; revision=4122
2001-11-01Fix some declarations to match the signatures of "tvb_find_guint8()" andGuy Harris2-6/+6
"tvb_pbrk_guint8()". svn path=/trunk/; revision=4121
2001-11-01Add an option to show the File Offset of a frame. Not useful forGilbert Ramirez1-1/+23
general packet analyzing, but useful when developing wiretap code or other such low-level development. Default preference is *not* to show File Offset. svn path=/trunk/; revision=4120
2001-10-31Display unknown extension types in decimal, not hex (the RFCs give themGuy Harris1-2/+2
in decimal, and the "Extension Type" field is BASE_DEC). svn path=/trunk/; revision=4119
2001-10-31Support for Mobile IP's use of ICMP Router Advertisements, from DavidGuy Harris2-11/+270
Frascone. Small white-space fix. Display the preference level in router advertisements as signed, not unsigned, as per RFC 1256, which says it's a "signed, twos-complement value". svn path=/trunk/; revision=4118
2001-10-31Sigh. Well, if you make the function declarations external, that meansGuy Harris7-4/+208
that they're external when the plugin is compiled, and there's no definition to satisfy the extern, so plugins fail to compile. Add a "plugins/plugin_api_defs.h" header file that defines them, and include that in one (and only one) source file for a particular plugin. svn path=/trunk/; revision=4117
2001-10-31Update the code for the DHCP authentication option to match RFC 3118,Guy Harris1-20/+100
and update the URL for the DHCP parameter value assignments; support a code of 90 for DHCP authentication, as that's what RFC 3118 specifies. Show symbolic values for some of the fields in the DHCP authentication option, and base the decision on whether to dissect the authentication data as HMAC-MD5 data on whether that's what the protocol and algorithm field specified. Show the replay detection value as a 64-bit number only if it's specified to be a monotonically-increasing counter; otherwise, just show it as bytes. svn path=/trunk/; revision=4116
2001-10-31Bug fixes and enhancements to Mobile IP, from David Frascone.Guy Harris2-139/+299
svn path=/trunk/; revision=4115
2001-10-31Put "extern" in front of a pile of function declarations.Guy Harris6-265/+296
It makes no difference if they really are function declarations; however, in plugins, when building on OSes that don't let dynamically-loaded modules access functions in the main program (e.g., Windows), when compiling a plugin, <plugin_api.h> defines the names of those functions as (*pointer_name), so they turn into declarations of pointer variables pointing to the functions in question, and, on platforms with a def/ref model in the linker, if a plugin has more than one source file that gets linked into the plugin, the linker may get upset at two definitions of the same variable. svn path=/trunk/; revision=4114
2001-10-31Add the Ethereal Web site's mirror of WinPcap to the dialog popped up ifGuy Harris1-2/+5
you try to capture on Windows without having WinPcap installed. svn path=/trunk/; revision=4113
2001-10-31Get rid of a bunch of stuff that was there to support non-tvbuffifiedGuy Harris8-167/+43
dissectors and that's no longer needed. svn path=/trunk/; revision=4112
2001-10-30Fix to desegmentation crash, from Ronnie Sahlberg.Guy Harris1-7/+14
svn path=/trunk/; revision=4111
2001-10-30Put in a note telling people NOT to use "tvb_get_ntohl()" orGuy Harris1-3/+11
"tvb_get_letohl()" to fetch IPv4 addresses. svn path=/trunk/; revision=4110
2001-10-30Fix a bunch of places where "tvb_get_letohl()" was being used to fetchGuy Harris2-74/+59
IP addresses - either use "tvb_memcpy()", or just use "proto_tree_add_item()" and leave the fetching up to the core Ethereal code. In the DVMRP dissector, replace a bunch of other "proto_tree_add_XXX()" calls with "proto_tree_add_item()", and use "tvb_reported_length_remaining()" rather than "tvb_length_remaining()" (if we didn't capture enough data because the snapshot length was too low, we *want* an exception to be thrown, so that the frame is marked as a "Short Frame"). svn path=/trunk/; revision=4109
2001-10-30IPv4 addresses should be entered in host byte order, not forcedGuy Harris1-33/+44
little-endian byte order. Use "proto_tree_add_item()" wherever possible. Get rid of line commented out with a C++ comment, as not all C compilers accept C++ comments. Don't put the user name into the protocol tree if it's not there (we really should do TCP segment reassembly for this, but this is at least a good first cut). When checking whether data exists in the packet, use "tvb_offset_exists()", don't compare the offset in the tvbuf with "pinfo->len" - "pinfo->len" is the length of the entire packet, not of the tvbuff. Fix some references to "pi" to refer to "*pinfo" instead. svn path=/trunk/; revision=4108
2001-10-30IPv4 addresses should be entered in host byte order, not forcedGuy Harris1-8/+8
little-endian byte order. svn path=/trunk/; revision=4107
2001-10-30Small fix to previous patch, from Motonori Shindo.Guy Harris1-5/+5
svn path=/trunk/; revision=4106
2001-10-30Squelch a GCC complaint.Guy Harris1-1/+2
svn path=/trunk/; revision=4105
2001-10-30From Shinsuke Suzuki: fix IPv6 PIM checksum computation code to matchGuy Harris3-5/+40
draft-ietf-pim-sm-v2-new-03. svn path=/trunk/; revision=4104
2001-10-30In "u64toa()":Guy Harris1-13/+13
If the byte being investigated is 0, don't just do a "continue"; this might be one of the passes on which we have to propagate carries, so skip the processing of that byte's bits, but fall through to the carry processing. In the carry processing loop, don't use "i" as the loop index, as we're already using it as the outer loop index. In "u64toh()", use lower-case letters rather than upper-case letters, as we use "%x" rather than "%X" to print 8, 16, 24, and 32-bit integral values in the "proto.c" code. svn path=/trunk/; revision=4103
2001-10-29Stop using "tvb_get_ntohll()" and "%llX" in the BOOTP dissector, as theGuy Harris8-113/+12
former depends on having "guint64" and the latter depends on "%ll[douxX]" being what's used to print 64-bit integers, and there are platforms on which Etheeal runs that don't have "guint64" or that don't use "%ll[douxX]" to print 64-bit integers. Get rid of the routines to extract 64-bit integers into "gint64"s and "guint64"s, as per Ronnie Sahlberg's suggestion, to discourage people from writing code that won't work on all platforms; they should be using FT_UINT64, or the routines in "int-64bit.c", instead. svn path=/trunk/; revision=4102
2001-10-29Constify arguments and variables.Guy Harris2-16/+22
svn path=/trunk/; revision=4101
2001-10-29Dissector converted to TVBuffers. The changes are originally fromJeff Foster1-253/+205
Pia Sahlberg <piabar@hotmail.com. svn path=/trunk/; revision=4100
2001-10-29From Ronnie Sahlberg: FT_UINT64 support, code to handle 64-bit integersGuy Harris14-96/+631
without requiring compiler support for them, and updates to the Diameter, L2TP, NFS, and NLM dissectors to use it and to the ONC RPC dissector to allow ONC RPC subdissectors to use it. svn path=/trunk/; revision=4099