aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-02-01Fix leaks when spawning extcap processesMikael Kanstrup1-2/+1
Valgrind reports leaks like these when spawning extcap processes (for example when displaying or refreshing interface list with extcap interfaces present): 3,917 (464 direct, 3,453 indirect) bytes in 29 blocks are definitely lost in loss record 58,301 of 58,638 at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0xA6D2610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6E822D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6B913B: g_error_new_valist (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6B94ED: g_set_error (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA710B03: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA710E17: g_spawn_sync (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0x44C677: extcap_foreach (extcap.c:199) by 0x44CCAD: extcap_interface_list (extcap.c:413) by 0x72B548: capture_interface_list (capture_ifinfo.c:126) by 0x7336FA: scan_local_interfaces (iface_lists.c:141) by 0x55F01F: WiresharkApplication::refreshLocalInterfaces() (wireshark_application.cpp:898) ... Change-Id: If8f750f5f8fa42a6f0884bb0e6bbbd71bd8f68aa Reviewed-on: https://code.wireshark.org/review/13631 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-01main_toolbar: fix redundant redeclaration of ‘cfile’ [-Wredundant-decls]Alexis La Goutte1-2/+0
Change-Id: I25d88852f87fdd8f760f29f9e5fdeb7a63391b87 Reviewed-on: https://code.wireshark.org/review/13636 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-01pre-commit: ignore ASN.1 template filesPascal Quantin1-0/+1
They trigger false positives Change-Id: I0cc22e0600461475e67610ac7e9dc687822c87f2 Reviewed-on: https://code.wireshark.org/review/13639 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-01PIM: fix IPv4/IPv6 filters using the same name for different address typePascal Quantin1-9/+9
Bug: 12061 Change-Id: I42828e1f87abebd6d9a4f893ff28aa50ca7ccbff Reviewed-on: https://code.wireshark.org/review/13640 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-01BGP: Link-State extensions for Segment Routing as perFrancesco Fondelli2-61/+229
draft-gredler-idr-bgp-ls-segment-routing-ext-01 Bug: 12060 Change-Id: I53c837ac5c195bdee716a48d8494633b663e751d Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/13579 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-01LTE RRC: add system info modification for eDRX UEs in info columnPascal Quantin3-4/+17
Change-Id: I8041bf74c37665f1fd70f0d8c39157e09f79d96c Reviewed-on: https://code.wireshark.org/review/13638 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-01IP: Don't check length if in a ICMP error packetStig Bjørlykke1-4/+6
Change-Id: I5fd81aec13655b9c53df9f0002441c3afc51c6e9 Reviewed-on: https://code.wireshark.org/review/13597 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-02-01btatt: Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-2/+3
Change-Id: I3c55af73ba989080cf6dfe206d25a6d4923ac7f1 Reviewed-on: https://code.wireshark.org/review/13622 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-01extcap: Correct save for file argumentsRoland Knall2-3/+22
Also add check to has_configuration Change-Id: Ia0ffbd3bf68ad51c26bc75b5ee179db179e22bd4 Reviewed-on: https://code.wireshark.org/review/13635 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-01extcap: Add Save functionality to options dialogRoland Knall15-35/+343
This patch creates the functionality of saving all parameters for extcap devices in the general preference section. For now, multiselect and fileselect do not save their values but patches for this will be provided in the future Also, all preferences are stored as strings to make handling easier. This might change in the future, but for the first version it will stick. Restore to Defaults is not implemented as of yet, and will be in a future version, once the preference storing is finalized Bug: 11666 Change-Id: I178346405146d2e43f4f3481c05c92c0b3595af5 Reviewed-on: https://code.wireshark.org/review/13451 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-01androiddump: fix printf format warning.Dario Lombardo1-3/+6
Found by clang. Compiler warning: warning: format specifies type 'void *' but the argument has type 'char *' [-Wformat-pedantic] Change-Id: I7f370b06f98490cd6e363a9679a449420c8c8021 Reviewed-on: https://code.wireshark.org/review/13602 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-31[Automatic update for 2016-01-31]Gerald Combs16-1404/+1832
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I7e8ade92cce819240ee8e40cfc63363185d9d944 Reviewed-on: https://code.wireshark.org/review/13625 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-31sshdump: fix documentation issues.Dario Lombardo1-30/+36
Change-Id: I338842e8e66faf883e2533be195a79f34d5d1ee6 Reviewed-on: https://code.wireshark.org/review/13560 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31aim: allow SSL decryptionPeter Wu1-3/+20
Very weak form of heuristics has been added based on the FLAP id byte, but disabled by default. Make it possible to use this protocol in the RSA keys list dialog. Bug: 11990 Change-Id: I61f24ae9679c738194393bed0d012d2a752171b2 Reviewed-on: https://code.wireshark.org/review/13195 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31Switch from QLibrary to ws_load_library.Gerald Combs2-14/+5
From the comments in qlibrary_win.cpp: // We make the following attempts at locating the library: [ ... ] // Windows // if (absolute) // fileName // fileName + ".dll" // else // fileName + ".dll" // fileName We were passing "riched20.dll" to QLibrary, which meant that it searched for "riched20.dll.dll" first. Switch to ws_load_library, which we use elsewhere and which has much safer default behavior. Change-Id: Ic8f0cf5686c9b1856d37e76be4404d6236c076e5 Reviewed-on: https://code.wireshark.org/review/13607 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31plugins: do not import symbols globallyPeter Wu2-2/+2
Clang's ASAN reported an ODR violation when plugins were loaded. Sure enough, symbols did actually get loaded twice: ==5898==ERROR: AddressSanitizer: odr-violation (0x7fffd95a35e0): [1] size=7 'version' plugins/mate/plugin.c:19:31 [2] size=6 'version' plugins/opcua/plugin.c:19:31 After this change, plugins cannot insert new symbols in the global namespace. Change-Id: Ib11f7263e9c586f8e7c1f8f5fb239b20d46ddd2f Reviewed-on: https://code.wireshark.org/review/13260 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31lemon: fix leak.Dario Lombardo1-2/+6
Found by clang's ccc-analyzer. Change-Id: I04eaad73486a43a77c4f08cf519bbfe7d2d8c838 Reviewed-on: https://code.wireshark.org/review/13581 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31RLC LTE: upgrade dissector to v13.0.0Pascal Quantin8-123/+433
Change-Id: Ibe4586925ffe49f5aaab72956c40e123855a1a1e Reviewed-on: https://code.wireshark.org/review/13620 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-31Fix memleaks on interface refresh when extcap configs existsMikael Kanstrup1-1/+7
If there are extcap interfaces present then each time the capture interfaces list is displayed or refreshed a number of extcap related allocations are leaked. Valgrind reports leaks like these: 2,007 (144 direct, 1,863 indirect) bytes in 6 blocks are definitely lost in loss record 64,328 of 65,138 at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0xA6D2610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6E822D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6C94F3: g_list_append (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0x44C9AF: search_cb (extcap.c:451) by 0x44C6FC: extcap_foreach (extcap.c:204) by 0x44CDFF: extcap_get_if_configuration (extcap.c:473) by 0x44CE3C: extcap_has_configuration (extcap.c:489) by 0x654356: InterfaceTree::display() (interface_tree.cpp:199) by 0x6547DF: InterfaceTree::getInterfaceList() (interface_tree.cpp:252) by 0xBFCF2A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1) by 0x563F9A: WiresharkApplication::allSystemsGo() (wireshark_application.cpp:914) by 0x4478D9: main (wireshark-qt.cpp:1373) 9,126 (432 direct, 8,694 indirect) bytes in 18 blocks are definitely lost in loss record 58,524 of 58,638 at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0xA6D2610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6E822D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0xA6C94F3: g_list_append (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0) by 0x44C9AF: search_cb (extcap.c:451) by 0x44C6FC: extcap_foreach (extcap.c:204) by 0x44CDFF: extcap_get_if_configuration (extcap.c:473) by 0x44CE3C: extcap_has_configuration (extcap.c:489) by 0x654356: InterfaceTree::display() (interface_tree.cpp:199) by 0xBFCF2A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1) by 0x4A3214: MainWindow::on_actionCaptureRefreshInterfaces_triggered() (main_window_slots.cpp:3605) ... Change-Id: I9433b8e36813cbef9dca5ab08074e985793f4d0d Reviewed-on: https://code.wireshark.org/review/13617 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-31RLC LTE: fix dissection of RLC AM PDUs with odd number of 15 bits LIPascal Quantin1-1/+1
There is no padding in that case Change-Id: Ib0ce37c4fea76435b4cedfbd7d3d72420e4860eb Reviewed-on: https://code.wireshark.org/review/13618 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-31autotools: Add '-Qunused-arguments' to build flags (clang only).João Valverde1-0/+5
CMake build is already using it. Change-Id: Id0df316d41133bdb0483f3aa4c67d7a6b53aaf0c Reviewed-on: https://code.wireshark.org/review/13616 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-31autotools: Fix 'make dumpabi'João Valverde1-2/+2
Broken by g265a41e. Change-Id: I54069cbc3ca8151038f59f77cb2d0ec71635fb45 Reviewed-on: https://code.wireshark.org/review/13615 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-31CAPWAP: fix indent typoAlexis La Goutte1-3/+3
Change-Id: Iae736048a17d2aae75f7ec7dcc516e86aa05f6bc Reviewed-on: https://code.wireshark.org/review/13574 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31LCSAP: fix indent (use 2 spaces and add modelines)Alexis La Goutte3-271/+285
Change-Id: I2aa1a2d0e20cca6c979d51135e7fe9ea7a084847 Reviewed-on: https://code.wireshark.org/review/13609 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31Fixed Cisco Vendor IDs in IKEv2 dissector.Xavier Brouckaert1-2/+34
Change-Id: Idb8fce8fae1b2b580f9ca7a9c71e430bfa7dfb44 Reviewed-on: https://code.wireshark.org/review/13606 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31CIP: fix no previous prototype for ↵Alexis La Goutte1-1/+1
'dissect_segment_network_production_inhibit_us' [-Wmissing-prototypes] Change-Id: Ic23b26f87f38db0a40213ce7c954c8618dc966eb Reviewed-on: https://code.wireshark.org/review/13610 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31MEGACO: fix dissection of packetsPascal Quantin1-10/+10
Bug introduced in g841f636 Bug: 12059 Change-Id: I02a33f95baf2670fb491c951ba85a1bacdeb6386 Reviewed-on: https://code.wireshark.org/review/13613 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-30Update filter bookmark icons.Gerald Combs23-26/+547
Separate the capture and display filter bookmark icons. Make the capture icon green to match(-ish) the active capture icon. Tested on nice+new and janky+old displays. Change-Id: I6ed532c8a49da50fe2a7de3d8fbd0b1af7623b4a Reviewed-on: https://code.wireshark.org/review/13612 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-29No need for a routine to return a GSList of extensions for compressed files.Guy Harris3-73/+26
Just use the table - or an empty table if we're not including the compressed file extensions. Change-Id: I0b3ef3987e1986953f2957c27c84b2ee59b90bc0 Reviewed-on: https://code.wireshark.org/review/13611 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-29Add a note about Dell Backup and Recovery.Gerald Combs1-0/+3
Change-Id: I5600b1aabb8bb4c1dc2135ae01b1a5070d2a2ccb Reviewed-on: https://code.wireshark.org/review/13603 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-29gsm_map: decode SRISM v1 and v2 resultLuke Mewburn3-5/+123
Fix decoding of sendRoutingInfoForSM (SRISM) application contexts version 1 and version 2. Use a (slightly modified) version of the ASN.1 from ETS 300 599: December 2000 (GSM 09.02 version 4.19.1), clause 14.7.6 which has LocationInfoWithLMSI that is incompatible with application context version 3 in 3GPP TS 29.002 version 3.20.0 Release 1999, clause 17.7.6. Bug: 9622 Ping-Bug: 9704 Change-Id: Icc9a0a1743a6eb4c907f4cab3fb2137db139ad74 Reviewed-on: https://code.wireshark.org/review/13572 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-29tools: improve debian-setup with optional packages.Dario Lombardo1-2/+20
Change-Id: Ie7480b0c5297039aadfa253fce84c66b0e217814 Reviewed-on: https://code.wireshark.org/review/13596 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-01-29lemon: Have Makefile.am handle warnings as errors correctlyJoão Valverde1-1/+1
Change-Id: If0d59eb109802a799c33e439e607178102678f7d Reviewed-on: https://code.wireshark.org/review/13580 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-29RoHC: fix an assert when dissecting partially an IR-DYN packetPascal Quantin1-1/+3
Change-Id: Ibcb0a109a38524481bc8639bc73ab73acd07ca1a Reviewed-on: https://code.wireshark.org/review/13598 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-29GTP session ID generated tree item for tracking GTPv1 sessionsGloria Pozuelo1-265/+610
Change-Id: I9192a58a9ec6676b2cba0f30bb45b4eaa8d82655 Reviewed-on: https://code.wireshark.org/review/11577 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-29tds: don't THROW() an exception from a dissectorMartin Kaiser1-1/+6
return the error to the caller, exit the loop and the dissection... Change-Id: Iba64a5d5e4f79bc33c2b1c91b937c9726e15a802 Reviewed-on: https://code.wireshark.org/review/13587 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-01-29Qt: No capture filter bookmarks in capture interfaces listStig Bjørlykke3-4/+4
Change-Id: I4f53758c0fa4448656daac3ad186a6b0e687fc5c Reviewed-on: https://code.wireshark.org/review/13593 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-29Add A-MPDU reassembly information to the radio metadata.Guy Harris4-4/+55
Change-Id: I338e7fb60ff62d1d26ca0b32468ada4294d52d8d Reviewed-on: https://code.wireshark.org/review/13594 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-29Try to fix 'make distcheck'João Valverde1-2/+3
Change-Id: I1656ca8e86e506f39ef7f7600bd9d5a21670ad1e Reviewed-on: https://code.wireshark.org/review/13589 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28Another fix for g265a41eJoão Valverde1-2/+1
Disable -Werror as before. Change-Id: Iec27be6eba742555bce28bb1c81c2e15153db566 Reviewed-on: https://code.wireshark.org/review/13588 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28LCSAP: improve dissectionPascal Quantin3-25/+90
- add PLMN info in a subtree - dissect Horizontal Accuracy - dissect Vertical Accuracy - dissect IMSI Bug: 12054 Change-Id: Ic069d78f23fcf956e4aa5eb19f4d39af0f529757 Reviewed-on: https://code.wireshark.org/review/13585 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-28Qt: Enable capture filter bookmarksStig Bjørlykke6-13/+167
Update the code handling capture filter bookmarks and enable the bookmark button and clear button in CaptureFilterEdit(). Disable the apply button (which starts a capture) for now. Bug: 11836 Change-Id: Ia33cbb8c9bb839be037112eef26daf744c4ea8f8 Reviewed-on: https://code.wireshark.org/review/13568 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-28MATE: Disable Werror as before g265a41eJoão Valverde1-2/+1
Change-Id: Ia89f40245e5b7eab2dc23ce7b37d5107863bbfdd Reviewed-on: https://code.wireshark.org/review/13583 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28Qt: Update display filter bookmarks when list changedStig Bjørlykke5-26/+79
Recreate the display filter bookmarks menu only when the list has changed, not every time the display filter changes. The list changes when removing an entry from the menu and when changing the list in the "Manage Display Filters" dialog. Save the list when removing an entry from the menu. Change-Id: Icd08e0a80085cca55c0e63177d45abe4902c7c3e Reviewed-on: https://code.wireshark.org/review/13567 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-28autotools: Don't use "user variables" to set build flagsJoão Valverde38-537/+302
GNU coding standards recommend against it and automake is designed around it. This allows overriding the global build flags using AM_CFLAGS, etc., or per object flags, something that is difficult or impossible currently because of automake precedence rules. Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12 Reviewed-on: https://code.wireshark.org/review/13455 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28extcap: Cleanup complex types and add save optionRoland Knall11-320/+161
Cleanup handling of complex data types and use only glib defined datatypes while handling argument values. Add a save parameter, which (additionally) can set, that a parameter is not saved in a configuration file. Passwords are by default not saved, which may be overwritten using this parameter Change-Id: I67eff0f3286170f082d532e806a39511c40df647 Reviewed-on: https://code.wireshark.org/review/13573 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-28codecs: add deregister_codec APIPascal Quantin3-0/+16
Change-Id: I83ecc7e4f8c827c83c2f6b62918f042d023daee4 Reviewed-on: https://code.wireshark.org/review/13575 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-28Add fnmatch support to git pre-commit hookJoão Valverde4-37/+125
Allows for wildcard pathname matching in ignore list. Change-Id: I52e47c72c69e16ff9aefadfde22d1bd682df9654 Reviewed-on: https://code.wireshark.org/review/13166 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-28correctly decode GSM_MAP invoke SRISMv1Luke Mewburn3-4/+10
The decoding of application context version 1 SendRoutingInfoForSM (SRISM) invokes (added in bug 9704) had issues: - The ASN.1 for RoutingInfoForSM-ArgV1 in GSMMAP.asn lacked teleserviceCode and the extension marker. ETSI ETS 300 599 (GSM 09.02 version 4.19.1) clause 14.7.6 has teleserviceCode and the extension marker, but not cug-Interlock. Clause C.6.4 mentions that cug-Interlock has been deleted, but it's retained here for decoding backwards compat. - The test for which application_context_version to decode as didn't work when that value was 0 (i.e. missing). Ping-Bug: 9704 Change-Id: I8a8170d959347a47413cfd9876022e9182256452 Reviewed-on: https://code.wireshark.org/review/13571 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-28packet-simple: SIMPLE dissectorPeter Ross4-0/+720
Change-Id: Ia3fc0a959c4f5930bd5ab2b58065f55dcec407de Reviewed-on: https://code.wireshark.org/review/13409 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-26 21:49:59 +0000