aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-13Put the main() and wmain() routines for CLI programs into a separate file.Guy Harris22-314/+148
That means that code is only in one place, rather than having copies of it in each of those programs. CLI programs that, on Windows, should get UTF-8 arguments rather than arguments in the local code page should: include the top-level cli_main.h header; define the main function as real_main(); be built with the top-level cli_main.c file. On UN*X, cli_main.c has a main() program, and just passes the arguments on to real_main(). On Windows, cli_main.c has a wmain() function that converts the UTF-16 arguments it's handed to UTF-8 arguments, using WideCharToMultiByte() so that it doesn't use any functions other than those provided by the system, and then calls real_main() with the argument count and UTF-8 arguments. Change-Id: I8b11f01dbc5c63fce599d1bef9ad96cd92c3c01e Reviewed-on: https://code.wireshark.org/review/31017 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-132.9.0 → 2.9.1.Gerald Combs5-8/+13
Change-Id: I5c1a26f234289edeb9e29f5b8a8bdd220bd49ecf Reviewed-on: https://code.wireshark.org/review/31028 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12Build 2.9.0.Gerald Combs3-780/+2932
Change-Id: Id2fb03127c3f4e371a11ba7788a5a3439bafc651 Reviewed-on: https://code.wireshark.org/review/31027 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12Release notes: Add a note about Qt 5.12.0.Gerald Combs1-0/+2
Change-Id: Ibe72b940bff14729d06dd46651a5205bd0ddcafe Reviewed-on: https://code.wireshark.org/review/31025 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12GSM A: detect buffer overrun when decoding MS Classmark 3 IEPascal Quantin1-2/+7
Change-Id: I12d372afd8a50b9a04f92c53077e79116db6c255 Reviewed-on: https://code.wireshark.org/review/31024 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-12NSIS: Increase our verbosity.Gerald Combs1-6/+7
Pass /V4 to makensis so that we can see what files are in our package. Change-Id: I4d1225f8cfce66945d086bc6481f739a56f16549 Reviewed-on: https://code.wireshark.org/review/31023 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12Packaging: Add initial support for AppImage.Gerald Combs3-0/+79
Add an "appimage" target that will create an AppImage package. Current AppImage tools assume that you only have one executable, so add a custom AppRun wrapper that will let you run our associated CLI utilities via symlinks, e.g. ln -s ./Wireshark-3.2.1-x86.appimage capinfos ./capinfos --help Packaging requires both linuxdeployqt and appimagetool, although we might be able to reduce this to just linuxdeployqt: https://github.com/probonopd/linuxdeployqt https://github.com/AppImage/AppImageKit I haven't done much testing beyond running Wireshark and capinfos. There are undoubtedly issues that need to be fixed. Bug: 14464 Change-Id: Ic004ba1962e6a8630ebb017349d9b2c0462fd5fe Reviewed-on: https://code.wireshark.org/review/30953 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-12opcua: fix typo, use the commonly used 'Endpoint' instead of 'EndPoint'Hannes Mezger1-1/+1
Change-Id: I403673962987e4da0711896e8ae3e60af34acb4e Reviewed-on: https://code.wireshark.org/review/31019 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-12opcua: add support for new reverse hello messageHannes Mezger3-0/+20
The reverse hello message type was added in OPC UA specification 1.04. Change-Id: I00095e35049b8f38ab183ded1b96af51d788d986 Reviewed-on: https://code.wireshark.org/review/31018 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-12HPAV: Expanding support for HPGPSergey Rak1-225/+3040
Added support for different OUI: ST/IoTecha and Qualcomm-Atheros Signed-off-by: Sergey Rak <sergrak@iotecha.com> Bug: 15348 Change-Id: If71479339b95b5c26e84ffceb2f00307b3de680c Reviewed-on: https://code.wireshark.org/review/30969 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-12Properly convert command-line arguments to UTF-8 on Windows.Guy Harris1-2/+20
Do the same thing we do for most other command-line programs - on Windows, have wmain() rather than main(), convert the UTF-16 argument lists to UTF-8, and pass them on to real_main(), otherwise just have main() call real_main(). That way, they never pass through the local code page on Windows. Change-Id: Ib74176dd0586c012eabaa3376c1d7dcba8838978 Reviewed-on: https://code.wireshark.org/review/31014 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-12Add the VCS version number to the appname option if it's a Git build.Guy Harris1-4/+8
Change-Id: I193db5d5c7bd3668d096c72dc231ea43fa4894ec Reviewed-on: https://code.wireshark.org/review/31013 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-12mergecap: set full name as capture applicationJaap Keuter1-4/+8
When mergecap is generating a PCAPNG capture file it sets its name ("mergecap") as the capture application. This seems rather limited, compared to e.g., text2pcap. This change sets the capture application name to "mergecap" with full details, the same as text2pcap: "mergecap (Wireshark) 2.9.0 (v2.9.0rc0-2798-g47d5a923)" Change-Id: Ia08717a9f2bcaa3fa1dc8ce13afcdaa8a0bc0c66 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/31011 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-11Update the release notes.Gerald Combs1-26/+30
Clean up the release notes in preparation for 2.9.0 and 3.0. Change-Id: I7feb37846ce0b1c3caf248f616943b0f80cf60f3 Reviewed-on: https://code.wireshark.org/review/31012 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-11ISIS: add dissection of Node/Link MSD (rfc8491)Taisuke Sasaki1-1/+1
Revert a wording Sub-TLV back to SubCLV according to review 30985. Change-Id: I1f7a2a586d45fe8548c1589baa2803616cf5bd20 Reviewed-on: https://code.wireshark.org/review/31008 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11DNP3: Fix events with relative timeGraham Bloice1-2/+2
The calculation for relative times incorrectly converted ms to ns. Change-Id: I4357d89e45b3f31a5c222e4b8f82edc720766a6e Reviewed-on: https://code.wireshark.org/review/31009 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2018-12-11BGP: Decode MCAST-VPN safi for IPv6Uli Heilmeier1-0/+5
Bug: 15351 Change-Id: Iaac74d6e1e78a4dde2a2f807b909177c733fd05f Reviewed-on: https://code.wireshark.org/review/31007 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11HPAV: fix whitespaces in dissectorSergey Rak1-3938/+3939
Changed modelines: c-basic-offset: 4 to keep consistency between files Also added style for emacs as it is the most common for this file Signed-off-by: Sergey Rak <sergrak@iotecha.com> Change-Id: I62b6e16d614ebe2bacce330e3aaa12796d6b248b Reviewed-on: https://code.wireshark.org/review/30988 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11ASNI MAP: AnalogRedirectRecord is OPTIONAL in QualificationRequestAnders Broman2-34/+34
Bug: 15350 Change-Id: Ibe7f085daa2981168b3c5201256d674feb4cb7e5 Reviewed-on: https://code.wireshark.org/review/31004 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11CIP: Show more unparsed dataDylan Ulis1-34/+44
Extra data could be an indicator of a problem, or it could be that we haven't added support in Wireshark for it yet. Either way, it's helpful to show it, instead of hiding it. Changes: 1. Show unparsed data in the CIP CM dissector 2. Clean up some offsets Change-Id: Ieebe208aab1f293f97a8774a6a4de5d5dbd3df67 Reviewed-on: https://code.wireshark.org/review/31003 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11ENIP: Add more error checkingDylan Ulis1-0/+23
1. Added a check that the Common Packet Format Item Length < remaining data for that layer. 2. Added a check that there should always be at least 4 bytes available for each Common Packet Format item (Type ID + Length) Change-Id: Ie6f2b7904d52d8699c06cfef6844cf0032293d97 Reviewed-on: https://code.wireshark.org/review/31002 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11CIP Safety: Minor additionsDylan Ulis2-10/+18
1. Add 2x new Safety Supervisor services 2. Add more enum types for Device Status 3. Match field names to current spec 4. Add some BASE_UNIT_STRING units Change-Id: I8fedb7cea55fb44eccf641ca60ab849847db2620 Reviewed-on: https://code.wireshark.org/review/31001 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10DOCSIS: Added some additional tlvsBruno Verstuyft2-3/+51
TLV 26.13 PHS Dynamic Bonding Change Action TLV 48.4.2 Receive Module Adjacent Channels TLV 64.3 Static Multicast CMIM Encoding Change-Id: I3a48e0092e7fe523adfdff5b155dcdbb88720f41 Reviewed-on: https://code.wireshark.org/review/30997 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-10json_dumper: add support to convert dots in underscores.Dario Lombardo2-4/+8
This is needed for ek json compatibility. Change-Id: I75c74a1dc7996f3f4c17071508655ae6e3c6b94c Reviewed-on: https://code.wireshark.org/review/30993 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-10packet-rsl: Add Establishment Cause from Channel Request to proto treePau Espin Pedrol1-2/+84
Change-Id: I41709466bdb8427b759d236406505081d7d6f283 Reviewed-on: https://code.wireshark.org/review/30996 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-10couchbase: Add durable DCP commandsJim Walker1-0/+101
Adding DCP prepare, seqno-ack, commit and abort Change-Id: Ife7726c91962ab7fc41bc981ee98418474d33385 Reviewed-on: https://code.wireshark.org/review/30989 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10CIP: Add Connection IndexDylan Ulis2-1/+41
Add cip.connection. This works just like tcp.stream, but for CIP connections. This is added to CIP connected messages and the Forward Open/Close messages. Change-Id: Ib358c00dc0a4fd61065cb22b0e9b574ac43a44a4 Reviewed-on: https://code.wireshark.org/review/30984 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10Diameter: Sort application id numerically.Anders Broman1-2/+2
Change-Id: I83e80fc2fcdd020556df59badcad4205c0f39c75 Reviewed-on: https://code.wireshark.org/review/30995 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10ISIS: add dissection of Node/Link MSD (rfc8491)Taisuke Sasaki1-2/+58
Also add Strict SPF in SR-Algorithm Sub-TLV (draft-ietf-isis-segment-routing-extensions-21) Change-Id: Icc564f093075d2d6edf5b25ac90e41c987ea71e8 Reviewed-on: https://code.wireshark.org/review/30985 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10p_mul: Detect Data PDU sequence number 0Stig Bjørlykke1-1/+11
Data PDU sequence number 0 is illegal, add an expert info for this. Don't include this packet in SEQ/ACK analysis. Bug: 15337 Change-Id: I476088531e8a3605393ee1dedf1e8b159dac342b Reviewed-on: https://code.wireshark.org/review/30980 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09Multicast Statistics Dialog: Clear list when redrawingMichael Mann1-0/+3
The multicast statistics tap provides a continually updating list which the draw function just has to iterate through. Bug: 15271 Change-Id: I270e7ca9460ec9568756b6c8d98f4f17653c8cad Reviewed-on: https://code.wireshark.org/review/30976 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-09enip: rearrange struct member to avoid -Wmissing-braces warningPeter Wu1-1/+1
Fix false positive warning: epan/dissectors/packet-cipsafety.c:1960:37: warning: suggest braces around initialization of subobject [-Wmissing-braces] enip_conn_val_t eip_conn_info = {0}; This is a Clang bug: https://bugs.llvm.org/show_bug.cgi?id=39931 Change-Id: I9f3040ae6bd4d5a2fafe21a37ac4b504933eabcf Reviewed-on: https://code.wireshark.org/review/30979 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dylan Ulis <daulis0@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-09json_dumper: support 'null' json object.Dario Lombardo1-0/+5
Allow the function json_puts_string() to be called with the NULL argument that translates to 'null' json object. Change-Id: I3d2aafad446962d3342ab30b9d509f054d393c64 Reviewed-on: https://code.wireshark.org/review/30978 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-12-09[Automatic update for 2018-12-09]Gerald Combs14-3484/+408
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I29aca5c44e8371ffede8b66eebbb366aac7ac4f9 Reviewed-on: https://code.wireshark.org/review/30973 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-09CIP: Improve connected data informationDylan Ulis6-77/+136
1. For each connected data message, display generated connection information including: a. Connection Path from the initial connection b. API values c. Forward Open packet number. (This already existed, but moving it to a consistent place in the tree) 2. Display O->T or T->O in the Info column depending on the direction of data. 3. Remove cip.conn_path_class filter. This was originally added to show which type of data is in a given packet. But, it's not really needed anymore because we have the generated connection path in each connected data packet now. 4. Ensure dummy structs used for Decode As menus are zeroed out. 5. memset -> zero initialization pcaps from the following bug reports are good examples: Bug: 14939 Bug: 6617 Bug: 14916 Bug: 14958 Change-Id: I63885a5ca41f95e04f855a1e1dcd9ab3684f7eec Reviewed-on: https://code.wireshark.org/review/30808 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09packet-nfs.c: Bugfix NFSv4 ACCESS replyJohn Bankier1-8/+17
Both NFSv3 and NFSv4 ACCESS reply dissection will be sensible when the ACCESS request is not available (because the packet containing the request was either not capture or truncated). Bug: 15343 Change-Id: I5bf7b9905e85b1c1eb30e2949b9b246b54f9ec68 Reviewed-on: https://code.wireshark.org/review/30965 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09Add tvb_get_token_lenMichael Mann3-0/+88
This is intended to be a replacement for get_token_len (from strutil.h) when its used on a tvb. It should be a little safer and remove the need for a dissector to use tvb_get_ptr. Change-Id: Ib2d4a79718b6fba4eb9acc0129b13be6c8199a43 Reviewed-on: https://code.wireshark.org/review/30892 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09BitTorrent:Add Fast Extension Message(Bep06) analysisLee Serin1-1/+26
Add message type named 'fast extension' to analyze unprocessed messages Bug: 15345 Change-Id: I62fce2b753899cb4f2ba833a58388906c9f0d2d3 Reviewed-on: https://code.wireshark.org/review/30954 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09CMake: allow nested structures to be initialized via { 0 }Peter Wu1-2/+7
This is already permitted since C89 and popular compilers seem to support it (including Clang 3.0 - 7.0, GCC 4.1.2 - 8.2 and MSVC 2015). GCC used to be buggy: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 C89 6.5.7. Initialization: "only enough initializers from the list are taken to account for the members of the subaggregate". Change-Id: Ic59b9fe71e2d3ce60b4b7d1074f8d84af01a817a Reviewed-on: https://code.wireshark.org/review/30968 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-09proto: make ws_type_to_elastic static.Dario Lombardo1-1/+2
Change-Id: I15d1075a1447a6f550d600f765e6abc8dae862ad Reviewed-on: https://code.wireshark.org/review/30972 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-08cattp: use the version bits in the heristic checkMartin Kaiser1-1/+7
The CAT-TP specification says explicitly that the version bits must be zero. Fail the heuristic check if they aren't. I checked ETSI TS 102 127 V15.0.0 from https://www.etsi.org/deliver/etsi_ts/102100_102199/102127/15.00.00_60/ts_102127v150000p.pdf Bug: 15342 Change-Id: I05a886ccd5811f367abdb9faead4983d137c12c6 Reviewed-on: https://code.wireshark.org/review/30970 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-08Remove some unused images.Gerald Combs3-287/+0
Change-Id: Id53cf3f120af755e296262ee5caa9dbf84ea1194 Reviewed-on: https://code.wireshark.org/review/30964 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2018-12-07DOCSIS: bugfix: correct dissection of encrypted Mac Specific frameBruno Verstuyft1-6/+16
Change-Id: Id7e300cafe90c965f5eb94f035e872ff6a8231b7 Reviewed-on: https://code.wireshark.org/review/30960 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-07couchbase: Improve key decoderJim Walker1-5/+5
Using the recent updates occasional 'trailing' byte warnings occur if the key encodes a collection-ID, with these changes we now get much better key decoding, without the warnings with and without collections. Change-Id: I9fc1e0d807c8054065a7346a09b0ce99d05f1e63 Reviewed-on: https://code.wireshark.org/review/30956 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-07RTP: Check that we have p_conv_data before accessing it.Anders Broman1-1/+3
Bug: 15346 Change-Id: Ia6ad53423e674832ebb3ccd7c755dd60fecc2cb1 Reviewed-on: https://code.wireshark.org/review/30962 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07DOCSIS: better decoding for unknown tlvsBruno Verstuyft1-46/+95
Previous decoding showed "Unknown TLV: <TLV value>". This was confusing, because people interpreted the value as the type of the unknown TLV. Change-Id: Ia9259db547fca393c248f78ea7c758969b69548e Reviewed-on: https://code.wireshark.org/review/30959 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07dof: remove unnecessary uat_load callsPeter Wu1-5/+0
UATs are loaded at startup, no need to do it again. Call chain: epan_load_settings -> read_prefs -> init_prefs -> uat_load_all. Change-Id: I57caabafb16b0b46fcb6d1621dd6b503154c805c Reviewed-on: https://code.wireshark.org/review/30958 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07GTP: Use correct length for gtp.cgi_ci, gtp.sai_sac and gtp.rai_racAnders Broman1-3/+15
Change-Id: I405bdac11283b83672433995285988c43766e4ab Reviewed-on: https://code.wireshark.org/review/30957 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07PCAP/PCAPNG: Be consistent in documentation, etcJaap Keuter8-45/+61
1) The default build configuration is to select PCAPNG as output format, but it can be selected as PCAP. Some of the command line tools have the option to select the output format and default towards the build configuration. This has to be reflected in their help output also. 2) Various documentation files are still stating that PCAP is the default format of various tools. With the default build configuration being PCAPNG these have to be adjusted as well. (with lack of dynamic content the documentation can only refer to the default build configuration format). Change-Id: I51d19642a7ed8c99817971c1f25d20972095021e Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30951 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-07WSMP: Make sure our PSID is initialized.Gerald Combs1-0/+1
Fixes a scan-build warning. Change-Id: I5e6b94240e87684fc41ef1a4daf4272d429f00d4 Reviewed-on: https://code.wireshark.org/review/30952 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 12:22:45 +0000