aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-12-31Add interface for "pinos" (Protocols in name only)Michael Mann5-12/+183
This is for dissectors that need distinguishing names either for registering multiple dissection functions in a single dissector table or for "internal" dissectors whose just need a name associated with the dissection function. Features like enable/disable are handled by the "parent" protocol. This avoids clutter in the "official" protocol list. Change-Id: I69e7d27d332ae85286f254e95e8d79920da7a9e2 Reviewed-on: https://code.wireshark.org/review/19464 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-31TLS(1.3): Add PSK Key Exchanges Modes (45) hello extensionAlexis La Goutte2-2/+53
Ping-Bug: 12779 Change-Id: Ie797a437240e5530d74e3039f12a60a6f0395d0a Reviewed-on: https://code.wireshark.org/review/18916 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-31Dissectors don't need a journey of self discovery.Michael Mann209-943/+688
They already know who they are when they register themselves. Saving the handle then to avoid finding it later. Not sure if this will increase unnecessary register_dissector functions (instead of using create_dissector_handle in proto_reg_handoff function) when other dissectors copy/paste, but it should make startup time a few microseconds better. Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43 Reviewed-on: https://code.wireshark.org/review/19481 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30Add BASE_NO_DISPLAY_VALUE to allow field value to not be shown.Michael Mann3-17/+28
There are times when byte arrays don't want to show their value in the packet tree or there is a field that is the "header" of a subtree where showing the field value distracts from the tree display. For these cases, BASE_NO_DISPLAY_VALUE can be used to not display the value. Change-Id: I8c9f1f57cd2e663dbee07e2289e7f5e1f22d1e32 Reviewed-on: https://code.wireshark.org/review/19479 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-30ENC: fix parsing of header broken by gee242bdPascal Quantin1-3/+3
From the code before change, it appears that only SPI field is in network byte order. Bug: 13279 Change-Id: Ia157b43a9da30d61dc9cb7607c66d44c8f607498 Reviewed-on: https://code.wireshark.org/review/19477 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-30Revert "Support all MA modes, fix BB CRC and frag edge cases"Paul Williamson1-175/+85
Supporting all MA modes this way makes the dissector useless as a heuristic dissector; it always matches. I just didn't understand about heuristic dissectors, and will look for a better solution. The fragmentation edge cases were also misunderstood. On closer reading of the spec, these are not valid edge cases to be handled smoothly, but packet formatting errors to be diagnosed. The BB CRC fix is valid AFAIK, and will be resubmitted separately. This reverts commit 2563503301aa4321a9a7a1ed392c9cbbe147fd2f. Change-Id: I842f4eca59193b24f41a67ce7d081c681b70f449 Reviewed-on: https://code.wireshark.org/review/19449 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30cms: don't assert if eContent fails to be dissectedРоман Донченко2-15/+21
If eContent is not an octet string, content_tvb will be null, and attempting to use it will trigger an assertion. Besides ill-formed files, this can also occur in old-style PKCS #7 files, since in PKCS #7 the corresponding field has the ANY type, rather than OCTET STRING. Change-Id: I9a5bce983aa82107a9602317737c183461cac7f3 Reviewed-on: https://code.wireshark.org/review/19448 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30QUIC: Add SMHL (Support Max Header List Size) tagAlexis La Goutte1-1/+14
Change-Id: I093f71d3ca409e048211fedf671551721b94d535 Reviewed-on: https://code.wireshark.org/review/19474 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30QUIC: fix link to error codeAlexis La Goutte1-2/+2
Change-Id: If5a0e547c1fb952584f7e661ae5ad1abfdf4bec3 Reviewed-on: https://code.wireshark.org/review/19473 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30enc (openBSD): Add reserved/unused field for flagsAlexis La Goutte1-4/+11
and fix also bitmap (32 bits) Change-Id: I04b7cb64bf7d593648131c09d05eb8e9b1eca8ca Reviewed-on: https://code.wireshark.org/review/19471 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30enc (openBSD): fix flags field descriptionAlexis La Goutte1-3/+3
Change-Id: I5b17d4bfea82770458b002aacfca0fc941639899 Reviewed-on: https://code.wireshark.org/review/19470 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-30androiddump: add missing sys/time.h headerBaruch Siach1-0/+4
struct timeval requires sys/time.h. Fixes the following musl libc build error: androiddump.c: In function 'useSndTimeout': androiddump.c:262:18: error: variable 'socket_timeout' has initializer but incomplete type const struct timeval socket_timeout = { ^ Change-Id: I52e204f32a012aabea2e54877e564576c072fe08 Reviewed-on: https://code.wireshark.org/review/19460 Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-30UDLD: Use correct flag bitsJaap Keuter1-2/+2
Assigned flag bits are the least significant bits of the flags field, not at the most significant end. Bug: 13280 Change-Id: Ie568df6ca137c491fedb32cf2316a0240270b3d6 Reviewed-on: https://code.wireshark.org/review/19463 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-30Three count 'em three different names for the OS.Guy Harris1-1/+1
Change-Id: Icb53c200e95a55b648297bbf5237662c3adaeb84 Reviewed-on: https://code.wireshark.org/review/19465 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-30lemon: Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-1/+1
lemon.c:877:10: warning: Access to field 'lhs' results in a dereference of a null pointer (loaded from field 'startRule') lemon.c:1141:22: warning: Access to field 'lhs' results in a dereference of a null pointer (loaded from field 'startRule') it is false positve lem.nrule==0 implies lem.rule==NULL Change-Id: Id63086990762fbf5195bce34a28f25aeb7a246f7 Reviewed-on: https://code.wireshark.org/review/19445 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-29Fix Interface Selection ListRoland Knall1-3/+6
Fixes issue introduced with Ib82519362454094f64abf1cbe6d7bc917990d7ac Change-Id: I9fbf376c03f2ead1575ca30e8ff89dc36d99109f Reviewed-on: https://code.wireshark.org/review/19450 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-29zvt: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I0f7a620e5fbdab4a4c6b62b1b7bc884073bc0f45 Reviewed-on: https://code.wireshark.org/review/19447 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: mark some functions as inlineMartin Kaiser1-10/+10
Change-Id: I2637fc18b1eeda5e567ee62c8ed53c6757c259bd Reviewed-on: https://code.wireshark.org/review/19457 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: dissect card type and result code bitmapsMartin Kaiser1-2/+39
Change-Id: I26a7821642224c707dc4542a35b2b5b5aee159d5 Reviewed-on: https://code.wireshark.org/review/19456 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: dissect the text lines TLV data objectMartin Kaiser1-1/+20
Change-Id: I3d54b4568b883b95294e29347bde0736b78157e1 Reviewed-on: https://code.wireshark.org/review/19455 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: dissect the status apdu, add some more bitmapsMartin Kaiser1-2/+29
Change-Id: If74221dd55d61c5794f570daf38c88771f4a2f38 Reviewed-on: https://code.wireshark.org/review/19454 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: add some more tag namesMartin Kaiser1-1/+21
Change-Id: If181a22f2794fb9fe812719593f8a7eb642bce42 Reviewed-on: https://code.wireshark.org/review/19453 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29zvt: print the tag name in the tree headerMartin Kaiser1-1/+3
Change-Id: Iac0744f830020a54790a39820abab9fb756ffa9f Reviewed-on: https://code.wireshark.org/review/19452 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-29ISAKMP: add Reserved fields for Fibre ChannelMirko Parthey1-3/+11
Add Reserved fields for Fibre Channel Traffic Selectors. Reference: RFC 4595, section 4.4 Change-Id: Iba0b3d9a4d3d96918971a9a597fa313b022b5ca2 Reviewed-on: https://code.wireshark.org/review/19444 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28CMake,autotools: enable -Werror=implicit by defaultPeter Wu3-4/+19
The -Wimplicit error covers two warnings, trying to catch these cases: Setting a global variable without declaring its type (-Wimplicit-int): undeclared_type = 1; More importantly, -Wimplicit-function-declaration catches the case where a function is not declared (missing header, programming error, etc.). Turn these warnings into errors, most likely it will be a programming error that results in a link failure anyway. See also https://fedoraproject.org/wiki/Changes/Fedora26CFlags Also fix autotools checks not to trigger -Wimplicit-int and -Wimplicit-function-declaration (in krb5 check due to missing include). Tested on Ubuntu 16.04 (autotools & cmake) and Arch Linux (cmake), configure/cmake output and config.h are identical. Change-Id: I137284263f3b1223df6e6a893111c3640802631f Reviewed-on: https://code.wireshark.org/review/19331 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-12-28Qt: Remove "Extcap" from window title.Stig Bjørlykke1-2/+2
An average user does not need to know that an interface is of type extcap. Remove "Extcap" from the "Extcap Interface Options" dialog. Change-Id: Iafadf2d312a4ffd5530deeac63194151571fc7d3 Reviewed-on: https://code.wireshark.org/review/19443 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-28Qt: Fix open extcap help URL.Stig Bjørlykke1-1/+3
The return value from QString::compare() is equal to zero when the strings are equal. Fix the code for checking and opening the extcap help URL if not matching "file". This bug was introduced in g46caff30. Ping-Bug: 13218 Change-Id: I2a84e61f0191b57269f8ce829ff82200bf19a7ac Reviewed-on: https://code.wireshark.org/review/19442 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-28Infiniband: Use base of packet tree (top_tree) for ↵Michael Mann1-23/+24
"infiniband.mad.cm.private" heuristic dissector. The "infiniband.payload" heuristic dissector was converted to use the base of the packet tree so that subdissectors could show their protocol as the base layer. Since many of the subdissectors use the same dissection function for both "infiniband.payload" and "infiniband.mad.cm.private", ensure that both use the same "tree level", but still pass in the "payload tree" as part of the dissector data in case a subdissector wants to use it (currently used by InfinibandSDP) Ping-Bug: 13259 Change-Id: I899e8348f6b23d8eee9e74764d8ca32d7bf6e625 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19441 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Parav Pandit <paravpandit@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28ISAKMP: add traffic selector subtreeMirko Parthey1-105/+100
Create a new subtree for each traffic selector. Use the length field to find the next traffic selector rather than accumulating the individual TS field sizes. Split dissect_ts() to introduce separate offset variables. After adding the final field, do not advance offset again to avoid unused variable warnings. Change-Id: I9951662c1bb3958994162b25b70b43ec1da103a7 Reviewed-on: https://code.wireshark.org/review/19440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28macosx: Update Read me first.rtf with some additional install/deinstall notesJim Young1-6/+20
Report that files /etc/paths.d/Wireshark and /etc/manpaths.d/Wireshark are added and should be removed. Change-Id: I2f9d3aea0dd4f86cb9a86065108a3948e28d3001 Reviewed-on: https://code.wireshark.org/review/19436 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-28Added basic support for NVM Express over Fabrics for RDMA.Parav Pandit6-0/+1717
NVM Express is high speed interface for accessing solid state drives. NVM Express specifications are maintained by NVM Express industry association at http://www.nvmexpress.org. Bug: 13201 Change-Id: Id40edaf72838eea9f4087c8ddba9518a9374efab Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19063 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Parav Pandit <paravpandit@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-27Move DigestInfo from pkcs12 to cmsРоман Донченко6-50/+42
This type is originally from PKCS #7, the predecessor of CMS, so it makes more sense for it to be there. Change-Id: I3a146f1d000a3bcbcd0d8f1cfe2fc27ed80cc69d Reviewed-on: https://code.wireshark.org/review/19335 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-27InterfaceList: Add check for remote interfaceRoland Knall8-0/+120
Add a check, to allow the filtering of remote only interfaces. Also add the necessary options to the type menu. Change-Id: Ib82519362454094f64abf1cbe6d7bc917990d7ac Reviewed-on: https://code.wireshark.org/review/19438 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-27Replace assignment with structure assignment (CID 1397183)Jaap Keuter1-2/+1
Replace the individual field assignment with struct assignement to - Reduce code (only single line, but he), - (Hopefully) show Coverity this is as intended. Change-Id: I9400b6e38f86acf57018ee7993e66d5b06d1c39c Reviewed-on: https://code.wireshark.org/review/19434 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-27Merge AIM files into single dissector file.Michael Mann26-4806/+3100
These are probably obsolete dissectors anyway, but they are a bunch of very small files causing unnecessary file pollution. Change-Id: I03976484996b4bf987d6743ed379534456809c2c Reviewed-on: https://code.wireshark.org/review/19437 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-26zvt: dissect the TLV container's payloadMartin Kaiser1-26/+121
add a function to dissect the sequence of TLV elements use a hash table for payload functions like we do for the bitmaps add two tags whose payload is another TLV sequence Change-Id: Ibb19fd7af2f58e201174d07d410557dc315c652a Reviewed-on: https://code.wireshark.org/review/19435 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-26Don't claim packet as MATE if there is no MATE configurationMichael Mann1-1/+6
This prevents MATE from (falsely) being included in the list of protocols for any given frame. Change-Id: I9ffdfb52cf31dfda89b674a41bcc0992e17de5e8 Reviewed-on: https://code.wireshark.org/review/19432 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25[Automatic update for 2016-12-25]Gerald Combs12-1388/+1896
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I8fd8115fdfd4623bdf94602b6fd55a724e09cec3 Reviewed-on: https://code.wireshark.org/review/19429 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-25Remove individual post-dissect enable preferences.Michael Mann3-48/+23
Use Analyze -> Enabled Protocol dialog interface. Added support for backwards compatibility of preference. Change-Id: I32b3fce9d18083d9324197e3fd7ddc7eb888d1fb Reviewed-on: https://code.wireshark.org/review/19422 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25DVB-CI: simplify dissection of the resource idMartin Kaiser1-22/+11
Now that proto_tree_add_bitmask_value_with_flags() works for tvb==NULL, we can use it to simplify the dissection of DVB-CI's resource id. Change-Id: Ia09d5668bf0a61161ecd0cb412680838a67d7a7a Reviewed-on: https://code.wireshark.org/review/19409 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Wireshark doesn't require X11 any more.Guy Harris1-1/+1
Change-Id: Ib5ba38e5103f31f115608b92dd32f3ce1e5eec67 Reviewed-on: https://code.wireshark.org/review/19424 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-25Fix some narrowing warnings.Guy Harris1-3/+3
Don't narrow values until it's necessary, and then put in explicit casts to indicate that the narrowing is intentional. Change-Id: I8afc2a457822febbed33cee573953993013a7185 Reviewed-on: https://code.wireshark.org/review/19423 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-25packetbb: Add decoding for TLV with single valueFrancois Schneider1-49/+327
Bug: 4118 Change-Id: I282fb8da657701c5b855dafe1568a5f226d3c12b Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/13985 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25rtp_analysis_dialog (Qt): Fix Dead Store (Dead assignement/Dead increment) ↵Alexis La Goutte1-1/+0
Warning found by Clang Change-Id: I48dd8af83c97301b6bd314801ca36ac13c790eaa Reviewed-on: https://code.wireshark.org/review/19413 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Cleanup transum post-dissector.Michael Mann6-665/+546
1. Enable/disable preference not needed - just use Enabled Protocol dialog interface. Added support for backwards compatibility of preference. 2. Add value_string for calculation values 3. Create an structured array of "hfs of interest" so they can more easily be extended. 4. Convert a bunch of arrays into hash tables and lists. For the amount of wasted space they were taking up, we can live with the very slight performance degrade. Also puts less limits on number of things to process. Change-Id: I7399789d62432b507062ed9cdc20ad974b9dde1b Reviewed-on: https://code.wireshark.org/review/19406 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Support all MA modes, fix BB CRC and frag edge casesMustBeArt1-85/+175
Support all four mode adaptation interface formats. Add a user preference to specify which format is in use, or to request that the format be guessed. Guessing is improved, but can never be reliable. Fix problem with baseband header CRC check that caused almost all packets to show a spurious CRC error, introduced with proto_tree_add_checksum. Fix problem with GSE PDU fragmentation CRC beginning in one fragment and ending in another. Any GSE frames following the fragment containing the end of the CRC would be parsed at the wrong offset. Fix problem with IPv4 or IPv6 starting exactly on a fragmentation boundary, so that one baseband frame contains the complete GSE header but zero bytes of the IP payload. Trying to further dissect the zero-length payload led to a "malformed packet" display. Standardize spelling per governing document: adaption -> adaptation Change-Id: I69e64e74e4b4f02515411471e1d76b0eeb02fef1 Reviewed-on: https://code.wireshark.org/review/19421 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25Avoid recursive scan_local_interfaces operationMikael Kanstrup1-0/+11
When the local networks interfaces changes quickly or when refreshing the list of network interfaces there's a risk of recursive calls into scan_local_interfaces. The recursive calls are a result of calling update_cb to process UI events during function operation which in turn again discover a network interface change. This results in strange duplicate entries of network interfaces and crashes. To avoid recursive calls a check is added to stop running the function while already updating. This patch is really just a workaround for the problem. Ideally some asynchronous operation should be implemented instead to avoid the UI update_cb callback alltogether. Bug: 11553 Bug: 12263 Change-Id: I3b74d8f196677e0e261a395aff558dd9f685b538 Reviewed-on: https://code.wireshark.org/review/14492 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-25udpdump: remove libwireshark dependancy.Dario Lombardo3-35/+97
Export pdu routines have been rewritten here on purpose. Change-Id: If4879de4c98b6f20a75df158cae0cf9a80ffae57 Reviewed-on: https://code.wireshark.org/review/19384 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): split Sector Sweep Feedback in 2Alexis La Goutte1-3/+51
one from ISS and other to ISS Add also reserved field Issue reported by Hany ASSASA Bug:13244 Change-Id: Ib20cf6ae455664b87ea3470ebb6d5386a97b0f48 Reviewed-on: https://code.wireshark.org/review/19420 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-25802.11(ad): fix typoAlexis La Goutte1-1/+1
Acknoledgment => Acknowledgment Ping-Bug: 13244 Change-Id: Ia2e8eedec05c39ed0ebc38235cc52d43488e00d4 Reviewed-on: https://code.wireshark.org/review/19419 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-10 06:48:05 +0000