aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2011-10-20Use a global list containing all interfaces and only changeMichael Tüxen15-1484/+1190
properties of the entries when changes are made in the GUI. Do not misuse the list of interfaces specified on the command line anymore. This patch does not provide any new functionality, it just provides the base for future extensions like removing remote interface, mulitple airpcap devices and multiple pipes. This patch was provided by Irene Ruengeler. svn path=/trunk/; revision=39495
2011-10-20Fix for bug 6469:Jaap Keuter1-5/+5
Retrieve the fill bits in the correct amount and from the correct place. svn path=/trunk/; revision=39494
2011-10-20Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-12/+12
svn path=/trunk/; revision=39493
2011-10-20Add conversion for FT_ETHER hf[] field type;Bill Meier1-15/+56
Add capability to convert encoding arg for 'proto' hf_index_names [the variable which stores the return value from proto_register_protocol()]. svn path=/trunk/; revision=39492
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier2-2/+2
svn path=/trunk/; revision=39491
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier13-25/+25
svn path=/trunk/; revision=39490
2011-10-20Fix a typo.Bill Meier1-2/+2
svn path=/trunk/; revision=39489
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier45-456/+456
(Some minor whitespace cleanup). svn path=/trunk/; revision=39488
2011-10-20Update minimum version requirement for GTK to 2.12.Jaap Keuter1-1/+1
svn path=/trunk/; revision=39487
2011-10-20As bug 3954 notes, nowhere does RFC 3954 indicate that a system orGuy Harris1-11/+3
interface scope is always 4 bytes. For that matter, nowhere does it indicate that the scopes have any particular interpretation except as a sequence of octets. Get rid of the checks for a length of 4, and make ScopeSystem an FT_BYTES. If, by *convention*, they're usually IPv4 or IPv6 addresses, somebody can throw in code to display them as such if they happen to be 4 or 16 bytes, respectively. Leave ScopeInterface as an integer for now, in case, by convention, they're interface indices, but still leave the length check out. Fixes bug 3954. svn path=/trunk/; revision=39485
2011-10-20Delay freeing of seasonal memory until after the conversation cleanup routineJeff Morriss2-8/+37
has been called. In the conversation cleanup routine, free the GSlist for any proto_data which may have been hanging off the (se_allocated) conversation. svn path=/trunk/; revision=39484
2011-10-20From András Veres-Szentkirályi via ↵Jeff Morriss1-20/+424
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6426 : The current MySQL dissector ignored the execute parameters as metadata is needed from previous packets to decode the fields. I added the necessary code to store these in conn_data and developed dissector for all fields I could reproduce on the network. This also fixes a memory leak by moving the stmts structure (the pointer to which is stored in se_allocated memory) into se_trees. From me: use se_tree_create_non_persistent() so the entire tree is forgotten when the se_ memory goes away. Also some reformatting. svn path=/trunk/; revision=39483
2011-10-19Specify ENC_TIME_TIMESPEC for a proto_tree_add_item() encoding arg for a ↵Bill Meier1-1/+1
field with type FT_ABSOLUTE_TIME. svn path=/trunk/; revision=39482
2011-10-19Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte2-8/+16
svn path=/trunk/; revision=39481
2011-10-19From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6463Alexis La Goutte4-0/+314
dissector for HDCP (High bandwidth Digital Content Protection) HDCP can run on top of TCP, there's no fixed port number assigned. I created a heuristic dissector that's disabled by default and can be enabled by setting a preference (similar to the hilscher dissector). The idea behind this is that some HDCP messages are hard to recognize (e.g. one byte message id + 8 random bytes). Having the dissector enabled at all times may generate false positives. svn path=/trunk/; revision=39480
2011-10-19Copy/Paste is a devil...Alexis La Goutte1-1/+1
svn path=/trunk/; revision=39479
2011-10-19From pascl via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6465Alexis La Goutte1-0/+4
New Protocol Submission for MVRP (Multiple VLAN Registration Protocol) Missed modification of etypes.h file svn path=/trunk/; revision=39478
2011-10-19From pascl via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6465Alexis La Goutte3-0/+446
New Protocol Submission for MVRP (Multiple VLAN Registration Protocol) New dissector submission for Multiple VLAN Registration Protocol (MVRP) defined in 802.1ak Standard, section 11. MVRP is used to to dynamically create and update Dynamic VLAN Registration Entries. From me : * Fix error from fix-encodings-args script * Add Modeline information * Added packet-mrp-mvrp.c to CMakeLists.txt svn path=/trunk/; revision=39477
2011-10-19Use ENC_... instead of locally defined NSIP_LITTLE_ENDIAN for ↵Bill Meier1-6/+5
proto_tree_add_item() encoding arg. svn path=/trunk/; revision=39476
2011-10-19Fix several benign instances wherein proto_tree_add_[uint|boolean]() was ↵Bill Meier2-5/+5
intended rather than proto_tree_add_item(). svn path=/trunk/; revision=39475
2011-10-19Manually fix a proto_tree_add_item() encoding arg.Bill Meier1-1/+1
svn path=/trunk/; revision=39474
2011-10-19use consistent indentation.Bill Meier1-2308/+2313
svn path=/trunk/; revision=39473
2011-10-19Let subdissectors have a stab at the packet even if it's cut short.Anders Broman3-135/+155
svn path=/trunk/; revision=39472
2011-10-19Perl program to fix proto_tree_add_item() encoding args as appropriate (and ↵Bill Meier1-0/+464
as possible). svn path=/trunk/; revision=39471
2011-10-19Fix Coverity ID #1288: UNUSED_VALUE in spotlight_dissect_query_loop:Stephen Fisher1-1/+1
"returned_pointer: Pointer ... is never used" due to break and end of function after the switch block. svn path=/trunk/; revision=39470
2011-10-19Fix Coverity ID 1300: UNUSED_VALUE in dissect_spotlight: "returned_pointerStephen Fisher1-6/+6
is never used" because of the return -1 at the end of this if block. Removed item_toc = assignment and fixed indentation. svn path=/trunk/; revision=39469
2011-10-19Duplicate Lua strings we put into the private_table.Stig Bjørlykke1-2/+7
svn path=/trunk/; revision=39468
2011-10-19More conversions of proto_tree_add_item() 'encoding' argBill Meier6-179/+179
svn path=/trunk/; revision=39467
2011-10-19Fix a bug when drawing TSN plots which results in a crash.Michael Tüxen1-1/+2
Obtained from Irene Ruengeler. svn path=/trunk/; revision=39466
2011-10-19From pascl via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6464Alexis La Goutte1-0/+3
MRP-MSRP: Missing error descriptions (error code 17, 18 and 19) Multiple Stream Reservation Protocol (MSRP) defines 19 failures codes in 802.1Qat (table 35-6). Actual packet-mrp-msrp.c only defines the first 16 failures codes. svn path=/trunk/; revision=39465
2011-10-19From Pascal Quantin via ↵Jeff Morriss1-71/+111
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6468 : The attached patch fixes a memory corruption of the ep_allocated buffer when building the decoded bitmap. From me: some reformatting. svn path=/trunk/; revision=39464
2011-10-18Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+3
packet-btamp.c:xxx:y: warning: Value stored to 'offset' is never read (x14) svn path=/trunk/; revision=39463
2011-10-18There's only one expert info dialog now; dispense with the "composite" partJeff Morriss2-8/+8
of the name (at least what we show users; the files and functions still reference composite). svn path=/trunk/; revision=39462
2011-10-18Added a private hash table to transport string values between dissectors.Stig Bjørlykke4-0/+162
This works between C and Lua. In C the pinfo.private_table pointer must be initialized using g_hash_table_new (g_str_hash, g_str_equal); In Lua the values are available using pinfo.private.<key>, and the table is created automatically on first usage. It's possible to use this datatypes: nil, boolean, number and string, but every value is converted to string so numbers must be converted using tonumber() on usage. Boolean is either nil or an empty string. svn path=/trunk/; revision=39461
2011-10-18Add an expert info if we found the checksum to be bad.Jeff Morriss1-52/+60
Add the checksum info to the tree even when !tree so that the expert_info summary... "icon"... in the lower-left corner is correct. svn path=/trunk/; revision=39460
2011-10-18Added support for User-Agent.Stig Bjørlykke1-1/+6
Fixed finding line end for content type parameters. svn path=/trunk/; revision=39459
2011-10-18Use PINFO_GET_BOOLEAN for visited.Stig Bjørlykke1-12/+1
svn path=/trunk/; revision=39458
2011-10-18Note some character encodings that can probably be used Real Soon Now,Guy Harris1-0/+19
and the dissectors that deal with them. svn path=/trunk/; revision=39456
2011-10-18From Dirk Jagdmann via ↵Jeff Morriss1-52/+31
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6450 : Several updates to the DCE/RPC dissector: - changed the variable name "ndr64_uuid" to "uuid_ndr64" to make it similar the the other UUID variable names. Minor changes to the UUID names. - changes the UUID name for the 32bit NDR to describe that. In the DCE/RPC standard this UUID is described as "Version 1.1 network data representation protocol", but this is an unnecessarily long name and it's the only 32bit version defined for DCE/RPC anyway. The new name "32bit NDR" is similar to the changed name for the 64bit NDR. - added an UUID for "bind time feature negotiation" found with Microsoft PDUs. - added an UUID for "asynchonous MAPI". Of course this UUID/name should be added to the MAPI dissector, but the MAPI dissector is generated C code from Samba/OpenChange pidl sources. Eventually those might get updated. An alternative would be to create a new file to specifically register UUIDs used in the DCE/RPC context. - when the g_hash_table_insert() function is used, I've removed the code to lookup and remove the key, as g_hash_table_insert() is doing that internally (or more precise, it is overwriting the old value). - in the dissector function for Bind and BindAck, I now print all context items into COL_INFO and not just the first one. - added a new value for Bind results, used by Microsoft products. (The "Negotiate ACK" is used with the "bind time feature negotiation" UUID) svn path=/trunk/; revision=39455
2011-10-18From Roberto Morro via ↵Jeff Morriss1-6/+13
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6451 : The patch fixes a bug in the PCEP Objective Function (OF) object tree visualization (it didn't recognize the object and showed it as "Unknown object"). Also fixes a small bug. From me: remove a couple of unnecessary includes. svn path=/trunk/; revision=39454
2011-10-18From Daniel via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6461 :Jeff Morriss1-0/+1
Register the USB dissector by name. svn path=/trunk/; revision=39453
2011-10-18Display filter name cleanup.Chris Maynard3-16/+16
svn path=/trunk/; revision=39452
2011-10-18Do some more conversions of proto_tree_add_item() 'encoding' argBill Meier4-20/+20
(previously missed). svn path=/trunk/; revision=39451
2011-10-18Do some more conversions of proto_tree_add_item() 'encoding' argBill Meier24-397/+397
(previously missed). svn path=/trunk/; revision=39450
2011-10-17Fixup some display filter names.Chris Maynard1-3/+3
svn path=/trunk/; revision=39449
2011-10-17Cleanup AFP Version display filter name.Chris Maynard1-5/+5
svn path=/trunk/; revision=39448
2011-10-17Remove #if 0'd code which appears to duplicate existing codeBill Meier1-5/+0
svn path=/trunk/; revision=39447
2011-10-17Enhance BGP Capability messageAlexis La Goutte1-241/+235
* Make field filterable * Use expert info to display a wrong length * Remove duplicate code for type and length svn path=/trunk/; revision=39446
2011-10-17From Michael Mann: Add cf_callback_invoke to cf_open to tidy up the ↵Chris Maynard1-0/+1
currently open file before opening a new one. Fixes bugs 5987 and 6457. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5987 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6457 svn path=/trunk/; revision=39445
2011-10-17Add dissectors/packet-lcsap.c to CMake. Remove ↵Jeff Morriss2-1/+1
dissect_lcsap_Correlation_ID_PDU() from list of exports since it's only used within libwireshark. svn path=/trunk/; revision=39444