aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-04-25Qt: Add interface toolbar supportStig Bjørlykke30-28/+2648
An extcap utility can provide configuration for controls to use in a GUI interface toolbar. This controls are bidirectional and can be used to control the extcap utility while capturing. This is useful in scenarios where configuration can be done based on findings in the capture process, setting temporary values or give other inputs without restarting current capture. Todo: - Add support for Windows Change-Id: Ie15fa67f92eb27d8b73df6bb36f66b9a7d81932d Reviewed-on: https://code.wireshark.org/review/19982 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-04-25UMTS FP: Improved MAC multiplexing detectionS. Shapira1-99/+74
Previous detection was based on DCH ID 31 or 24 and specific TB Size. New method checks if the 'Transport Format' looks like the commonly used format for DCCH over DCH or DCH ID 24 and specific TB size (To not break that special case which I'm not familiar with personally) Change-Id: I59fe7772ec05f7cc15351ef78276085e25570461 Reviewed-on: https://code.wireshark.org/review/21304 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-25ua3g: fixed/updated "unsolicited" and "version information" messagesNicolas BERTIN1-29/+81
Change-Id: If006c36a21556a8fb690401677e9ca62a594d82b Reviewed-on: https://code.wireshark.org/review/21307 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-25GSM SMS: add more lower layer info for reassembly and switch preference to ↵Pascal Quantin1-9/+18
on by default Change-Id: I3faf15c326d14e246975094ad31431eba2404d8c Ping-Bug: 13592 Reviewed-on: https://code.wireshark.org/review/21320 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-25GSM SMS: fix display of reassembled 8 bits SMSPascal Quantin1-1/+1
Change-Id: I0052fb1f311f18180fbc7c6b8bd2fbf23215ad67 Reviewed-on: https://code.wireshark.org/review/21319 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-24fuzzshark: try to fix oss-build, remove oss-fuzzshark.c in old location.Jakub Zawadzki2-330/+2
Step #3: /src/wireshark/tools/oss-fuzzshark.c:190:2: warning: implicit declaration of function 'wtap_init' is invalid in C99 [-Wimplicit-function-declaration] (https://oss-fuzz-build-logs.storage.googleapis.com/log-472514ce-1a41-4f14-8798-d45084212a65.txt) Change-Id: I47715bdf55c20124a80da51d3c8812db1d8d94cf Reviewed-on: https://code.wireshark.org/review/21317 Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl> Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2017-04-24Convert BOOTP options into a dissector table.Michael Mann1-1104/+1416
This allows for much easier addition or overriding of options and use of Decode As. This includes adding heuristic dissector tables for vendor specific options. Change-Id: If52c00bbc23d89386ba3e777600f665609856de0 Reviewed-on: https://code.wireshark.org/review/21297 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-24GSM SMS: optionally use GSM-MAP info to perform reassembly (off by default)Pascal Quantin6-150/+396
Change-Id: I62c7a04e62167bd2d68d861f1d8d854f3159b159 Ping-Bug: 13592 Reviewed-on: https://code.wireshark.org/review/21306 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-24oss-fuzzshark: Copy to separate directory, add build script.Jakub Zawadzki2-0/+408
(oss-fuzz part https://github.com/google/oss-fuzz/pull/544) Change-Id: I54cf7a7b1aaa49582b5fff8bd034187aa6a9bdec Reviewed-on: https://code.wireshark.org/review/21302 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2017-04-24[docsis->bpkm-attr] Updated Attribute 16 Error CodesAdrian Simionov1-3/+5
Change-Id: If9156b4a73e7db006daf4ab4e278379f0e39905f Reviewed-on: https://code.wireshark.org/review/21313 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-24[MIP6] Fix length calculation, APN name and PCO.AndersBroman1-7/+51
Change-Id: I2a26ef0bbde07071f72c19d9465adf02cb177816 Reviewed-on: https://code.wireshark.org/review/21311 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-24Revert "Make the set of static routines match that in the current tip SQLite."Alexis La Goutte1-15/+17
This reverts commit 96c72df2dfe9c84bc2716352ebe1876ddd8ceaf4. Generated a lot of warning (-Wmissing-prototypes) and i try to kept a sync branch on https://github.com/alagoutte/sqlite/tree/wireshark Change-Id: I42252a6e736f96783a9fa9805b84e525fe11726e Reviewed-on: https://code.wireshark.org/review/21182 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-04-24TFSHARK: Fix clobbing warning for variable successUli Heilmeier1-1/+1
Without setting the success variable as volatile my build fails with warning "error: variable success might be clobbered by 'longjmp' or 'vfork'" Change-Id: Ic7d4a9b8be4bf9211127dcf5a6bb4bef8bbcd7a9 Reviewed-on: https://code.wireshark.org/review/21310 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-24Move UI-only stuff out of libwireshark.Guy Harris16-99/+86
Packet ranges are used only in the UI; move the packet range stuff into libui. Don't pass a print_args_t structure to libwireshark packet-printing routines, just pass the few parameters they need. Move the declaration of print_args_t into file.h. Change-Id: Icff5991eea7d7d56f33b4716105895263d275bcf Reviewed-on: https://code.wireshark.org/review/21308 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23Print first-pass read errors at the end.Guy Harris1-28/+53
That way, they don't, for example, get lost as a result of being scrolled off the screen by output from the second pass. Also, do the post-processing of output regardless of whether we got read errors or not, and fix a code error hidden by a call to tshark_debug(). Change-Id: I389c7c794f4dd5fda6e4c50ce480802c92701866 Reviewed-on: https://code.wireshark.org/review/21305 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23tshark: make success volatile.Jakub Zawadzki1-1/+1
/home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/tshark.c: In function ‘main’: /home/wireshark/builders/ubuntu-x86-64-petri-dish/ubuntu-x86-64-petri-dish/build/tshark.c:653:12: error: variable ‘success’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Change-Id: I793962c71b0ebfafc7c09b1d865cfa774456bb3a Reviewed-on: https://code.wireshark.org/review/21303 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23UMTS FP: Fix bug in heuristic dissectorssswsdev1-1/+1
The code was not allowing UDP port types, should ONLY allowed UDP ports. Change-Id: Ida5467313cbc24fcbac7cd432fb4a018cc00bdef Reviewed-on: https://code.wireshark.org/review/21301 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-23[Automatic update for 2017-04-23]Gerald Combs12-273/+499
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: If8e6efa61c4c2808c51c585b0c61fd76a321c3fd Reviewed-on: https://code.wireshark.org/review/21298 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-04-23Rename read{_cap}_file() to process{_cap+_file().Guy Harris2-8/+8
They might read the file once or twice, but the key is that they (and what they call) are doing the work of processing the file's contents. Change-Id: I2df6257c55ff5ace944f1a1db5e2aec456ed2038 Reviewed-on: https://code.wireshark.org/review/21293 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23Just have read_cap_file()/read_file() return a success/failure indication.Guy Harris2-17/+19
No need to report the precise error code - it's already reported the error. Change-Id: Ib52daf094253deac2a10d16793ebf0f42581afd6 Reviewed-on: https://code.wireshark.org/review/21292 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23HTTP: Add status code descriptionUli Heilmeier1-4/+22
This commit adds the IANA status code description to the tree. Furthermore it updates the registered status codes s. https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml Change-Id: I6ec57569b784a137b57532a092c8781dec545039 Reviewed-on: https://code.wireshark.org/review/21162 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-23slsk: fix infinite loopPeter Wu1-82/+82
If check_slsk_format reports that the buffer does not contain the expected data, do not try to find more items (break out of the loop). In one case, an infinite loop would occur because the index variable was not incremented when the check fails. In all other cases, it would perform up to 2^32 calls to check_slsk_format per loop (with the same offset parameter, so no exception is triggered). Change-Id: I4b7fa10a36fee2551fa46831bcecd6bcd9f342d1 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1200 Bug: 13631 Reviewed-on: https://code.wireshark.org/review/21284 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-23Rename some routines to better reflect what they do.Guy Harris2-8/+8
In TShark, rename load_cap_file() to read_cap_file(); this is TShark, not Wireshark, so you're not "loading" a file to be manipulated through the GUI. In TFShark, rename it to "read_file()"; not only are we not loading it, it's not even necessarily a capture file. Change-Id: I122b46ecd8cb7de9c1e1c249ba6c08fdeb93f7e2 Reviewed-on: https://code.wireshark.org/review/21291 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-23Snort: restore timestamp before showing alertMartin Mathieson1-4/+12
Change-Id: I4772c9c46b7a79a7139229bcb43ee6c84109a26b Reviewed-on: https://code.wireshark.org/review/21289 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-23DOF: Fix buffer overflow (read)Björn Ruytenberg1-8/+15
Perform sanity check on buffer length parsed from data. Check buffer size before reading value. Change-Id: I8beaf8860b39426d79867b0dd2221e57e32da8e0 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1151 Bug: 13608 Reviewed-on: https://code.wireshark.org/review/21287 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-22aruba (PAPI): fix conflicting entry in its value_stringAlexis La Goutte1-2/+2
Field 'Destination Port' (papi.hdr.dest.port) has a conflicting entry in its value_string: 8999 is at indices 143 (LAST_SERVICE) and 144 (MESSAGE_HANDLER)) Field 'Source Port' (papi.hdr.src.port) has a conflicting entry in its value_string: 8999 is at indices 143 (LAST_SERVICE) and 144 (MESSAGE_HANDLER)) Check from Services.pm and same value for both... Change-Id: I8ff56bfbee525e894235a9aea62e0f1d2a9b0ebc Reviewed-on: https://code.wireshark.org/review/21191 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-22UMTS Iub: Fixed some comments and replaced tabs with spacessswsdev3-20/+20
Changes done to the FP, MAC and RLC dissectors Change-Id: I7ccf229a7a1d9a8c04d8ac04e74f03253eb3bff0 Reviewed-on: https://code.wireshark.org/review/21281 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-22Update a comment.Guy Harris1-3/+4
Change-Id: Ice2727d691719a10c7163b9496107ec95fbd2e3b Reviewed-on: https://code.wireshark.org/review/21288 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-22packet-quakeworld.c: Fix potential out of bounds error.Michael Mann1-32/+31
Overflow can occur while writing to a buffer. Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1179 Bug: 13624 Change-Id: I7511c43ed67f81d246e3eb66e092353e2ab4924c Reviewed-on: https://code.wireshark.org/review/21235 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-22ua3g: fixed/updated init message (vta type values)Nicolas BERTIN1-5/+11
Change-Id: I8c500d6e049e9243c2c4b283731674bf3fc0a521 Reviewed-on: https://code.wireshark.org/review/21282 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-22ROS: Harden ROS dissectionJaap Keuter2-2/+2
Make sure that on a OID search an actual OID is available to search for. Bug: 13637 Change-Id: I36f84cce5506f003d2a30a17f8671d5e22070612 Reviewed-on: https://code.wireshark.org/review/21280 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21Put all the capture dissector structures into epan/capture_dissectors.h.Guy Harris3-12/+12
Don't scatter them amongst various other headers. Change-Id: I243954222cd4ad3e6bbe8b4d1dd25ee4952f87d6 Reviewed-on: https://code.wireshark.org/review/21277 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-21capwap: fix conflicting entry in its value_stringAlexis La Goutte1-9/+7
Field 'Cisco Element ID' (capwap.control.cisco.element_id) has a conflicting entry in its value_string: 125 is at indices 31 (SPAM AP Led State) and 34 (AP Led State Config)) Rename also some variable name... Change-Id: I4e3c1fa925492a570dad47a3d274d1f3e950c483 Reviewed-on: https://code.wireshark.org/review/21271 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-04-21UCP: Update Xser typesUli Heilmeier1-0/+7
Updated Xser types according to http://documents.swisscom.com/product/1000174-Internet/Documents/Landingpage-Mobile-Mehrwertdienste/UCP_R4.7.pdf Bug: 13636 Change-Id: I4591c37534da0ccf1ee4352eaff00156eefff519 Reviewed-on: https://code.wireshark.org/review/21270 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21LTE RRC: insert an optional separator before adding message name to info columnPascal Quantin2-198/+198
Bug: 13634 Change-Id: I9585d915b9bc9c895eabeed3d3d5453e94c31789 Reviewed-on: https://code.wireshark.org/review/21274 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-21cast: fix conflicting entry in its value_stringAlexis La Goutte1-2/+1
Field 'AudioCodec' (cast.audio) has a conflicting entry in its value_string: 1 is at indices 0 (G711) and 1 (G729)) Change-Id: I094a85a84ca1e79d4cf817bd5222e902a34f3741 Reviewed-on: https://code.wireshark.org/review/21272 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21Code in epan/dissectors may require GeoIP.h, so include LIBGEOIP_FLAGS.Guy Harris1-1/+1
Change-Id: I31bd53c49906db24b64fa3f1e3078b0658db3158 Reviewed-on: https://code.wireshark.org/review/21269 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21Use the cfile_ failure_message routines in androiddump.Guy Harris3-12/+41
Change-Id: Ic310eaafac054db7736c503252062c3dd3e00a99 Reviewed-on: https://code.wireshark.org/review/21265 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-21Code in epan/crypt may require gcrypt, so include LIBGCRYPT_FLAGS.Guy Harris1-1/+1
Change-Id: I7f6745eb39bae6ae37a63178bcd60c75fd9e9de2 Reviewed-on: https://code.wireshark.org/review/21268 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-21Update URL.Guy Harris1-1/+1
Change-Id: Ice4235b6b2cda947ee5059380ad5a49556bb3e6a Reviewed-on: https://code.wireshark.org/review/21267 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-21nstrace (mep/rpc): fix conflicting entry in its value_stringAlexis La Goutte2-2/+2
Field 'Status Code' (nstrace.mep.errcode) has a conflicting entry in its value_string: 341 is at indices 7 (LARGE DATA) and 8 (SMALL DATA)) Field 'Status Code' (nstrace.rpc.errcode) has a conflicting entry in its value_string: 341 is at indices 7 (LARGE DATA) and 8 (SMALL DATA)) Change-Id: I75aba4140cbbcd412087e951bd35543f14ec1281 Reviewed-on: https://code.wireshark.org/review/21193 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21EAPOL-MKA: Add parameter set info to info columnJaap Keuter1-15/+22
Show which parameter sets are present in the info column, and some more relevant info. Prepare all parameter set handler function interfaces to be able to add relevant info. Change-Id: Idd206eebc4d7196511e118fbf9e30919fb38328e Reviewed-on: https://code.wireshark.org/review/21218 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-21Fixes for sfloat_ieee_11073_val_to_repr() functionPascal Quantin1-2/+4
- when having a special value, leave function once buffer is written - give the right buffer length to g_snprintf() function Bug: 13590 Change-Id: Iecf1456686b6e92a7cfcf8ed6d8619541ad50ace Reviewed-on: https://code.wireshark.org/review/21260 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-20dwarf.c: Fix potential too large shiftMichael Mann1-2/+2
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1167 Bug: 13616 Change-Id: I43ab629ad8368bf672d1c079219d6b055c431e86 Reviewed-on: https://code.wireshark.org/review/21249 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-20mergecap: remove a now useless variablePascal Quantin1-2/+0
Change-Id: I9acbbc03cbc2719abbe5b3ade62fc1c4e92cb8ff Reviewed-on: https://code.wireshark.org/review/21262 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-20Use more of the cfile_ failure message routines.Guy Harris1-3/+3
Change-Id: Iceb15f15622d391da0332e6ed55aac0e74abd0e2 Reviewed-on: https://code.wireshark.org/review/21261 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-20Use cfile_write_failure_message() in the randpkt code.Guy Harris5-68/+28
Change-Id: I32ef7ff85f854782e5dd02c3e7f12436a120bc13 Reviewed-on: https://code.wireshark.org/review/21259 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-20Take the error message generation out of the merge_files routines.Guy Harris8-267/+164
Have them just return the information needed for the caller to produce an error message, and have the callers use the new cfile_ routines for reporting errors. This requires that the "write failure alert box" routine take the *input* file name as an argument, so that, on a merge, if the problem is that a record from a given input file can't be written out to the type of output file we're generating, the input file name can be given, along with the record number in that file. Change-Id: If5a5e00539e7e652008a523dec92c0b359a48e71 Reviewed-on: https://code.wireshark.org/review/21257 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-20UMTS Iub: Added U-RNTI resolving logic for UEs on DCHsswsdev11-298/+625
The goal is to figure out the U-RNTI for UEs in DCH to preserve a single continous RLC session when the UE moves to FACH (Since the UE ID in FACH is derived from the identity found in the MAC layer, which is sometimes the U-RNTI) UMTS RRC dissector now defines a single 'umts rrc private data' structure as the way to access the actx->private_data field Change-Id: Id0ffcbcdf0a8babe533915855909e250852e46cf Reviewed-on: https://code.wireshark.org/review/21087 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-20sigcomp: Shift operand should be limited to 16 bitsMichael Mann1-3/+13
Change-Id: I5a6fbcacf874962c361e68fef7402dc775aca658 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1154 Bug: 13610 Reviewed-on: https://code.wireshark.org/review/21250 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>