aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-01-31Also check whether we have nothing but DLCI bytes.Guy Harris1-4/+8
The two failure modes are 1) no byte has the low-order bit set, so we didn't even find the end of the DLCI or 2) the byte at the end of the packet has the low-order bit set, so that it's all DLCI with no control byte after it. Expand a comment. Bug: 15463 Change-Id: Ib76686391213dd56c06d665aa87a188621fe6816 Reviewed-on: https://code.wireshark.org/review/31828 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-31btle: Add Version 5.1 to ll_version_number_valsStig Bjørlykke1-0/+1
Change-Id: I777dcaa6bd7f161ecbdc7411c3f816480c76834d Reviewed-on: https://code.wireshark.org/review/31827 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-31Check whether you've hit the end of the packet data before going further.Guy Harris1-2/+3
If we found no bytes with the low-order bit set in the packet data, there's no point in checking the non-existent "next" byte to see if it's a HDLC-style UI control byte (0x03). Bug: 15463 Change-Id: Ibfd186e5b81d8ce229362e23f00b31a27900831a Reviewed-on: https://code.wireshark.org/review/31824 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-31Use tvb_reported_length_remaining() to get the remaining data length.Guy Harris1-2/+2
Change-Id: If2930b772338a3a69fecb42102db2041df606e98 Reviewed-on: https://code.wireshark.org/review/31823 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-31Rpcap authentication replies now have an optional payload.Guy Harris1-2/+49
Change-Id: Id1ac1e12feb69573bed9bc419c819235da053867 Reviewed-on: https://code.wireshark.org/review/31820 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-30ngsniffer: fix comment.Dario Lombardo1-2/+2
Change-Id: Ia25ce4841ee3831f995d1fa7cd2cb8a850f1c01e Reviewed-on: https://code.wireshark.org/review/31818 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-30NAS-5GS: Dissect more V15.2.1 IEsAnders Broman1-105/+200
Change-Id: I9084ad99748a9d53bdae238f29b4a9750ca08a92 Reviewed-on: https://code.wireshark.org/review/31816 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-30GTP: fix PDU Session ContainerJoakim Karlsson1-10/+13
Change-Id: Iebe07b60cb03b2b149f8ce596333730558586fca Reviewed-on: https://code.wireshark.org/review/31815 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-30print: fix parameter 'data' not found in the function declarationAlexis La Goutte1-3/+3
fix warning found with clang and -Wdocumentation CFLAG Change-Id: I9fc122012161c5942c08cb90a9aeda1da6185180 Reviewed-on: https://code.wireshark.org/review/31808 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-30NAS-5GS: Dissect more V15.2 IE'sAnders Broman4-57/+386
Change-Id: I654b537b22776a599e4f2b2260c028d76ba5dfc2 Reviewed-on: https://code.wireshark.org/review/31805 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29Qt: Add support for RSA private key file selectionPeter Wu4-2/+46
Update release notes now that this GUI is mostly functional. Change-Id: I118fbbe879e366643084f0e7ac3e437a29f21d5f Reviewed-on: https://code.wireshark.org/review/31797 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: implement addition of a new pkcs11 token in the RSA Keys dialogPeter Wu3-0/+113
Load the list of key URIs, strip known keys, ask for a PIN, add valid results to the list. Apply this list on pressing OK in the preferences dialog or revert the changes on pressing Cancel. Change-Id: Id48cd9b876b4d272eb6dbdadf8a0859190cc0ce8 Reviewed-on: https://code.wireshark.org/review/31796 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: add initial RSA Keys preference framePeter Wu8-0/+312
The RSA Keys frame is intended to configure RSA keys (both key files and PKCS #11 tokens). Add a new "RSA Keys" item to the preferences menu. Implement addition and removal of PKCS #11 libraries and add an initial version that displays configured RSA keys. The "Add new token…" button will be implemented later. Change-Id: Ie5b9eb403afc7bebeb7be8bd53d4d4b30842204c Reviewed-on: https://code.wireshark.org/review/31795 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29secrets: add functions to query and validate pkcs11 tokens/key filesPeter Wu3-5/+174
Provide a way to retrieve key URIs ("pkcs11:" and in the future maybe "system:") and validate the PIN/password for such keys. Additionally permit validation of a RSA key file. This will be used for the RSA Keys GUI dialog. Change-Id: I4177a11cb9f4758d7564daae509e20a4a42623fa Reviewed-on: https://code.wireshark.org/review/31794 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: move method to apply/undo UAT changes to UatModelPeter Wu5-51/+90
UatModel could be constructed with a name instead of an epan_uat type. To allow those users to save/revert the uat, make sure to expose a method that does not require access to the underlying epan_uat type. Change-Id: I1d1a5811c1025bd9c2a2ea1722f460e6ac33b9aa Reviewed-on: https://code.wireshark.org/review/31793 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: Fix memory leak of QMenu.Stig Bjørlykke2-4/+6
Set the push button as parent to the save menu so it will be deleted when that parent is destroyed. Change-Id: Ic396dcf25092c90cd305a010be3d551d8ad8397c Reviewed-on: https://code.wireshark.org/review/31802 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-29dissectors: use '/' when stacking protocols in COL_PROTOCOL.Dario Lombardo3-3/+3
A commoly used convention when adding more then 1 protocols in COL_PROTOCOL (using col_set_fence) is to separate them using the '/' character. Some dissectors use ' ', others use '|'. Make them all use '/'. Change-Id: Ibcddd7500f637d96313b264122d48ac6bff1e96c Reviewed-on: https://code.wireshark.org/review/31804 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29column-utils: replace TAB with SPACE in prototypes.Dario Lombardo1-20/+20
In some functions the file showed <ret_type><TAB><func name> while in others <ret_type><SPACE><func name> All prototypes aligned to use the latter. Change-Id: I47163824c9ae629c84df6d795192353eed5d5cca Reviewed-on: https://code.wireshark.org/review/31803 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29MAC NR: add dissection of NR PHR and PCMAX,f,c fieldsPascal Quantin1-22/+74
Change-Id: I86734442de4fcc4781fbee4517d6dccd87f8da30 Reviewed-on: https://code.wireshark.org/review/31806 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-29doc: Add custom window title enhancements to release notesStig Bjørlykke1-0/+1
Change-Id: I8911a55e4f4952095b9ab64d373a6faa19729f63 Reviewed-on: https://code.wireshark.org/review/31801 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29Once we've identified a TCP segment as rpcap, use rpcap for the connection.Guy Harris1-1/+21
One reason to use Wireshark is to diagnose protocol errors, so don't, for example, treat too-short packets, in a TCP connection where we've already seen rpcap packets, as not being rpcap packets. (Yes, that *is* a bug, in the libpcap master, that I found and fixed.) Change-Id: I9a81e5b9a2910331574164395302247a446e805b Reviewed-on: https://code.wireshark.org/review/31809 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-29CMake: Minor standard output improvementsJoão Valverde1-11/+14
Change-Id: I7677220ec49d7b04f61e2a7287dac3a744f1c6c6 Reviewed-on: https://code.wireshark.org/review/31786 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-01-29lwm2mtlv: Fix memleaks in UAT subtree array handlingStig Bjørlykke1-13/+12
No need to allocate pointers for subtree indexes. Change-Id: Ia1214e42d8220341454e1126878c217835788797 Reviewed-on: https://code.wireshark.org/review/31776 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29wslua: Don't defer deletion of subtree indexesStig Bjørlykke1-5/+2
The subtree indexes are only used in the dissector so it's not needed to defer the deletion. Change-Id: I33600897a186c078cc1021cde5a1d90054d475c8 Reviewed-on: https://code.wireshark.org/review/31800 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29ASTERIX Category 020 Ed. 1.9 and Reserved Expansion Field Ed. 1.3Marko Hrastovec1-1/+1424
ASTERIX dissector now supports Category 020 Edition 1.9, which is used for Multilateration Target Reports, and Reserved Expansion Field for Category 020 Edition 1.3. Specifications for Category 020 are: https://www.eurocontrol.int/publications/cat020-multilateration-mlt-messages-part-14 https://www.eurocontrol.int/publications/cat020-coding-rule-reserved-expansion-field-part14-appendix Change-Id: I867f48c3d4299c22f68edf1e3f9cdbcfabc47eb4 Reviewed-on: https://code.wireshark.org/review/31766 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29btmesh: Fix memleaks in UAT handlingStig Bjørlykke1-1/+19
Free allocated strings before allocating new and in free callback. Change-Id: If7bd0ee8455cf3c3e0c6300ce79e20557256eb8e Reviewed-on: https://code.wireshark.org/review/31773 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-29Fix: WiSUN Explicit Channel Plan parsingJames Ko1-12/+42
The Unicast Schedule IE (US-IE) and Broadcast Schedule IE (BS-IS) may define an explicit channel plan with the following fields in the channel information fields: 24-bits - channel 0 frequency in kHz (little endian byte-order), 4-bits - channel spacing enumeration, 4-bits - reserved (must be set to 0), and 2-bytes - number of channels Bug: 15451 Change-Id: If6923faca777343e17b0cb9012bb07d98b9bc194 Reviewed-on: https://code.wireshark.org/review/31745 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-29wslua: Update wslua_register_menu() documentationStig Bjørlykke2-1/+3
Add missing group values. Update regex to match TELEPHONY_MTP3. Change-Id: I709a416e30d79c2de69887548015a3c1ecfe5bab Reviewed-on: https://code.wireshark.org/review/31779 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28Further improve that error message.Guy Harris1-1/+1
Put the function name in quotes. Change-Id: I09be392a9bac3b56c13b82a554d17ea29695657c Reviewed-on: https://code.wireshark.org/review/31790 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-28Fix an error message.Guy Harris1-1/+2
I guess "s" in "The function s" was supposed to be "%s", giving the function name. Make it so, and properly fetch the function name. Change-Id: I67287f24626fa0a2816fb2cf574e5d9ff58713bf Reviewed-on: https://code.wireshark.org/review/31787 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-28tests: Skip Lua related tests when Lua is not presentVasil Velichkov2-2/+4
Change-Id: I46ea83c0295d53f3b0b1d7f372c4fef2fb292e6c Reviewed-on: https://code.wireshark.org/review/31785 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28Update a column to reflect the underlying issue.Guy Harris1-4/+10
See https://code.wireshark.org/review/c/31755/#message-d73e5c7c_eed569dc for the details. Change-Id: Ib4f28d843a96ec30daa263f49ac2620bfecba718 Reviewed-on: https://code.wireshark.org/review/31780 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-28epan: add missing include.Dario Lombardo1-0/+1
Fix broken compilation on fedora28. Change-Id: Ib2c4ec3b2437bab0b8bf35e8a3c8072cf1c0f996 Reviewed-on: https://code.wireshark.org/review/31772 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2019-01-28IEEE1609dot2: Use GUINT_TO_POINTER/GPOINTER_TO_UINT to store a guint32Anders Broman3-15/+11
This should be changed so that ieee1609dot2 is called with a struct as data containing the psid. If needed it can be stored in actx->private data. Change-Id: Iccef08a93fd090eb586401b2999684eee2afb382 Reviewed-on: https://code.wireshark.org/review/31775 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-28BER: don't use invalid time offsets.Dario Lombardo1-3/+5
4 digits values could overflow the destination buffer. Skip them since they're invalid and can only from tainted data. Bug: 15447 Change-Id: Ice6d4f144597499483160ecaa63702025ab86f61 Reviewed-on: https://code.wireshark.org/review/31751 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28couchbase: update list of HELLO featuresSergey Avseyev1-1/+4
Change-Id: I323c54faaeaf951e284fa3b64c19e9e6671d36ec Reviewed-on: https://code.wireshark.org/review/31767 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-28wslua: Improve syntax error messageStig Bjørlykke1-3/+3
The filename is included in the error message from Lua so we don't need to display this twice. Change-Id: I00aa7255ff24b07b9f45a8e814a97b61c35936e1 Reviewed-on: https://code.wireshark.org/review/31768 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-28doc: Fix sdjournal podpath warningJoão Valverde1-1/+1
Use the perpod syntax for manpages to remove this warning: Cannot find "tail" in podpath: cannot find suitable replacement path, cannot resolve link Change-Id: I90cb4fe7d3b019e4bc5f5a8fbc7df347f966badb Reviewed-on: https://code.wireshark.org/review/31770 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28lua: fix build with Lua 5.1 due to missing LUA_OK macroPeter Wu1-1/+1
Change-Id: If367f79172c8222c65fd9d95a050e75194df852d Fixes: v2.9.1rc0-556-g6a49c72974 ("wslua: include Lua stack trace in startup error messages") Reviewed-on: https://code.wireshark.org/review/31771 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28dfilter: fix memory leaks on dfilter compile errors involving a setPeter Wu3-5/+23
If a display filter contains a set for the set membership operator and an error occurs, then gen_relation_in() (called via dfw_gencode() will not take ownership of the set and a memory leak occurs. Fix this by implementing a free callback for STTYPE_SET nodes which frees unclaimed data. Add tests to verify the effectiveness, ASAN no longer complains after this fix. Bug: 15442 Change-Id: If37cf047660464b2d0304748034d0bc22111e5d6 Reviewed-on: https://code.wireshark.org/review/31758 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28dfilter: fix memory leaks if a dfilter fails to compilePeter Wu4-2/+27
A display filter can contain values such as strings, numbers, etc. These are internally stored in a fvalue_t structure. While compiling a display filter, it will store a fvalue_t in a node of type STTYPE_FVALUE. These nodes are created while parsing the dfilter in dfilter_compile(). If the semantic check and conversion (dfw_semcheck()) succeeds, it will transfer the values of the parsed tree to dfw_gencode(). After that, dfwork_free will dispose the tree while a compiled dfilter code remains. When the dfilter code is destroyed, it will free the values too. However, when dfw_semcheck() fails (for example, due to an illegal filter such as "len(badname)==1"), it will skip "dfw_gencode()" and consequently the fvalue data is not transferred nor freed. Fix this by always freeing the data (unless the data was stolen by dfw_gencode()). Fixes a memory leak reported for case_dfunction_string::test_fail_2 which was detected by ASAN. Bug: 15442 Change-Id: I9b1cb613659890c8ddcfa57f11f9d3f61a51a3f9 Reviewed-on: https://code.wireshark.org/review/31757 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28wslua: include Lua stack trace in startup error messagesPeter Wu1-6/+28
Error messages without a stack trace are rather hard to debug for more complex Lua dissectors. Be sure to append one, it will look like this: tshark: Lua: Error during loading: /tmp/kdnet/kdnet.lua:13: bad argument #3 to 'proto_field_constructor' (Display must be either base.NONE, base.DOT, base.DASH, base.COLON or base.SPACE) stack traceback: [C]: in function 'proto_field_constructor' /tmp/kdnet/kdnet.lua:13: in function 'add_field' /tmp/kdnet/kdnet.lua:35: in function 'add_fields' /tmp/kdnet/kdnet.lua:242: in main chunk It would be nice to reuse the error handler for dissector calls as well, but I am not sure whether this works with absolute indices which are used almost everywhere in wslua. Change-Id: I89b2dcd360fce3865e1bf052b9fe03e888aae167 Reviewed-on: https://code.wireshark.org/review/31763 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-28funnel: Fix memleaks in funnel_remove_menuStig Bjørlykke4-1/+9
The loop to remove all matching callbacks was skipping every second entry which would give some leaks when reloading Lua plugins. Add funnel_cleanup() to be called in epan_cleanup() at shutdown to remove all allocated menu entries. Change-Id: I3a50ba2070c8675fee1385f25e9e109db57c2dc5 Reviewed-on: https://code.wireshark.org/review/31769 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-28rpc: don't set fence on COL_PROTOCOL.Dario Lombardo1-6/+5
That would prevent subsequent protocols to clear it, resulting in multiple definitions in that column. An example is NFS as next protocol. When contains multiple NFS operations, COL_PROTOCOL contains NFSNFSNFS... Bug: 15443 Change-Id: Idf9469873164160dc4795589c61c342ce019521b Reviewed-on: https://code.wireshark.org/review/31755 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-01-28GBCS: Increment offset before subtracting lengthMartin Boye Petersen1-5/+5
Fixed issue with incorrect item end being set for the grouping header if it includes a KA certificate. Length was subtracted first (set to 0) and therefor the offset would remain unchanged. Change-Id: I23ab1620613af821ee5a41fc29b83e6d4b08430e Reviewed-on: https://code.wireshark.org/review/31764 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-28TDS: Fix colmetadata handling of Text and Image typesCraig Jackson2-57/+73
The Colmetadata handling for TEXT, NTEXT, and IMAGE types was incorrect for TDS 7 versions before TDS 7.2. In addition, the macros using for testing versions were incorrect. Clean up max length display to agree with Microsoft specification (as best as I can understand it). Bug: 3098 Change-Id: I8254649fd3de97c103078ceaac1557fde3569ded Reviewed-on: https://code.wireshark.org/review/31734 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-27opa-mad: Fixed bfrctrl and portinfo multiblock paddingGoldman, Adam1-21/+26
Moved FabricInfoRecord ett to right location. Change-Id: I97dd540e9929126648a0c690f54f2caa88838365 Signed-off-by: Goldman, Adam <adam.goldman@intel.com> Reviewed-on: https://code.wireshark.org/review/31716 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-27TCP: pass data after a ZeroWindowProbe to subdissectorsPeter Wu4-0/+50
If the single byte within a ZeroWindowProbe triggers reassembly within a subdissector, a new MSP will be created with just a single byte. Be sure not to mark subsequent segments that contain the full segment data as retransmission as this prevents the subdissector from seeing the data. Bug: 15427 Change-Id: I36ae2622689c6606c99cdff70b6beba4b9d25ca7 Reviewed-on: https://code.wireshark.org/review/31732 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jasper Bongertz <jasper@packet-foo.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-27TCP: do not mark data following a ZeroWindowProbe as retransmissionPeter Wu2-0/+19
The single byte within the ZWP could be retransmitted with the next segment, this is perfectly acceptable behavior. Do not flag these new segments as retransmissions or Out-Of-Order. Bug: 15427 Change-Id: I76db2b7a2b684c8c78fa24c9c4b457e1833d12b7 Reviewed-on: https://code.wireshark.org/review/31731 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jasper Bongertz <jasper@packet-foo.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-27doc: update sshdump manual to reflect the current statePeter Wu1-25/+40
Option --extcap-interface=ssh seems to give an error, update it. Note that --remote-capture-command overrides other options. Perhaps some form of template should be supported, but that is currently not implemented. Change-Id: Iee132941a460afca91e73cf3e3ec3501dc15f14d Reviewed-on: https://code.wireshark.org/review/31753 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-24 16:50:13 +0000