aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-11-19Qt: Fix Activation of menusRoland Knall1-0/+2
Fixes the bug, where submenu items are not properly activated Bug: 14232 Change-Id: I007010310dfa8a6c7eba3ba8cdf3eac74701b0ba Reviewed-on: https://code.wireshark.org/review/24493 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-19packet-h223.c: Ensure conversation data existsMichael Mann1-2/+4
There is more potential for conversation data than previous circuit data so ensure h223 conversation data exists in retrieved conversation. Bug: 14233 Change-Id: I7074b1c110d40b4727812d0ef4f5391b6d2c0c33 Reviewed-on: https://code.wireshark.org/review/24492 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-19CMake: Fix error from bab9abfb7d259e1daaf84776ed9d4d09e2469293Graham Bloice1-1/+0
Fix a cut and paste error Change-Id: I28fa3644d5b7969c8009f5722f270c8fa566dd34 Reviewed-on: https://code.wireshark.org/review/24491 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2017-11-19[Automatic update for 2017-11-19]Gerald Combs9-153/+224
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I52c4830ef81733156fa4ce0de65330c8aacd8932 Reviewed-on: https://code.wireshark.org/review/24487 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-11-19Move dissect_leb128 to file-elf.cMichael Mann7-113/+22
This allows for the removal of epan/dwarf.[ch] Functionality could probably be handled by an encoding (like dissect_uleb128), but for now keep it in file-elf.c as that's the only functionality currently using it. Change-Id: I84cf6af02abb3d53ea7d9b774e3313d77a1ff497 Reviewed-on: https://code.wireshark.org/review/24486 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-19dissect_uleb128 -> tvb_get_varint/proto_tree_add_item_ret_lengthMichael Mann6-68/+30
Also update ENC_VARINT_PROTOBUF documentation while we're at it Change-Id: I72e1f9175adc0c6a8bb03ceddba04ffd4844a12e Reviewed-on: https://code.wireshark.org/review/24485 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-18CMake: Fix package requirements for building docsGraham Bloice1-19/+22
Make ASCIIDOC and XSLTPROC packages required if building any of the HTML, PDF or CHM guides. Don't attempt to build the release notes if ASCIIDOC isn't found. Change-Id: Id61653a635f91cbaffa32fb26ddbdbc568b74528 Reviewed-on: https://code.wireshark.org/review/24483 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-18autotools: Library build products don't need explicit cleaningJoão Valverde32-130/+9
Change-Id: I5d68c05f2844d6c9ae486531b189dbf10bc09cff Reviewed-on: https://code.wireshark.org/review/24484 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-18Fix indentationJoão Valverde3-22/+22
Change-Id: I558f23572dc36ba96fd1c2f904b1ac6b6c343297 Reviewed-on: https://code.wireshark.org/review/24482 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-18ZigBee ZCL Device Management Cluster dissectorIvan Ermakov2-24/+325
Added Device Management cluster dissector: cluster, command names. Change-Id: I1ed9c53a09aed10584cd372630fbec5e661cacd8 Reviewed-on: https://code.wireshark.org/review/24449 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Boye Petersen <mbpflonidan@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-18CMake: Clean up Windows buildGraham Bloice14-42/+70
Remove options that aren't supported on Windows Don't use pkgconfig on Windows Change-Id: I79718a1c43f56a9ec88f690490931b80b727dd68 Reviewed-on: https://code.wireshark.org/review/24481 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-18The header is host-endian, not little-endian. Note that.Guy Harris1-8/+18
Change-Id: I7fc2874026430c3d7e8633c48ee0558ad69d5c9a Reviewed-on: https://code.wireshark.org/review/24480 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-18Reformat comment giving Kerberos 4 specification.Guy Harris1-7/+7
Change-Id: I06350d56aeedf0c0cb1c72f3597a093a6f97847c Reviewed-on: https://code.wireshark.org/review/24479 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-18URL for the document.Guy Harris1-0/+3
Change-Id: I9b381f923599f7b4750b21053cdfb3b1d72bce22 Reviewed-on: https://code.wireshark.org/review/24478 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-18Update .gitignoreJoão Valverde1-4/+2
Change-Id: Ia066511bc27618ee8e0a55e046a6d9437a4c3175 Reviewed-on: https://code.wireshark.org/review/24477 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-18Begin cleanup of make-dissector-reg.pyJoão Valverde9-175/+255
Move registration code to a new register.c file so it is readable. Dissector load points are stored in a generated function pointer array instead. Simplify python script somewhat by not interleaving the plugin and dissector logic. Change-Id: I5ec21270f4e1550a5c911efa7f0dc4fc7fcb13a5 Reviewed-on: https://code.wireshark.org/review/24474 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-18.mailmap: update (of November)Alexis La Goutte2-1/+2
Change-Id: Ia42fe05bbc250944441576a3b7894839f4fe6ed2 Reviewed-on: https://code.wireshark.org/review/24452 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-18ieee1905: Fix the incorrect dissection of radio operation restrictionRichard Sharpe1-4/+11
The dissection was really wrong. Fixed now I have seen captures. Change-Id: I038fbf8786306fad9c65c87aa5d58c155113c442 Reviewed-on: https://code.wireshark.org/review/24476 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-18Qt: Use QThreadPool instead of QThread.Gerald Combs1-4/+4
I'm not sure how many Qt worker threads we're going to create at startup, but using a thread pool is simple enough. Change-Id: I66c3e1e628f8c38c8e3322e0c01ee5fccda2a98e Reviewed-on: https://code.wireshark.org/review/24473 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-18ieee80211: Complete fixed size fields for SAE authenticationCedric Izoard1-2/+200
SAE authentication (used for mesh-point) introduced new non IE fields (aka fixed size fields) that require explicit parsing. The tricky part is that some of those fields don't have a fixed size... - 'scalar' and 'finite field element' size depend of the group used. Retrieve size of all groups supported by wpa_supplicant. - 'anti-clogging token' size is not specified. Bug: 14222 Change-Id: Id0aa8790c55b21b2797ba131de9e46c32519e2cc Reviewed-on: https://code.wireshark.org/review/24446 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-18Qt: Properly reset the byteviewRoland Knall4-1/+24
Reset the byteview on every load of a capture file, and on every start/reset of a capture Change-Id: I0edd30ffddc64484bc6f009d99dfc6fc1a3ceb59 Reviewed-on: https://code.wireshark.org/review/24468 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-18IEEE 802.11: fix an infinite loopPascal Quantin1-1/+1
Presumably the element length is unsigned, otherwise it can be negative and reincrement tag length. Bug: 14231 Change-Id: I26d339aea7588a489b4252b67c212810029bff0e Reviewed-on: https://code.wireshark.org/review/24472 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-17Qt: Initialize QMimeDatabase in a worker thread.Gerald Combs3-11/+53
As part of its initialization, QMimeDatabase parses the freedesktop.org shared-mime-info database, which is a large-ish (2 - 4 MB) XML file. This takes about 85 - 90 ms here. We first access QMimeDatabase in our startup sequence when we load the normal and capture application icons. Create a worker thread that initializes QMimeDatabase as early as possible and load load the normal and capture icons as late as possible. Change-Id: I27e3d65d8ee1308a62d12d3ff7e1b95f82c2e75a Reviewed-on: https://code.wireshark.org/review/24471 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-11-17Qt: Fix selection of elementsRoland Knall2-9/+76
If two elements existed with the same filter expression, the first element got selected allways. This is much more secure, as it only takes the label into account. If the user by accident created two buttons with the same filter expression, but different label and wants to remove the second button, the first one no longer will be removed instead of the second one. Change-Id: I16130aa69cb853aedb9a5c9b0bbbb3eb64b467d1 Reviewed-on: https://code.wireshark.org/review/24399 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-17fp: Fix mac TVB for edch t1Darien Spencer1-2/+2
Using the '_caplen' function with length of -1 leads to a "truncated RLC" error. Change-Id: I5a5f650b244de1167ff7110558ad0559d0422103 Reviewed-on: https://code.wireshark.org/review/24462 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-173GPP NAS: fix dissection of PCO MSISDN container IDPascal Quantin1-3/+2
3GPP 24.008 is not very explicit regarding the encoding, but after rereading 3GPP 23.003 and 3GPP 29.272, it is most likely the E.164 number in TBCD encoding (so without TON/NPI byte). Change-Id: Iae58ccc2919d28cb802015205b3b5fb97a1c4abe Reviewed-on: https://code.wireshark.org/review/24463 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-11-17WSDG: Improve VS2015 chocolatey installGraham Bloice2-4/+95
Created an AdminDeployment.xml file for use with the chocolatey package for VS2015 Community Edition and updated the WSDG to include it. Bug: 14147 Change-Id: Id2a701067bf38874cf0bf534cca55dba9cfd30d4 Reviewed-on: https://code.wireshark.org/review/24464 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2017-11-17[Juniper ST] Dissect the "known" parts of the Juniper header.AndersBroman1-9/+83
Ping Bug: 14195 Change-Id: I7ab05857c054a0d914db9373d182008215d67367 Reviewed-on: https://code.wireshark.org/review/24461 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-17rrc: fixed incorrect constantsDarien Spencer2-4/+4
The macinf->content field should be compared to MAC_CONTENT_* and not MAC_* Change-Id: I0dee7855938095c5d1c53f4db13003b90cf7ba91 Reviewed-on: https://code.wireshark.org/review/24460 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-17ieee80211: Add dissection of BSS Transition QueryAlexis La Goutte1-0/+66
Bug: 14220 Change-Id: Iec155a6fbb179bd0e0aaf8b10fd7d420dc1a69bb Reviewed-on: https://code.wireshark.org/review/24453 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-17register(.h): fix parameter 'register_cb' not found in the function ↵Alexis La Goutte1-2/+2
declaration [-Wdocumentation] Change-Id: I78afc76dcef56e46e296988299cab58c93eaeb03 Reviewed-on: https://code.wireshark.org/review/24459 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-17No need for a read/write descriptor for the output file.Guy Harris1-1/+1
Change-Id: I66539b27f09d3a5acaae2c0ee080bca984c17468 Reviewed-on: https://code.wireshark.org/review/24457 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-17Allow dumpcap to write to a named pipe.Guy Harris1-0/+5
We didn't actually bother *opening* the named pipe if it wasn't named "-" (meaning "use standard output"). Hilarity^WRandom failure behavior ensued. Change-Id: If73cea232b13de664630d587167167ef53a95cba Reviewed-on: https://code.wireshark.org/review/24454 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-16[PFCP] add port 8805Joakim Karlsson1-2/+3
Port assigned by IANA Change-Id: Ic04bc41878561239c83025ff2d5573daf7947b5b Reviewed-on: https://code.wireshark.org/review/24451 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-16gitlab-ci: add clang builds.Dario Lombardo1-24/+38
From clang 3.5 to 4.0, using official ubuntu docker image. Change-Id: I60f41f2eb83990e4298ece27027413994d4f6440 Reviewed-on: https://code.wireshark.org/review/24405 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-16Register protocols and handoffs in separate threads.Gerald Combs3-32/+116
Instead of interleaving protocol registrations and status callbacks in the main thread, move protocol registrations to a worker thread. Do the same with protocol handoffs. This *should* be safe since the status callbacks only update the UI. This reduces startup time by about 200ms on my laptop: Run OS Thread? Time 1 macOS N 340 ms 2 macOS N 260 ms 3 macOS N 252 ms 4 macOS Y 147 ms 5 macOS Y 146 ms 6 macOS Y 142 ms 7 Win 7 N 80 samples 8 Win 7 N 56 samples 9 Win 7 N 75 samples 10 Win 7 Y 31 samples 11 Win 7 Y 2 samples 12 Win 7 Y 0 samples macOS was sampled using Instruments. Windows 7 was sampled using the Visual Studio 2015 profiler. We should do the same thing with our capture and tap event loops, but that will likely require quite a bit more work. Change-Id: Iac9a81d8f71668f5979b524744a03f6d80aee893 Reviewed-on: https://code.wireshark.org/review/24447 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-16Qt: Add UAT move up and down buttonsStig Bjørlykke13-0/+184
Add two new buttons for moving entries up and down in the list. Change-Id: I90e5c5812754391651885e2a622148cecc124099 Reviewed-on: https://code.wireshark.org/review/24413 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-16Registering CMP PKIMessage as BER dissectorMartin Peylo2-31/+25
Decoding ASN.1 BER as PKIMessage enables to examine a CMP (RFC 4210) message which was saved as file. Along the way, improving dissect_cmp_pdu function parameters to match required API for register_ber_syntax_dissector(), factoring in creation of asn1_ctx. Change-Id: I3284e6de9255e2b3cbf142c2904226b7e45b31f8 Reviewed-on: https://code.wireshark.org/review/24445 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-15Explain where GeoIP_free comes fromJoão Valverde3-2/+6
Change-Id: I0a354cde4587a041bdb1fa4147bd88eed24ceb76 Reviewed-on: https://code.wireshark.org/review/24356 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-15Qt: Show as much as possible of UAT pathLabelStig Bjørlykke2-26/+0
Remove the horizontal spacer between buttons an path label in UAT views to show as much as possible of the path label. Change-Id: I99d21ff6a1d151c9fcf83200a88b34b2e0c8eb5d Reviewed-on: https://code.wireshark.org/review/24444 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-15udpdump: add space.Dario Lombardo1-1/+1
Change-Id: I44960f64f16434ccdf033eaa2bfa96579da7cc4b Reviewed-on: https://code.wireshark.org/review/24439 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-11-15kerberos: Don't generate unused _vals tablesStig Bjørlykke2-41/+33
Put PA-FX-FAST-REPLY and PA-FX-FAST-REQUEST in .NO_EMIT ONLY_VALS Change-Id: If0476c6d2bb78a15e3b984a7edafc3a7800fa490 Reviewed-on: https://code.wireshark.org/review/24436 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-15QUIC: fix STOP_SENDING lengthAlexis La Goutte1-1/+1
Change-Id: I954425bb54f9511ba2cea50adfa8c69ea322267c Reviewed-on: https://code.wireshark.org/review/24429 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-15Qt: Update UAT clear button enablingStig Bjørlykke1-0/+1
Check for enabling the clear button when loading a UatFrame. Change-Id: Id9bbe4f99314d2798c4bccf10b57db99431a00fd Reviewed-on: https://code.wireshark.org/review/24412 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-11-15JXTA: Remove some assertions.Gerald Combs1-198/+213
g4d2e653901 in 2009 removed some "if (tree)" checks, which in turn exposed some DISSECTOR_ASSERTs which trigger on short packets. Add an expert info field for truncated media data and comment out the assertions. The jxta-spec.dev.java.net specification link is dead. Add what appears to be the current location. Change-Id: Ic669c6631c6058a853d69ecd38ef4d2065c7eb24 Reviewed-on: https://code.wireshark.org/review/24426 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-15JXTA: Simplify some expressions.Gerald Combs1-48/+48
The sizes of guint8, guint16, and guint32 are always 1, 2, and 4 bytes respectively. Just use 1, 2, and 4. Change-Id: I857d33873cc5831ba23544475f721e485b8bd817 Reviewed-on: https://code.wireshark.org/review/24427 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-15Handle LINKTYPE_JUNIPER_ST 200.Anders3-5/+39
Bug: 14195 Change-Id: Ic6be8e1f8169968c48376984c0d1a1a69c67f32a Reviewed-on: https://code.wireshark.org/review/24415 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-15UI: Fix seg fault of software update language initUli Heilmeier1-2/+2
Set only software update language when language is configured. Change-Id: If3f0e304b95863a30fb7bb69197addf4bad689c7 Reviewed-on: https://code.wireshark.org/review/24414 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-14Kerberos - Add support for RFC 6113Michael Mann8-84/+615
Bug: 8974 Change-Id: I43998a64fc34dfeb1c0a8d702d5bdc5aa74d57de Reviewed-on: https://code.wireshark.org/review/17879 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-14Qt: Change delete_list icon transparent valueStig Bjørlykke2-0/+0
Update the delete_list icon to have same transparent value as the other icons used in UAT handling. Change-Id: I5de7f3d6c0292e6ffde7d8cfd08a899e135fe108 Reviewed-on: https://code.wireshark.org/review/24411 Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-01 09:43:26 +0000