aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-10-06Convert "4 space tabs" to spaces; Adjust editor modelines.Bill Meier11-4591/+4592
Change-Id: I8d61d959c79e6aa9875c58680c54a331d18079cc Reviewed-on: https://code.wireshark.org/review/4504 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust indentation to match editor modelines; Do other minor whitespace changes.Bill Meier36-4407/+4413
Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353 Reviewed-on: https://code.wireshark.org/review/4502 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-rpcap.c: Don't use mixed space/tab indentation;Bill Meier1-124/+124
Change-Id: I21409a02fabc28951d9c15be7a160295f5fb35ca Reviewed-on: https://code.wireshark.org/review/4501 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust editor modelines to match actual format of the file; Adjust some ↵Bill Meier2-76/+74
whiotespace. Change-Id: If930f2c266b61c9348063eab0189af2582b0a331 Reviewed-on: https://code.wireshark.org/review/4500 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Convert (what appear to be) "4 space tabs"; Adjust editor-modelines; Do some ↵Bill Meier3-3497/+3505
minor reformatting. Change-Id: Ie078c826ed38a0d682f61fb3e95450b47a9d2c31 Reviewed-on: https://code.wireshark.org/review/4499 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-g723.c: Remove some boilerplate comments.Bill Meier1-17/+1
Change-Id: Ib322b33c304674835170e1ae2006aabf0f44fd9d Reviewed-on: https://code.wireshark.org/review/4498 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-hclnfsd.c: Reformat hf[] entries; Adjust some whitespace.Bill Meier1-98/+122
Change-Id: I84368080d12cb5001dd7847add0ec96608080604 Reviewed-on: https://code.wireshark.org/review/4497 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06packet-q931.c: Reformat hf[] entries; Convert apparent "4-space tabs" to ↵Bill Meier1-2721/+3057
spaces. Adjust editor modelines. Change-Id: Iaeb321f0facfc6b3176677779e6cdf5c92226dec Reviewed-on: https://code.wireshark.org/review/4496 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Dissect 3GPP AVP Presence-Reporting-Area-Elements-List.AndersBroman1-19/+46
Change-Id: Ic7b99d41a275fb6f50758ea87763844f24be537c Reviewed-on: https://code.wireshark.org/review/4495 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-06tcp: default no-subdissector-on-error to TRUEEvan Huus1-1/+1
Dissectors that need this set break badly when it isn't. Dissectors which don't need this set will still generally be understandable without it, since e.g. retransmissions will link to the original packet at the TCP layer, and presumably the subdissector payload is exactly the same in that case. Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603 Ping-Bug: 10525 Ping-Bug: 10289 Reviewed-on: https://code.wireshark.org/review/4487 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-06Expand dissection of 8.108 Presence Reporting Area Action.AndersBroman1-10/+100
Change-Id: I2ad57d8cdb6758f01146b37ac924e2d8f2141546 Reviewed-on: https://code.wireshark.org/review/4491 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-06Modify multicheck to accept parent parameter.Tomasz Moń4-39/+156
This makes it possible for multicheck to become a tree-like structure. Example: arg {number=4}{call=--devices}{display=Devices}{tooltip=Device selector}{type=multicheck} value {arg=4}{value=dev1}{display=Parent Device}{enabled=t}{default=t} value {arg=4}{value=dev2}{display=Child Device}{parent=dev1}{enabled=t} value {arg=4}{value=dev3}{display=Another Parent Device}{enabled=t} value {arg=4}{value=dev4}{display=Non-clickable Child Device}{parent=dev3} value {arg=4}{value=dev5}{display=Non-clickable Child of Child}{parent=dev4} Change-Id: I59dd7208ca0ec90cccfc49ae049559cdc6c69a4b Reviewed-on: https://code.wireshark.org/review/4192 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-06Adjust some whitespace to match editor modelines.Bill Meier8-38/+38
Change-Id: I9fda7de49255857cc1cf270d6202c85573d91674 Reviewed-on: https://code.wireshark.org/review/4490 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust some whitespace to match editor modelines.Bill Meier20-1168/+1167
Change-Id: Ia22cac3ebd7a454c156f98d967e6fd61f708a2b3 Reviewed-on: https://code.wireshark.org/review/4489 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06plugins: Add editor modelines; Adjust whitespace as needed.Bill Meier70-3745/+4623
Change-Id: I36124f6021d46a228721bdc976f6b9fef1c8c088 Reviewed-on: https://code.wireshark.org/review/4488 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-05mpeg-pes: don't modify source and destination address columsMartin Kaiser2-32/+6
the mpeg-pes dissector replaced source or destination address with decoding timestamp, presentation timestamp or pack data rate these values don't belong into address columns and erase the IP addresses when mpeg-pes is transmitted over IP the timestamps etc can be displayed in a user-defined column if required this patch is part of Bug: 10505 Change-Id: I1bf561648f848eb18818862edd138724abfc8e88 Reviewed-on: https://code.wireshark.org/review/4472 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-10-05docsis: Add editor modelines; Adjust whitespace; Remove boilerplate comments.Bill Meier44-7941/+7702
Change-Id: I78f9815616f4fc3c14204339c5826f0ca7d0680e Reviewed-on: https://code.wireshark.org/review/4485 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-05Add editor modelines; Adjust whitespace as needed.Bill Meier56-1557/+2284
Change-Id: I6e70c933ae61a97377235d67b2f6a1b3d67dc155 Reviewed-on: https://code.wireshark.org/review/4484 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-05Reformat hfi entries; Add editor modelines; Adjust whitespace.Bill Meier2-323/+349
Change-Id: Iead53f92cc847d04c32f4a307d45f9748c49a69c Reviewed-on: https://code.wireshark.org/review/4483 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-05packet-igap.c: Reformat hf[] entries; Add editor modelines.Bill Meier1-131/+170
Change-Id: I0ac4f2eb7f2b93aab864c6f43dee057774048165 Reviewed-on: https://code.wireshark.org/review/4482 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-05Read the record length in common code.Guy Harris1-61/+52
Instead of reading the 16-byte blob and record length at the same time, just read the 16-byte blob, and then fall through to the record-length reading code. Change-Id: Ib2819a2d654e2670233821882bac79d7cd656b12 Reviewed-on: https://code.wireshark.org/review/4480 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-05[Automatic manuf, services and enterprise-numbers update for 2014-10-05]Gerald Combs4-27/+228
Change-Id: Ib90638f6382b2112f0f49a2d8f5d2d10b4d3c520 Reviewed-on: https://code.wireshark.org/review/4474 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-05DLT User: add ability to export PDUsPascal Quantin1-1/+25
It can be really useful to share hand crafted captures without the need to configure the DLT User table Change-Id: Iefab00b741f95b1f3a3247cb28ed01a367fa4ff4 Reviewed-on: https://code.wireshark.org/review/4469 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-05Fix a comment.Guy Harris1-1/+1
Change-Id: I875888753859488ed810cedb5656bd870bee7122 Reviewed-on: https://code.wireshark.org/review/4471 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-05Improve comments, and add some #defines, to make it clearer what the code does.Guy Harris1-47/+110
Change-Id: I2cd8973bdce171053664cf4ed06a37bdd9b30353 Reviewed-on: https://code.wireshark.org/review/4470 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-04DSR: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-11/+11
Change-Id: Ifd694dc9a72cde787c00820ec5a02cc33d5157e0 Reviewed-on: https://code.wireshark.org/review/4466 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-04LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I616e57c84c5721213ee12a41b63595547ab15f72 Reviewed-on: https://code.wireshark.org/review/4465 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-04EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I88b90302df0202d38b7c089cf243e7860766e653 Reviewed-on: https://code.wireshark.org/review/4464 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04GSM-SMS: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+0
Change-Id: If0700726bf9a7359313d0cb69d959471c0ea9580 Reviewed-on: https://code.wireshark.org/review/4463 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04Juniper: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I9178a3de683dda661ed68ef6d743036a9f8aa39e Reviewed-on: https://code.wireshark.org/review/4462 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04RSVP: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+0
Change-Id: Iccfeaa514cd60f02bb37e210c5f714bcb616521b Reviewed-on: https://code.wireshark.org/review/4461 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04Eliminate proto_tree_add_text from packet-gsm_a_bssmap.cMichael Mann1-525/+385
Also remove other_decode_bitfield_value calls. Change-Id: I056fe74fbd547b690cd5ed60e3e8777df9474704 Reviewed-on: https://code.wireshark.org/review/4468 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04GTK (hostlist_table) fix indent (use 4 spaces) and modelines infoAlexis La Goutte1-13/+26
Change-Id: I072de752df0c0e41be663889dafd0f5860a29c37 Reviewed-on: https://code.wireshark.org/review/4458 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04GTK (hostlist_table) warning: comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I83e930b3179ce954fa4c09d1f46cc833517aa1f6 Reviewed-on: https://code.wireshark.org/review/4457 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04Qt (manage interface): fix warning: comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-2/+2
Change-Id: I728a50e47fd0d8eea77bc1cdebe2a155184ea953 Reviewed-on: https://code.wireshark.org/review/4456 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04extcap: warning: no previous prototype for ‘extcap_free_arglist’ ↵Alexis La Goutte1-5/+0
[-Wmissing-prototypes] Remove extcap_free_arglist (never used) Change-Id: I1f751512be627380a992db63c3e4abd22b3aa486 Reviewed-on: https://code.wireshark.org/review/4455 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04CEPH: Fix comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I0c04a3d217e75986878b276a1ac82b427de38384 Reviewed-on: https://code.wireshark.org/review/4454 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04DCERPC (butc): fix warning: no previous prototype for ... [-Wmissing-prototypes]Alexis La Goutte2-4/+4
Fix a typo in last patch and regenerate file Change-Id: Id9083edd797af97d72a872187a0d0b5750e04547 Reviewed-on: https://code.wireshark.org/review/4453 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04CP2179: Fix warning: no previous prototype for proto_register_cp2179 ↵Alexis La Goutte1-2/+2
[-Wmissing-prototypes] Move on top also prototype of proto_reg_handoff_cp2179 Change-Id: I00f23a88606426acd17d63104630a885682d3c02 Reviewed-on: https://code.wireshark.org/review/4452 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-04Add editor modelines; Reformat as appropriate.Bill Meier66-5666/+6468
Change-Id: I8e9c58b75eea85877d22024201e5d8d0e9a3dbfd Reviewed-on: https://code.wireshark.org/review/4459 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-04Update capture_opts in extcap_cleanup().Tomasz Moń3-26/+22
This fixes redundant extcap_pid handle close that could occur in capture_opts_del_iface() which resulted in unhandled exception on Windows. Change-Id: I06b680fcb65cd6fd854a25fb1b01248dce3251a1 Reviewed-on: https://code.wireshark.org/review/4447 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-04Wait for extcap to connect to pipe on Windows.Tomasz Moń2-2/+129
This prevents dumpcap from failing with timeout exceeded error message with some extcaps (especially those that display UAC screen) by making sure that extcap connects to pipe before dumpcap is even started. Change-Id: I549da9217c7f4ae89509330ca4fa613a119a9523 Reviewed-on: https://code.wireshark.org/review/4428 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-04Use some macros to clean up the Snifer decompression code.Guy Harris1-92/+91
For code that's used in more than one place, use macros. This combines a bunch of checks into the output macros. Change-Id: Ic32dce75e1c531fd28bfed180856e230277bfe58 Reviewed-on: https://code.wireshark.org/review/4451 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-03Fix memory leak and heap corruption on Windows.Tomasz Moń1-6/+6
LPSECURITY_ATTRIBUTES is type definition for pointer to SECURITY_ATTRIBUTES structure. Change-Id: I94a835bfd8f7eb76c808fac8286ca3f2db9b19c3 Reviewed-on: https://code.wireshark.org/review/4449 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-03WSDG: Update the Windows Qt download text.Gerald Combs1-15/+6
Change-Id: I6fd027ff76b5b463f33992898965a3e037778071 Reviewed-on: https://code.wireshark.org/review/4443 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-03Add editor modelines; Adjust whitespace as needed.Bill Meier42-3708/+4251
Change-Id: I391cdf80a6e4ae5b0f4068e0500a90d013588f8a Reviewed-on: https://code.wireshark.org/review/4442 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-03packet-aim-messaging.c: Add editor modelines; reformat various (including ↵Bill Meier1-105/+176
hf[] entries). Change-Id: Ie5973a717a80ba75b82e817cb9e30c3529afbb0c Reviewed-on: https://code.wireshark.org/review/4441 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-03packet-dcerpc-fileexp.c: Add editor modelines; reformat various (including ↵Bill Meier1-1378/+1934
hf[] entries). Change-Id: I0d49f4c1c3a3960c3fdc9b1cd411c73097829c09 Reviewed-on: https://code.wireshark.org/review/4440 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-03LocationNumber digits is off by one(to many).AndersBroman2-6/+6
Bug 10522. Change-Id: I7887f3ee229ac22d2aa37a3d8900d76d8b814ed0 Reviewed-on: https://code.wireshark.org/review/4439 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-03Create field filters for gsm_rr_csn_HL_flag() usages.Michael Mann1-95/+188
Change-Id: I74f110b477a3bf7e0c374db3147604d50018deba Reviewed-on: https://code.wireshark.org/review/4435 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>