aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-02-08Licensecheck improvements, just two errors left.Evan Huus6-19/+116
Spawned from https://www.wireshark.org/lists/wireshark-dev/201402/msg00024.html Add some ignore rules for files that can't/shouldn't include a license header. Reorganize some ignore rules to group rules with similar motivations. Add a header to autogen.sh and attribute it to just "The Wireshark Authors" since while Gilbert wrote the original version it's gone through so many changes over the years that sorting out proper authorship is unnecessarily complex. Add headers to Graeme Hewson's two files as verified by private email, and update his address in the AUTHORS file per his request. Add header to one of Ulf Lamping's files, as verified by private email. Only remaining problem is the reedsolomon code. Change-Id: Ifb7de8c4b4d79012553e29d459a0145d39f51df5 Reviewed-on: https://code.wireshark.org/review/145 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-08Fix typo about encoding in MIP6 dissector...Alexis La Goutte1-1/+1
Change-Id: Id0b50ddacf2e3cae008590456316586d262e6029 Reviewed-on: https://code.wireshark.org/review/146 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-08Fix some typo in MIP6 dissectorAlexis La Goutte1-54/+67
Fix indent (use 4 spaces) Add modelines info Fix warning found by fix encoding args tools Change-Id: I4de8e3c0729c550eeceddd8e1a67fb6aa063844a Reviewed-on: https://code.wireshark.org/review/144 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-08Fix bug 9733 ' Lua: wtap_filetypes.TSPREC_ variable names are missing from ↵Hadriel Kaplan1-1/+2
the Lua global table' The fix for bug 9712, which involved changing the make-init-lua.pl perl script to handle the new C-code define names for filetypes in release 1.11, unfortunately also stopped matching against the timestamp define names. Arguably the timestamp ones should never have been matched to begin with, at least not by the same regex function, because they're not "filetypes". But they've been matched and exported into the Lua table forever, so we'll break backward-compat if we don't keep doing it. Ugh. The good news is I caught this bug using a new test script I wrote which verifies previous release's Lua stuff didn't disappear. I'll submit that separately when I get a chance to clean it up, hopefully next week. Change-Id: Ibf1d1da0dc4ed62cc1bacf345742dccf8ec40e30 Reviewed-on: https://code.wireshark.org/review/143 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-08Have macros to handle the range check and byte swapping.Guy Harris1-56/+44
Combine the check for whether the field is within the packet data and the swapping of the field into macros that do both, and use them. Change-Id: I1db4c5fd76172edd44abc9fb111d79a2537c6c9d Reviewed-on: https://code.wireshark.org/review/130 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-08Fix bug 9732: ' Lua: recent commit changed some MENU_ key names in init.lua'Hadriel Kaplan3-2/+23
A recent fix (made by me) for bug 9707, in Change-Id: If4ee1906aa60dd37366cf2ef9bc4168e0ea024b6, made the perl regex grab too much of the menu name. It changed MENU_STAT_CONVERSATION, MENU_STAT_RESPONSE, and MENU_ANALYZE_CONVERSATION's key names into their longer C-code names. Ugh. The fix for this is a bit brittle, but I think it's impractical to avoid it being brittle, due to needing to support legacy Lua scripts. I put comments in stat_menu.h to warn of the danger. Change-Id: I41408e9d4f5b5bd73e2871fccabff81c7cbd242d Reviewed-on: https://code.wireshark.org/review/140 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-08"origin" appears to be a safer bet than "@{upstream}".Gerald Combs1-2/+2
Change-Id: Icd00c62d9b908771bf2b73b8e5b49d519570ff8b Reviewed-on: https://code.wireshark.org/review/142 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-02-07Replace "svn" with "git" all over the place.Gerald Combs36-179/+191
Rename "SVNPATH" to "GITBRANCH" since that seems more appropriate. Rename "svnversion.h" to "version.h" as Evan suggested. Update some URLs. In make-version.pl, make sure we don't set an improper upstream branch name. Use the number of commits + short hash from `git describe` for package names by default. Change-Id: I922bba8d83eabdf49284a119f55b4076bc469b96 Reviewed-on: https://code.wireshark.org/review/139 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-02-07Fix Bug 9728 'Lua: ProtoField.bool() VALUESTRING argument is not optional ↵Hadriel Kaplan3-15/+33
but was supposed to be' Similar to bug 9725 and ProtoField.new(), the way the VALUESTRING argument is being checked in the code for ProtoField.bool() ends up making it non-optional. This patch fixes that, along with some minor API documentation fixes (text). Change-Id: Iadb9a8ace9c5514fc623d882301fe16b637fe4ce Reviewed-on: https://code.wireshark.org/review/125 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-07Parse SIP sec-mechanismPascal Quantin1-3/+211
From Anders Broman: parse security mechanism as specified in RFC 3329 Change-Id: I37300aa45740a11679149550943b3a1614ac8423 Reviewed-on: https://code.wireshark.org/review/138 Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Anders Broman <a.broman58@gmail.com>
2014-02-07Register SSH dissector by namePascal Quantin1-4/+4
Change-Id: Ia9ad45ce9196486129897cd616707d622778e9dd Reviewed-on: https://code.wireshark.org/review/137 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-07Qt 5.2.1 - now with added native OS X toolbar!Guy Harris1-2/+1
To quote https://qt.gitorious.org/qt/qtbase/source/62feb088a30045e7fbd2a3074c64d18035b84a97:dist/changes-5.2.1 "**************************************************************************** * Platform Specific Changes * **************************************************************************** ... OS X ---- - [QTBUG-34411] Implemented QMainWindow::setUnifiedTitleAndToolBarOnMac." Also get rid of a commented-out setting of QT_VERSION to 5.1.1 while we're at it. Change-Id: I957fdfecb70954723cfd3160f40758f722dc56c8 Reviewed-on: https://code.wireshark.org/review/136 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-06Fix Bug #9690: DHCPv6 Packet dissector incorrectly handling FQDN in option ↵Bill Meier1-10/+6
17.2171.6 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9690 Change-Id: I606bb73f4a226cbf1eb56cc0a27b926b97a453a0 Reviewed-on: https://code.wireshark.org/review/131 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-02-06Extend RTMPT video types tableGregor Jasny1-0/+8
Change-Id: Ic97edfa64bb2d69b97295564e2f11cd07a0fe54c Reviewed-on: https://code.wireshark.org/review/129 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-06Make some routines take a struct wtap_pkthdr * as an argument.Guy Harris10-154/+146
For some routines that take multiple arguments that come from a struct wtap_pkthdr, pass a pointer to the struct wtap_pkthdr in question, rather than the separate arguments. Do this even if we're passing expressions that were earlier assigned to the struct wtap_pkthdr fields in question. This simplifies the calling sequences and ensures that the right values are picked up by the called routine; in at least one case we were *not* passing the right values (the code to handle Simple Packet Blocks in pcap-ng files). Also, call the byte-swapping routines for pseudo-header fields only if we need to do byte-swapping. Change-Id: I3a8badfcfeb0237dfc1d1014185a67f18c0f2ebe Reviewed-on: https://code.wireshark.org/review/119 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-06Convert the user interface chapter to AsciiDoc.Gerald Combs4-256/+214
Start mentioning Qt. Update and add HIG links. Change-Id: Iac984045b03a96862981d58ff63c9ee6bcdbbce8 Reviewed-on: https://code.wireshark.org/review/127 Tested-by: Wireshark Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-02-05Introduce end-of-line normalizationPascal Quantin31-1485/+1486
Change-Id: Ie6991af2432b193fbdc23bbbd335f83c091f14e8 Reviewed-on: https://code.wireshark.org/review/114 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-05use the right src dir in git command for svnversion.hdidier1-5/+5
make-version.pl wasn't using the right source dir for git commands when not compiling from inside source tree. add --git-dir=$srcdir/.git parameter. Change-Id: I45ca4874d96abaed1c559c022d0ace66239652c8 Reviewed-on: https://code.wireshark.org/review/122 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-05Two fixes for license headersEvan Huus2-40/+36
- packet-bencode.c had the wrong FSF address - wslua_int64.c had the license as a footer instead of a header Change-Id: I71204b36a1034af72874d6fe87929c31c9ff03df Reviewed-on: https://code.wireshark.org/review/123 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-05Dissector assert in packet-nbap.c. num_items isn't reset before calling a ↵Anders Broman2-19/+29
sequence filling the array. Closed-bug #9726 Change-Id: Ie4bc538b0788eb32895c9eedf8e0277c6d9ed1b2 Reviewed-on: https://code.wireshark.org/review/120 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Anders Broman <a.broman58@gmail.com>
2014-02-05Add Aruba Intant AP dissectorAlexis La Goutte4-2/+167
There is no public spec, based only on analyze of packet It is more easy to found the address IP of Intant AP Change-Id: I3baf205c5e4ad699b954f4a9fbf4b9e65f82cb36 Reviewed-on: https://code.wireshark.org/review/121 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-05Fix Bug 9725 'Lua: ProtoField.new() is buggy'Hadriel Kaplan1-2/+3
Using ProtoField.new() is dicey. Many of the optional arguments don't properly check the lua stack - they call lua_isnil() for their index number, instead of lua_gettop() to see the stack size. lua_isnil() may return false in such cases. Change-Id: I83ca1e5fc34e71ec35899adbedabcee69571b9fe Reviewed-on: https://code.wireshark.org/review/118 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-05Fix wslua docs script to handle module names with digits, like Int64/UInt64Hadriel Kaplan1-1/+1
The fix in commit 28e028ddd5579c3d405b21523cdc2773c798e32f missed the module name, which was only grabbing alphabetic characters not numbers. This fixes that oversight. Change-Id: I65a87279024a81b33a8deb83b7a3573ea6eaf139 Reviewed-on: https://code.wireshark.org/review/117 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-04Fix bug 9720 'Lua: bitop library is missing in Lua 5.2'Hadriel Kaplan1-1/+3
In Lua 5.2 the bitop library is missing - it's not getting loaded into the lua global table as "bit", or anything else for that matter. Lua 5.2 has its own bit-operations library ("bit32") which is there, but that one's not as good as bitop and would break back/forward compatibility for lua scripts anyway. Change-Id: I94b7d45bbeb2f637d1c76b0b5c9d8472eebfcaea Reviewed-on: https://code.wireshark.org/review/100 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-04Fix dissection of GTP MM Context RAND field.Evan Huus1-1/+1
As suggested by Lükő Bálint to fix bug #9722. Change-Id: I177f7632a0936f105b1acff5e7c20bcce2328957 Reviewed-on: https://code.wireshark.org/review/109 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-04Split out bencode dissector and use it in the bzr dissector.Jelmer Vernooij5-303/+344
Change-Id: I5b2ef173faf7670fad64298d67f2aaf055b8d6d8 Signed-Off-By: Jelmer Vernooij <jelmer@samba.org> Reviewed-on: https://code.wireshark.org/review/82 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-04Bluetooth: btle: Make RxAdd field reserved in some casesMichal Labedzki1-2/+17
Specification: "If the TxAdd or RxAdd fields are not defined as used in a given PDU then they shall be considered Reserved for Future Use." Change-Id: I767c0df0366afe789624046cda2d49c9875ffe60 Reviewed-on: https://code.wireshark.org/review/103 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-04Bluetooth: AVDTP: Fix offset in case with Error CodeMichal Labedzki1-0/+13
Change-Id: I6e97781bfd1775dcc13c4488af11d615ef6594fb Reviewed-on: https://code.wireshark.org/review/102 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-04Fix indent (Remove tabs and use 4 spaces)Alexis La Goutte1-19/+19
Change-Id: Ide617723ffbe0c813f08b44804cd4ca52884a875 Reviewed-on: https://code.wireshark.org/review/107 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-04Fix indent (Remove tabs and use 4 spaces)Alexis La Goutte2-16/+16
Change-Id: Ide85336be3dca4059619bb91707bfc49e25af63d Reviewed-on: https://code.wireshark.org/review/108 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-04Fix indent (Use tabs)Alexis La Goutte1-21/+21
Change-Id: I5c16950394915091a1dfb76e480ae7f2cba53e3f Reviewed-on: https://code.wireshark.org/review/106 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-04USB: Fix Linux header byte-orderMichal Labedzki2-39/+26
Linux USB Header should be in Host Endian. Also add ENC_HOST_ENDIAN to simplify code. Change-Id: I95e7d97014633e8fc1d7739d0728780d70c60442 Reviewed-on: https://code.wireshark.org/review/15 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-04asn2wrs: Rewrite relative paths in header.Stig Bjørlykke1-3/+4
Change both absolute paths and relative paths generated outside source directory to paths relative to asn1/<proto> subdir. Change-Id: I867d3a31c687b08347b11336ce69fc70db2d7c7b Reviewed-on: https://code.wireshark.org/review/88 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-04Fix wslua docs script to handle class names with digits, like Int64/UInt64Hadriel Kaplan1-7/+7
Change-Id: I555e4401828680cc8d6516b11af21d2ae5c0144d Reviewed-on: https://code.wireshark.org/review/99 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-04Various fixes to the Lua int64 codeEvan Huus3-12/+22
- add casts to pacify certain buildbots - skip test if lua isn't available Change-Id: I614c05dca40cb848c87b361e4b3d3c4e94aafb9e Reviewed-on: https://code.wireshark.org/review/97 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-04Adds support for Lua Int64 and UInt64 operators, functions, and generalHadriel Kaplan16-120/+1306
usefulness, working around bug #9162 until Lua 5.3 is released. The existing Int64 and UInt64 classes provide virtually no usefullness, other than for creating a string of their value. While one could then write Lua code to convert the string to Lua numbers and such, ultimately Lua has no native 64-bit integer support, making such a task difficult to handle in Lua. This change adds a host of functions and operators to the existing Int64 (gint64) and UInt64 (guint64) classes, to enable true 64-bit integer support on par with native Lua numbers. A test script is also provided, which tests the functions/operators. Change-Id: I4c5f8f5219b9a88198902283bd32ddf24c346bbe Reviewed-on: https://code.wireshark.org/review/83 Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-03Don't use newer shell features, as we now just use /bin/sh.Guy Harris1-4/+9
/bin/sh in Solaris 10, for example, doesn't understand "${OS#Windows}", so using /bin/sh broke the Solaris build on the buildbot. Use a case statement instead. Change-Id: Icdec74599c339e19ef6ffc7728f4ae2d5cf98999 Reviewed-on: https://code.wireshark.org/review/96 Reviewed-by: Guy Harris <guy@alum.mit.edu> Tested-by: Guy Harris <guy@alum.mit.edu>
2014-02-03Upgrade RRC dissector to v11.8.0Pascal Quantin7-69/+408
Change-Id: If43fc7ec8b5f997e573a9d84fda03f2ca2bf6dc7 Reviewed-on: https://code.wireshark.org/review/94 Tested-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-03Convert the dissection chapter to AsciiDoc.Gerald Combs4-1211/+1142
Change-Id: Ieccd2ad235576b9ec6013ddb23a8373ccf2f8cdf Reviewed-on: https://code.wireshark.org/review/92 Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org>
2014-02-03Don't pass tvb_get_ptr to proto_tree_add_stringEvan Huus1-4/+1
If the string doesn't end with a null-terminator in the given length it causes a read-overflow. Should fix bug #9717. Change-Id: I44647ef8ecb856e07d1175777ed603736ec63553 Reviewed-on: https://code.wireshark.org/review/90 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-03allow tshark reading from pipesPeter Hatina2-2/+3
Change-Id: If20a14b949667911df44f09c6a705b7645d4c49e Reviewed-on: https://code.wireshark.org/review/85 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-03Add a cast to fix g4cc694839d.Evan Huus1-1/+2
Apparently very recent gcc versions *do* complain about the cast from gint to enum, despite the comment to the contrary. Change-Id: I422df9950f1c7c46ca8ea37a0e3abd7aa8fc1c7d Reviewed-on: https://code.wireshark.org/review/89 Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-02-03Fix (-W)documentation found by ClangAlexis La Goutte1-64/+64
Convert comment to doxygen type Change-Id: Ib7adc2ece99dc4baa8ec3a349896dfa89277e00b Reviewed-on: https://code.wireshark.org/review/84 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-03Fix one -fstrict-alias warning missed in g4cc69483Stig Bjørlykke1-1/+1
Change-Id: I99aa593c188ca77dd20dba8e4305cc9ffdf50416 Reviewed-on: https://code.wireshark.org/review/87 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-03Apply g4cc69483 to asn1 templates.Stig Bjørlykke5-6/+6
Change-Id: Id44ef17e7293be5d713c5e9e5d55b25194b46016 Reviewed-on: https://code.wireshark.org/review/86 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-02-03Fix all -fstrict-alias warnings found by gcc 4.1.2Gilbert Ramirez43-48/+87
The majority of the fixes are for calls to uat_new(). Instead of having each caller cast its private data to (void**), we use void* in the uat_new() API itself. Inside uat_new(), we cast the void* to void**. Some dissectors use val64_string arrays, so a VALS64() macro was added for those, to avoid using VALS(), which is useful only for value_string arrays. packet-mq.c was changed because dissect_nt_sid() requires a char**, not a guint**. All other callers of dissect_nt_sid() use char*'s (and take the address of it) for their local storage. So, this was changed to follow the other practices. A confusion between gint and absolute_time_display_e in packet-time.c was cleared up. The ugliest fix is the addition of ip6_guint8_to_str(), for exactly one caller. The caller uses one type of ip6 address byte array, while ip6_to_str() expects another. This new function is in place until the various address implementations can be consolidated. Add VALS64() to the developer documentation. Change-Id: If93ff5c6c8c7cc3c9510d7fb78fa9108e4552805 Reviewed-on: https://code.wireshark.org/review/48 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-02QUIC dissector : Update from last Design Document and Specification (12/2/2013)Alexis La Goutte1-31/+31
Changed “GUID” to “CID” (Connection Identifier), as the original term carried common meaning and baggage that was not intended Change-Id: I04986331aee33be237dab6963c0ff39accf507cd Reviewed-on: https://code.wireshark.org/review/81 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-02Install SVG icon.Ville Skyttä1-0/+2
Closes-Bug: #9590 Change-Id: I20b29ccc4237434c4a3d11615fc2cad832c3c685 Reviewed-on: https://code.wireshark.org/review/80 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-02Fix dissector exception when GUID is empty in flagsPeter Wu1-2/+4
When the GUID (CID or Connection Identifier in a more recent spec) field in Public Flags is 0, a zero-length item would be added. This trivial patch prevents a dissector exception by checking the length first. Change-Id: Idf6d970bc1b0b3f1a8e47618a8759f6a0cd54c65 Reviewed-on: https://code.wireshark.org/review/78 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-02Convert three more WSDG chapters: works, build, and capture.Gerald Combs9-329/+259
Start adding references to Qt and wsutil. Fix a file extension in CMakeLists.txt. Change-Id: I0cbe7e802d88a05effff40b5de72669e22c0df53 Reviewed-on: https://code.wireshark.org/review/79 Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-18 04:37:12 +0000