aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-07-20epan,packaging: convert http URLs to httpsPeter Wu10-20/+19
Ensure that public text in error messages and dialogs point to https. Ensure that the generated PDML files include scripts over https. Change-Id: I75d42704c2bbb33b05492261b3e1d45dc6e301f9 Reviewed-on: https://code.wireshark.org/review/34027 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-20copyright_info: convert GPL-2.0 URL to HTTPPeter Wu1-2/+2
Use a shorter URL and use HTTPS. Change-Id: I9cfcd52775c95457e81694272dbe795d4eae4e58 Reviewed-on: https://code.wireshark.org/review/34026 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-20Fix -Wpointer-sign warning.Guy Harris1-1/+9
Change-Id: I8e74e90f1383f01633343cd6e72ac2193bfb3e04 Reviewed-on: https://code.wireshark.org/review/34029 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-20smtp: add credentials to the tap.Dario Lombardo1-2/+31
Change-Id: I85afccd7e05efd9d293d6b8c1b5702faf8d34b14 Reviewed-on: https://code.wireshark.org/review/33764 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-20wiretap: candump: Don't generate a temporary PCAP fileMaksim Salau4-248/+149
It's preferable to parse text files and generate packets on demand, rather than generate a temporary PCAP file and dump all available packets into it. Parsing on the fly has a benefit of handling damaged files up to the point of damage, while the approach with a temporary file doesn't allow either to report that the original file is damaged or perform conversion in the first place. This version works faster than the previous one. Command: time ./run/tshark -r ./candump-2019-07-01_111120.log.gz > /dev/null The test file is attached to the bug 15889 The current version: real 0m0,597s user 0m0,533s sys 0m0,118s The previous version: real 0m2,176s user 0m1,966s sys 0m0,100s Bug: 15889 Change-Id: I862ce47752531c2e9d9459f5d865c1fc08f32fea Reviewed-on: https://code.wireshark.org/review/34007 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-19Clean up the handling of the "friendly name".Guy Harris1-77/+51
Fetch it by adding it with proto_tree_add_item_ret_display_string(), and then use the resulting displayable string to append to columns and protocol tree items. Given that the string in question is ISO 8859-1, according to the KNXnet/IP spec, and that it must therefore be converted to UTF-8, that's the right thing to do. Use wmem string buffers to hold the strings to append - using a fixed-length buffer isn't a good idea when you are dealing with UTF-8 strings, as you might cut a UTF-8 sequence short in the middle. Don't consruct strings that we never use. While we're at it, give a URL to find KNX specifications. Change-Id: Ibec4f6c83a62e141bd8ce0e5dfd7dd45ff627fe4 Reviewed-on: https://code.wireshark.org/review/34024 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19Use proto_tree_add_item_ret_display_string() to add string items.Guy Harris1-4/+2
It does all the work done by the calls it replaces, *and* it takes an encoding argument, so the string data is converted, if necessary, to UTF-8. (Not necessary in this case, at least as I read the protocol spec, but it's the right thing to do in any case.) Plus, as we're using proto_tree_add_item_ret_display_string(), the string we're displaying will be in a displayable format. Change-Id: I7f5e46dcdbb8f3d3749ef539a31f6208371b72cd Reviewed-on: https://code.wireshark.org/review/34022 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19Provide only one data rate per user for VHT frames.Guy Harris1-8/+0
Don't provide an extra not-per-user data rate equal to the data rate for the highest user number; that makes no sense. Bug: 15928 Change-Id: Ie6bf5853d630bbf33afd423dc7a8eca26abdf83a Reviewed-on: https://code.wireshark.org/review/34018 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-19XnAP: upgrade dissector to v15.4.0Pascal Quantin15-273/+921
Change-Id: Ia26593e7895709671a7a9d4a51bb6788e4059c94 Reviewed-on: https://code.wireshark.org/review/34015 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19pop3: add credentials to tap.Dario Lombardo1-33/+74
Change-Id: I0779a4c11451ee63be8d10ee78a7f920f519f77a Reviewed-on: https://code.wireshark.org/review/33799 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19imap: add credentials to tap.Dario Lombardo1-0/+13
Change-Id: I6858e66dcda643a97e9f1b29b62edc5ceb8af064 Reviewed-on: https://code.wireshark.org/review/33765 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19imap: dissect username and password from LOGIN command.Dario Lombardo1-0/+26
Change-Id: I84ff13cdda7af60bb6ce588b7ec3bccb1911ee97 Reviewed-on: https://code.wireshark.org/review/33756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-19Qt: Improve profiles import UIRoland Knall3-37/+101
This also allows for profile zips to have a different structure, and only directories containign actual configuration files will be part of the import - Choosen path sticks and starts with current application path - "Default" can no longer be imported as a profile - skipped profiles count is being displayed Change-Id: I0549a1ae81229940e573674a84f2912119d6ee21 Reviewed-on: https://code.wireshark.org/review/34013 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-19NGAP: upgrade dissector to v15.6.0Pascal Quantin9-575/+888
Change-Id: Iac53380ba1a6ba105103db7104d44688bbbe383d Reviewed-on: https://code.wireshark.org/review/34014 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-19Qt: Delete copied profile properRoland Knall1-6/+12
If a profile is a copy of another profile and get's deleted without being saved, the original profile got deleted Change-Id: Iffccb2e29131f97ad6fe71362946aad4e076eb3f Reviewed-on: https://code.wireshark.org/review/34011 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-19dhcp: fix memleak on exceptions in dissect_dhcpopt_avaya_ip_telephonePeter Wu1-5/+3
Do not use g_malloc, it leaks when accessing the tvb throws an error. Change-Id: I5c6515da2184e2bea496d352461784cf845c3e18 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15673 Fixes: v3.1.0rc0-136-gc28d8f937a ("packet-dhcp.c: Fix modification of a const char* string") Reviewed-on: https://code.wireshark.org/review/33999 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-19CoAP: add frame support for CoAP over TCP, TLS, WebSockets (RFC 8323)Peter Wu1-29/+136
Support is limited to message framing. Bug: 15910 Change-Id: Ia27c0b8428842618af00720441a9ef9cf163fecb Reviewed-on: https://code.wireshark.org/review/34001 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-18Qt: Profile Dialog UI fixedRoland Knall2-0/+13
Enter on dialog closes dialog only if filter textbox is not focused Change-Id: I2d75c737ab2bd480f353340506be756edad5a9b9 Reviewed-on: https://code.wireshark.org/review/34010 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-18Qt: Use correct name for copyRoland Knall1-1/+1
If the element to copy from has already been renamed, use the new (not yet saved) name Change-Id: I868c8ba18566adf9fbad4f1e42a22bdcd9fcbe99 Reviewed-on: https://code.wireshark.org/review/34012 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-18Qt: Profile import button shall not be smallStig Bjørlykke1-2/+1
Don't set attribute Qt::WA_MacSmallSize on the Profile import button. Also fix a typo: occured -> occurred. Change-Id: Id14001e71605bab97fe8ac3f14ecbc8242bdda17 Reviewed-on: https://code.wireshark.org/review/34008 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-18CMake: Use tab for indentationStig Bjørlykke1-1/+1
Change-Id: I9d08443169f6b0b87c37ff20babffee1e6769ae7 Reviewed-on: https://code.wireshark.org/review/34009 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-07-18profile_model.cpp: add a missing breakPascal Quantin1-0/+1
Change-Id: I08f6f0f02a637a1b6c532b5e41396f5ebcd1ed99 Reviewed-on: https://code.wireshark.org/review/34003 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-18CoAP: add CoAP Signalling Codes (RFC 8323)Peter Wu1-15/+23
Update names and RFC references based on the IANA registry at https://www.iana.org/assignments/core-parameters/core-parameters.xhtml Bug: 15910 Change-Id: I56a4cc3c23fee321b09547254a33f6a76d46cc9d Reviewed-on: https://code.wireshark.org/review/34002 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-18fuzzshark: add usage documentationPeter Wu1-3/+41
For those running the 'fuzzshark' binary directly, try to show some helpful usage information instead of crashing with an assertion failure. This does not affect the oss-fuzz builds which use the 'fuzzshark_*' targets instead of the 'fuzzshark' one. Change-Id: I3eeb64f416a30abc7aee18a0d4505d4e8de446ce Reviewed-on: https://code.wireshark.org/review/33998 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-18Qt: Fix various issues for profile managerRoland Knall6-44/+133
- Fixing the fact, that the profile did not allways switch to the active profile when pressing the OK button. - Adding a new profile can be repeated, if the name "New Profile" is already in use, a number is incremented and added to subsequently new profiles. - Copying a profile multiple times, creates individual names each time - Global profiles should come last in the statusbar popup - Global profiles should be called "System profiles" - Fix null-pointer that could happen while querying "DATA_IS_SELECTED" - Renaming an existing profile was not correctly indicated - Renaming the currently selected profile works now Change-Id: Ifa47fd672a6976c07d3e80741cfd61b548a5e1f8 Reviewed-on: https://code.wireshark.org/review/33921 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-18ZigBee: Add Address fieldsKenneth Soerensen1-1/+25
Change-Id: I8b2f2b682f46b85230649e852f3fa70af6d237ef Reviewed-on: https://code.wireshark.org/review/33992 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-18ZigBee: Correct namingKenneth Soerensen1-3/+3
Change-Id: Ide220a1899bba6327dc7fbfcc3ac9ac0113b929f Reviewed-on: https://code.wireshark.org/review/33991 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-18QUIC: fix out-of-bounds write due to missing CID length checkPeter Wu1-7/+11
The length was previously increased to max 255, but v1 limits it. Be sure to check the bounds before doing anything. Bug: 15919 Change-Id: I2ed8469d882d5ac2dc4c21e3f5486534e4bf32e6 Fixes: v3.1.0rc0-1289-g3967f60e45 ("QUIC: update for new Connection ID Lengths (draft -22)") Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15936 Reviewed-on: https://code.wireshark.org/review/34000 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-18Don't just grab raw string data with tvb_memcpy().Guy Harris1-17/+71
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column, and just use proto_tree_add_item() if we don't need the string's value. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and, if necessary, are formatted for display. Add comments asking about encodings. Change-Id: I32dbdf17c90e77cc080d6132c740c8c5d19ef4c5 Reviewed-on: https://code.wireshark.org/review/33997 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Clean up comments.Guy Harris1-9/+1
VisibleString does, in fact, mean ASCII in PROFINET. Put a space after a comma. Change-Id: I0b9da9599ddd5429736dff598e5c37e9cac88bc6 Reviewed-on: https://code.wireshark.org/review/33996 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Qt: Import Profile informationRoland Knall19-41/+422
Allow easy import of profiles. Profiles must be stored inside a zip file, with no additional hierarchy. Change-Id: I0ae77460c20ef6b3e447906e671b0cefa6b9b032 Reviewed-on: https://code.wireshark.org/review/33881 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-125/+58
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column, and just use proto_tree_add_item() if we don't need the string's value. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and, if necessary, are formatted for display. Add comments about fields that have type VisibleString, asking whether that means "ASCII" or "just the "Basic" part of ISO 646", where the latter is ENC_ISO_646_BASIC. Add a comment about fields using "The definition of IETF RFC 5890" - that means "Punycode", but I don't think we map Punycode to Unicode; perhaps we should. Also ask whether that also implies RFC 1035's encoding of domain names as sequences of counted strings. Change-Id: Ie8d5bc18d2846f8d723019b22f69a50ce55f9a9b Reviewed-on: https://code.wireshark.org/review/33986 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17tvbuff_lz*: fix typo in commentAurelien Aptel3-9/+9
Change-Id: Id2b36454e678151ea5948f8e068ef400dd562188 Reviewed-on: https://code.wireshark.org/review/33985 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Fix signedness warnings.Guy Harris1-4/+4
Change-Id: I2a0d6f6e73c56eb3b531d6e805c9db435ceb72e7 Reviewed-on: https://code.wireshark.org/review/33983 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Couchbase: Fix dissector for dcp prepareTrond Norbye1-2/+1
The timeout value was removed from the DCP PREPARE message as it was never used (and will never occur in a released version of Couchbase) Change-Id: I95f5bb3a0878237bf0339da48476fda437740c25 Reviewed-on: https://code.wireshark.org/review/33984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Jim Walker <jim@couchbase.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-07-17Clean up string handling.Guy Harris1-42/+116
Use tvb_get_string_enc() routines to fetch strings; all strings must have an encoding value, to properly map to UTF-8. Use format_text() when displaying string values in columns. Show the interpretation of "character set" values. Choose the encoding value based on the "character set" value. While we're at it, use the XDLC_S_U_MASK #define, rather than a raw hex value, when testing for S frames vs. U frames. Change-Id: Idf9d6302473bbffdfa67341c381575aa525a6d84 Reviewed-on: https://code.wireshark.org/review/33982 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17BGP: Update description for IE Flag (EVPN IGMP)Uli Heilmeier1-2/+2
Ping-Bug: 15911 Change-Id: I2607eb96e8a217451a493a301dc06b56a4db3081 Reviewed-on: https://code.wireshark.org/review/33966 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-17ceph: remove unnecessary ifdef G_STATIC_ASSERT checkPeter Wu1-2/+0
Supported since GLib 2.20, we require at least 2.32. Change-Id: I0bdeaaaf11dad5352aa2f6e4dc9e23be9dc93e3a Reviewed-on: https://code.wireshark.org/review/33977 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17capchild,ifaces: use g_get_monotonic_timePeter Wu2-25/+12
Simplify timing code by relying on g_get_monotonic_time which has the additional benefit that it is unaffected by clock jumps. Change-Id: Ib61b848eb5e20d68d486a07e3528ccafb03f8814 Reviewed-on: https://code.wireshark.org/review/33976 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17file: remove use of g_get_current_timePeter Wu4-47/+21
Replace g_get_current_time by g_get_monotonic_time (since GLib 2.28, we require 2.32) to simplify code and ignore time jumps. Qt does not need the elapsed time, so remove the parameter from the progress callback. Change-Id: Icaad4b909b9cb4bb07d28fcdf3d383d64aa00127 Reviewed-on: https://code.wireshark.org/review/33975 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-25/+15
Use tvb_get_string_enc() to fetch strings. That way, all strings are fetched using an encoding value, to properly map to UTF-8. While we're at it, add the RFC for the final version of the protocol. Change-Id: If103d9464a313bd61948b931291a3763ea85d01b Reviewed-on: https://code.wireshark.org/review/33981 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-17Don't just grab raw string data with tvb_memcpy().Guy Harris1-4/+10
Use tvb_get_string_enc() routines to fetch them; all strings must have an encoding value, to properly map to UTF-8. While we're at it, fix heuristic test to make sure we have a full TALI header in the *captured* data. Change-Id: Ia572707f8d7da89d3fe31e839e1cbe4dc5e23c43 Reviewed-on: https://code.wireshark.org/review/33980 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Ask in a comment about DNS-style domain names.Guy Harris1-0/+8
Change-Id: Idcf5ed5db1d04f48849e458d85c3a04e6d1d8d43 Reviewed-on: https://code.wireshark.org/review/33979 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Don't just grab raw string data with tvb_memcpy().Guy Harris1-23/+23
Use proto_tree_add_item_ret_display_string() routines to add strings if we want to display the string's value in a column. That way, all strings are fetched using an encoding value, to properly map to UTF-8, and are formatted for display. Change-Id: I4acd9ed7cfad3342be84a4773187dd531949f47b Reviewed-on: https://code.wireshark.org/review/33974 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16Clean up handling of the command parameter.Guy Harris1-36/+35
It's an unsigned int, as per the protocol spec. Treat it as such. (Add a URL for the protocol spec while we're at it.) Convert it from a string of ASCII hex digits to a number using ws_hexstrtou32(); that routine does the appropriate checks. Clean up blank lines while we're at it - add some and remove some. Change-Id: I2c0832c4a57c121e2e64de49a8678b747025f35e Reviewed-on: https://code.wireshark.org/review/33972 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16X2AP: upgrade dissector to v15.6.0Pascal Quantin9-526/+839
Change-Id: Iffa23a10350ad8ef765401b50373a7d6aaf5d2bf Reviewed-on: https://code.wireshark.org/review/33971 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-16tvb_lz77huff: reduce stack memory usageAurelien Aptel1-15/+19
clang errs about the stack frame size being too big. * use indexes instead of pointers * use guint8 instead of gboolean (== int) * remplace hard coded 512 with #define Change-Id: Idae70677f20e88ac8bba93899573e0137b9a3d7e Fixes: 0db39ae59a ("smb2: add support for decompression") Reviewed-on: https://code.wireshark.org/review/33965 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-07-16Don't just grab raw string data with tvb_memcpy().Guy Harris6-45/+29
Use proto_tree_add_item...() routines to add strings; use tvb_get_string_enc() to extract strings. That way, all strings are fetched using an encoding value, to properly map to UTF-8. Change-Id: I2118e812965cfad5d8c288ea40fa50aca9c67fa8 Reviewed-on: https://code.wireshark.org/review/33970 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-16gvcp, gvsp, u3v: GEV 2.2, new PFNC pixel formatsStefan Battmer3-219/+1503
- Added the full GigE Vision 2.2 feature set including GenDC, extended bootstrap registers and new capability and configuration bits - Fixed typos - Added all the latest pixel formats as defined by the PFNC standard document to the gvcp, gvsp and u3v dissector Change-Id: Ic60f0252caef99b222262e96e3f2296c9fccccad Reviewed-on: https://code.wireshark.org/review/33898 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-16capture_sync: fix empty paragraph passed to '@param' command [-Wdocumentation]Alexis La Goutte1-1/+1
Change-Id: Ia98a912f4b1992ec4e65eec1107a5483ba4708eb Reviewed-on: https://code.wireshark.org/review/33962 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-09 03:12:31 +0000