aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-02-09From Sean Bright via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6815 :Jeff Morriss1-1/+1
Don't use tvb_get_ptr() to retrieve a string being sent into proto_tree_add_string_format(): use tvb_get_ephemeral_string() instead. svn path=/trunk/; revision=40944
2012-02-09From Wido Kelling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6819 :Jeff Morriss1-75/+75
Patch to fix channelproperty Maintanance decode. svn path=/trunk/; revision=40943
2012-02-09Eliminate a C++/C99-style comment.Jeff Morriss1-2/+2
svn path=/trunk/; revision=40942
2012-02-09Add tvb_ip_to_str and tvb_ip6_to_str to the Dev GuideAlexis La Goutte1-0/+6
svn path=/trunk/; revision=40941
2012-02-09Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-11/+10
svn path=/trunk/; revision=40940
2012-02-08From Steve Magnani:Anders Broman1-6/+6
USB: Endpoint bmAttributes not decoded correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6814 svn path=/trunk/; revision=40939
2012-02-08Write address resolution block.Anders Broman1-1/+4
svn path=/trunk/; revision=40938
2012-02-08From a.piesk:Anders Broman1-0/+1
no menu item Fle->Export->SSL Session Keys in GTK Ported to 1.7 by me. #BACKPORT Use the patch in the bug report. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6813 svn path=/trunk/; revision=40937
2012-02-08From Harald Welte:Anders Broman1-1/+9
GSMTAP: add new GPRS/EGPRS RLC related sub-types https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6812 svn path=/trunk/; revision=40936
2012-02-08From Harald Welte:Anders Broman1-3/+3
GSMTAP: whitespace / indent cleanup https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6811 svn path=/trunk/; revision=40935
2012-02-08From Harald Welte:Anders Broman2-5/+11
GSMTAP dissector: introduce a dissector table. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6810 svn path=/trunk/; revision=40934
2012-02-08When building QtShark on Windows: Don't (re)compile Wireshark .c filesBill Meier1-45/+56
svn path=/trunk/; revision=40933
2012-02-08From Sylvain Munaut:Anders Broman2-16/+117
Fix the windows build by filling up stuct with dummy member https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6798 svn path=/trunk/; revision=40932
2012-02-08Fix set-but-not-used warnings turned errors.Jörg Mayer1-4/+4
svn path=/trunk/; revision=40931
2012-02-08As suggested by Joerg on the -dev list yesterday: count up the number ofJeff Morriss1-1/+39
proto_tree_add_text() calls and compare that to the number of proto_tree_add_<something else>() calls and complain if more than 50% of the calls are add_text()'s. proto_tree_add_text() calls whose returned proto_item is used are not counted as hanging a subtree off a text item is an appropriate use for text items. I chose 50% because even at that level there are many dissectors with "too many" proto_tree_add_text()'s. The function to do all of this is commented out for now for the same reason plus the fact that it's pretty slow. svn path=/trunk/; revision=40930
2012-02-08Fixed bug with calculation of bytes in flight.Graham Bloice1-0/+5
A corner case was posted to the Q&A site showing incorrect calculation of bytes in flight (http://ask.wireshark.org/questions/8843/bytes-in-flight-problems-with-retransmissions) The capture in question has a tcp segment (frame 12) that is a retransmission of unacked earlier data (frames 4, 9, 10) and also contains some new data. Eventually an ACK is received for the earlier segments (frame 16) but the code doesn't remove frame 12 from the linked list of unacked segments because it extends past the received ACK. When more data is received in frame 17, the bytes in flight is calculated from the start of frame 12 rather than from the unacked portion of it, leading to a larger incorrect value. The change simply updates the starting sequence number in the unacked segment list for any partially acked segment to be the start of unacked data. The capture in question now shows correct information for bytes in flight, and hopefully the nature of the change won't cause issues elsewhere. svn path=/trunk/; revision=40929
2012-02-08Fix reporting of duplicate IP addresses by creating a hash table ofMartin Mathieson1-60/+115
results when first visited. svn path=/trunk/; revision=40928
2012-02-08Disable the File->Merge... menu item if we cannot save-as,Stig Bjørlykke1-1/+1
because this will assert. svn path=/trunk/; revision=40927
2012-02-08Small whitespace fix.Jörg Mayer1-3/+3
svn path=/trunk/; revision=40926
2012-02-08Last fix to the wrong approach.Jörg Mayer1-0/+1
svn path=/trunk/; revision=40925
2012-02-08From Sylvain Munaut:Anders Broman3-0/+1403
Add support for GMR-1 BCCH dissection. I #if 0'd out incomplete code. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6798 svn path=/trunk/; revision=40924
2012-02-08Heuristic standard detection:Jeff Morriss1-0/+12
- Grab optional parameters for LUDT/LUDTS - Fix processing of the 2-octet pointers svn path=/trunk/; revision=40923
2012-02-07From Guy Martin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6795 :Jeff Morriss1-4/+0
Remove some duplicate checks. svn path=/trunk/; revision=40922
2012-02-07Initialize felica_tree to NULL to avoid a false warning.Chris Maynard1-1/+1
svn path=/trunk/; revision=40921
2012-02-07Make some minimally required changes as pointed out in bug6758[1].Chris Maynard1-153/+159
In addition: -> I didn't think using tvb_new_subset_remaining() in order to iterate through the blocks was the best way to implement this, so I changed it to the method I had proposed earlier[2]. -> Some whitespace cleanup. -> Noted some "TODO"'s for potential further improvements. [1]: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6758#c9 [2]: http://article.gmane.org/gmane.network.wireshark.devel/24721 svn path=/trunk/; revision=40920
2012-02-07Fix the fuzz failure reported in in ↵Jeff Morriss1-9/+21
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6799 : Ensure that the payload length handed to the reassembly routines doesn't go negative/very-large-positive. svn path=/trunk/; revision=40919
2012-02-07small whitespace fixJörg Mayer1-1/+1
svn path=/trunk/; revision=40918
2012-02-07Initiliase another variable.Martin Mathieson1-1/+1
svn path=/trunk/; revision=40917
2012-02-07Initialise a variable to avoid warning.Martin Mathieson1-1/+1
svn path=/trunk/; revision=40916
2012-02-07packet-gsm_sim.c was the wrong file to check in.Jörg Mayer2-7/+6
I meant ui/gtk/voip_calls_dlg.c. svn path=/trunk/; revision=40915
2012-02-07Fix "variable set but not used" warnings turned error. In at leastJörg Mayer2-17/+20
one case this looks like a logic bug and should be investigated. svn path=/trunk/; revision=40914
2012-02-07Make sure that we only have to set (or pick up) the docdir environmentJörg Mayer1-1/+1
variable on the initial cmake run and not on later re-runs (like when some cmakelists.txt file changed and we call make). Of course this value should really be passed as an option instead of an environment variable but I want to document how to get the current approach working properly before switching to the proper approach. svn path=/trunk/; revision=40913
2012-02-07Allways use g_list_prepend().Anders Broman1-16/+16
svn path=/trunk/; revision=40912
2012-02-07Update the documentation to match the sort order. This documentation error ↵Chris Maynard1-1/+1
was pointed out by Markus Amend on -users. Reference: http://article.gmane.org/gmane.network.wireshark.user/14477 (BTW, I quickly scanned through tap-iousers.c:iousers_draw() and the sorting seems to be very inefficient.) svn path=/trunk/; revision=40911
2012-02-07Export the mtp3_heuristic_standard preference and mtp3_standard_vals[].Jeff Morriss2-5/+11
Set mtp3_standard back to the preference value after each packet (in addition to in the frame-end function) in case there are multiple packets of different standards in the same frame. svn path=/trunk/; revision=40910
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=40909
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=40908
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+3
svn path=/trunk/; revision=40907
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=40906
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-7/+8
svn path=/trunk/; revision=40905
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=40904
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-20/+1
svn path=/trunk/; revision=40903
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-22/+14
svn path=/trunk/; revision=40902
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-13/+17
svn path=/trunk/; revision=40901
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+6
svn path=/trunk/; revision=40900
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+3
svn path=/trunk/; revision=40899
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-27/+27
svn path=/trunk/; revision=40898
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-27/+5
svn path=/trunk/; revision=40897
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+3
svn path=/trunk/; revision=40896
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+3
svn path=/trunk/; revision=40895