aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-21cmake: look for Qt5 from Homebrew on macOSPeter Wu2-7/+7
When Qt5 is installed using Homebrew on macOS, Qt5 is not available in the default prefix. Remove the hack from macos-setup-brew.sh and adjust the search path instead. Note that is needed for development, "brew install" has already set this option in the environment. See https://github.com/Homebrew/homebrew-core/issues/8392 Change-Id: I57ea09b649a94c9a4cb18b1b2d334808e47ec27e Reviewed-on: https://code.wireshark.org/review/23232 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-09-20UMTS RLC: Removing unused 'is ciphered' functionDarien Spencer3-25/+6
All calls to this function were commented out in a previous commit. Also dealing with the state of the payload (ciphred or not) should be done within the RLC dissector Change-Id: Ice3a3ca8392d73c7b67308537d7568ab71a98b5e Reviewed-on: https://code.wireshark.org/review/23644 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-20FP: Removed unused codeDarien Spencer1-16/+0
Removed old code which checked if frames are ciphered and was '#if 0'ed. Corresponding logic was implemented in the RLC dissector in a previous commit. Change-Id: Ie362771277b5c0b41e790c0297ded5ed91f813e2 Reviewed-on: https://code.wireshark.org/review/23645 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-20plugins: Add backward compatibility for personal lua scriptsJoão Valverde2-6/+53
Relax requirements for upgrades and make running side-by-side installations more convenient. Change-Id: I5299eed005a4748c54465dec90f477adb577e056 Reviewed-on: https://code.wireshark.org/review/23619 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-20plugins: Be more descriptive in "about wireshark"->"folders"João Valverde7-67/+121
Display separate entries for binary plugins and lua scripts. This is explained in the user guide, that the binary folder is a subfolder of the lua folder, but it's probably a good idea to be more explicit about it, at the risk of cluttering the interface a bit. Move GeoIP information down because it seems the least important. Add helper functions to provide plugin version subdir. Change some #ifdefs while at it for legibility. Change-Id: Ieb8665df029b3c14de19e2c973bd9b1cc4ec4621 Reviewed-on: https://code.wireshark.org/review/23609 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-20[MEGACO] In dissect_megaco_eventsdescriptor() check for dm(DigitMap) notAndersBroman1-3/+1
only d as it may get confused with dt(delayTime). Change-Id: Ie5ac2a117f2d9e4a231d8ee15c795b3abdc4da07 Reviewed-on: https://code.wireshark.org/review/23643 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-20tibia: fix 'tibia.vip' exists multiple times with NOT compatible types: ↵Alexis La Goutte1-1/+1
FT_BOOLEAN and FT_UINT32 Change-Id: Icd9171d01ba06faf2e109879de2f5685ac5964bc Reviewed-on: https://code.wireshark.org/review/23638 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20messageanalyzer: fix 'etw.ndis.packet_metadata.wifi_channel' exists multiple ↵Alexis La Goutte1-1/+1
times with NOT compatible types: FT_INT32 and FT_UINT32 Change-Id: I402eb393da5a4cfd4fa19e4f3166bcf9ee058f96 Reviewed-on: https://code.wireshark.org/review/23641 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20PFCP: fix 'pfcp.mp' exists multiple times with NOT compatible types: ↵Alexis La Goutte1-1/+1
FT_UINT24 and FT_BOOLEAN Change-Id: I3099da21dedec71b0ebf130420f83234300339b3 Reviewed-on: https://code.wireshark.org/review/23639 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20GTPv2: fix 'gtpv2.uli_lai_flg' exists multiple times with NOT compatible ↵Alexis La Goutte1-1/+1
types: FT_BOOLEAN and FT_UINT8 Change-Id: I14fbe09aad243d65da0af5ab623a1ec67eeac893 Reviewed-on: https://code.wireshark.org/review/23640 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20Add version.conf to git-export-release.Gerald Combs2-2/+28
Create and stash version.conf before archiving our repository. This makes git-export-release behave more like the current Autotools dist target. Make sure the `git describe` command in git-export-release and make-version.pl use the same match pattern and abbreviation length. Abbreviate to 8 characters. That's our current unique minimum according to the git-unique-abbrev script at https://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/ : 516409 objects 4: 516194 / 65293 5: 200900 / 92205 6: 15979 / 7957 7: 1038 / 519 8: 74 / 37 9: 0 / 0 Change-Id: Id2279a59a2e24a9ecd816458f399bcd2b4c94185 Reviewed-on: https://code.wireshark.org/review/23344 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-20FP: Comments FixesDarien Spencer1-26/+8
Consistant usage of "UE ID" Consistant usage of "reassembly" Removed unused commented code Change-Id: I9e03d439d75443f8fc0a5eb5a7ef10f6ae54e3f4 Reviewed-on: https://code.wireshark.org/review/23633 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20FP: Properly configure standalone PS RAB DCHsUnknown1-5/+18
Added a check based on transport format to spot DCHs carrying a single PS RAB and configure them properly. Also renamed "special case dch 24" with it's actual meaning - a muxed CS & PS RABs Change-Id: I730b6d617d9e15bcbb5d7fde09dcd2273d943e18 Reviewed-on: https://code.wireshark.org/review/23632 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20UMTS RLC: Hide deciphering preference by defaultDarien Spencer1-5/+15
Unless wireshark is compiled with a KASUMI implementation, trying to decipher RLC will always fail. Change-Id: I0d44514579fbfcd21fe8c2b74c566c54f94e4698 Reviewed-on: https://code.wireshark.org/review/23557 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20RTSP: fix stack use after scope error reported by ASanPascal Quantin1-3/+1
Bug: 14077 Change-Id: I9fa0e62fe354b1c18687ba9041029de97719343c Reviewed-on: https://code.wireshark.org/review/23635 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-20Qt: Restore ability to display RTT by sequence numberKevin Hogan3-10/+70
Adds a checkbox to the TCP Stream Dialog's "Round-trip-time" graph tab that allows user to choose sequence number on the x-axis rather than time. Bug: 13740 Change-Id: Iaf881318437c7eecd16cf6c1f8745283ce9b4a7d Reviewed-on: https://code.wireshark.org/review/23376 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20CMake: fix extcaps dependency listMartin Kaiser1-3/+7
When compiling the list of dependencies for the extcaps target, add only those targets that we're actually building. If we skip an extcap, e.g. because we're missing libraries to build it, don't add this extcap to the dependency list. This issue was observed on a Debian box that had no libssh-gcrypt-dev package installed. Running cmake would create a warning about non-existent dependencies of the extcaps target. -- Configuring done CMake Warning (dev) at CMakeLists.txt:3217 (add_dependencies): Policy CMP0046 is not set: Error on non-existent dependency in add_dependencies. Run "cmake --help-policy CMP0046" for policy details. Use the cmake_policy command to set the policy and suppress this warning. The dependency target "ciscodump" of target "extcaps" does not exist. This warning is for project developers. Use -Wno-dev to suppress it. Change-Id: I7335173fce9833423b0e9443589143cc1a122ac0 Reviewed-on: https://code.wireshark.org/review/23321 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-09-20Snort: check executable and config files exist before trying to run.Martin Mathieson3-20/+40
Change-Id: I63986a61b392a74406ccefeaa001c110793c340a Reviewed-on: https://code.wireshark.org/review/23469 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20qt: Fix some leaked menu objectsMikael Kanstrup9-17/+18
Calling QPushButton.setMenu and QMenu.addMenu does not transfer ownership of the menu. Fix some leaks by letting "receiving" object act parent for the menu object. Bug: 14071 Change-Id: Id4edaf895503ef5dd4597eac99c2cdd6ad09b2ff Reviewed-on: https://code.wireshark.org/review/23600 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20Fix leaks related to recent settingsMikael Kanstrup3-8/+35
Fix leaks related to recent settings reported by Valgrind simply after starting/stopping application. Bug: 14071 Change-Id: Ib4f205218945c8776724899c0dd99cc81b79a41d Reviewed-on: https://code.wireshark.org/review/23599 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20Explicitly add ICMP and ICMPv6 to Flow graph.Michael Mann3-13/+88
Functionality for ICMP was "hidden" in the frame/"any" flow. Pull it out into its own using the new sequence analysis API. Change-Id: I2035f1a59a9e46ea1086443ad4b4a9723dc13883 Reviewed-on: https://code.wireshark.org/review/23625 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20Integrate LBM UIM Flow dialog into "regular" Flow diagram.Michael Mann15-1629/+142
Reduce all of the code duplication and just register the sequence analysis functionality in LBM dissector. Change-Id: I6cb5a7f0a92b04357334bbae301fa2d730a21994 Reviewed-on: https://code.wireshark.org/review/23630 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-20Rename get_plugin_dir() for consistencyJoão Valverde9-12/+12
WS_DLL_PUBLIC const char *get_plugin_dir(void); WS_DLL_PUBLIC const char *get_plugins_pers_dir(void); Opt for the plural form consistently (for public functions at least). Change-Id: I8a5861ad7f90f9c87168bd3275bd9dbc5c83b749 Reviewed-on: https://code.wireshark.org/review/23608 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-19windows-common: remove volatile qualifier from num_acesMartin Kaiser1-1/+1
A variable in a dissector must only be volatile if it's used inside a CATCH block. This is not the case for num_aces. Change-Id: I3aedb9ad2f8b96f56c9be2120276b552602658a1 Reviewed-on: https://code.wireshark.org/review/23624 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-19Qt: main window slots: don't connect setCaptureFile to DecodeAsDialogMartin Kaiser1-2/+0
The refactored DecodeAsDialog class has no setCaptureFile slot any more. It seems it's always in the foreground and there's no way to change the capture file while the DecodeAsDialog is active. The dangling connection caused a warning QObject::connect: No such slot DecodeAsDialog::setCaptureFile(capture_file*) in ../ui/qt/main_window_slots.cpp:2881 QObject::connect: (sender name: 'MainWindow') QObject::connect: (receiver name: 'DecodeAsDialog') Change-Id: Ibb12b9cdded3c6b7cca40ce08874bc4f1af4eec7 Reviewed-on: https://code.wireshark.org/review/23623 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-196lowpan: Create ifcid from AT_ETHERStig Bjørlykke1-0/+40
This will reassemble source and destination addresses from Bluetooth and Bluetooth LE. Change-Id: I563ef7b411488a2ba99fe2284eca0445208cf7e1 Reviewed-on: https://code.wireshark.org/review/23618 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Sequence (flow) analysis: fill timestamp when creating item.Jakub Zawadzki4-22/+9
Change-Id: Ie1b82d016b632162a91e2ed54a964662bc25e9d5 Reviewed-on: https://code.wireshark.org/review/23620 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-19WebSocket: check websocket_extensions pointer validityPascal Quantin1-1/+3
Bug: 14075 Change-Id: I825a30e5b8bfa57a020ae208a3a6ee67ee1a58d3 Reviewed-on: https://code.wireshark.org/review/23622 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-19IXIA lcap supportJoerg Mayer2-0/+20
IXIA^WKeysight Technologies's vitual IxNetwork version 8.30 will create capture files in a modified format: It uses a different magic and adds the total size of all records, i.e. the filesize minus the headersize. Add support for this. v2: Different file types use different magic numbers. Not yet tested/supported: The default fileending is .lcap Bug: 14073 Change-Id: Ida90b188ca66a78ff22dca237e4fd6b22e02dc14 Reviewed-on: https://code.wireshark.org/review/23614 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19[PFCP] Add more IE dissection.AndersBroman1-6/+332
Change-Id: Ib055d43fa13aa826ce449ad93cecaab9617d75db Reviewed-on: https://code.wireshark.org/review/23617 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19btle: Use bd_addr as link-layer address in data PDUStig Bjørlykke1-2/+6
This can be used in a higher layer 6LoWPAN to recreate the source and destination addresses. Change-Id: I967c3ac7c3a50526a10bec067521419d0aed8b4f Reviewed-on: https://code.wireshark.org/review/23616 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Disable flex-generated [-Wsign-compare] warningsJoão Valverde12-2/+41
Change-Id: Iace0462e6bb50573f3e4603f7a19e4b7ee1f9733 Reviewed-on: https://code.wireshark.org/review/23541 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-09-19Sequence analysis (flow graph) optimizations for dissectorsMichael Mann10-98/+98
1. Remove protocol member from seq_analysis_item_t. It's not used by any GUI, so don't burden dissectors with populating it. 2. Allow any dissector to change colors display by flow graph 3. Provide helper functions that may be common if other dissectors want to create sequence analysis. Change-Id: I04fa3c9f3cf6879ab9a8d7d6f4896b4979d010d7 Reviewed-on: https://code.wireshark.org/review/23613 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19qt: Fix leaked style for OverlayScrollBarMikael Kanstrup2-3/+14
The QWidget::setStyle method does not transfer ownership of supplied style object. Fix leak by letting OverlayScrollBar free styles created. Bug: 14071 Change-Id: Ibc14cadfc6d012e8a909be21b4f8974009fa75f5 Reviewed-on: https://code.wireshark.org/review/23601 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19prefs: Fix leak when parsing empty pref stringMikael Kanstrup1-2/+5
Fix minor leak. When parsing preference string lists and preference is empty a buffer is allocated to hold the string but is then never inserted into the string list as it is empty. This causes a minor leak as no reference is kept to allocated buffer and won't be freed by corresponding clear string list function call. Bug: 14071 Change-Id: I1edcc77095c0f430e03a49491e5281730fbceb95 Reviewed-on: https://code.wireshark.org/review/23598 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Qt: Add key events to accept and reject changes in FilterExpressionFrameStig Bjørlykke3-1/+24
Change-Id: Iba3fe50b3ca4953fc59ebd6235d04f6878d183a4 Reviewed-on: https://code.wireshark.org/review/23607 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Qt: Fix FilterExpressionFrame layoutStig Bjørlykke1-29/+12
- Use QToolButton for "Filter Buttons Preferences..." button - Remove QVBoxLayout layout for Cancel and OK buttons Change-Id: Ic5d4e96ca1c421750dc45f81a7d15f8ad637649d Reviewed-on: https://code.wireshark.org/review/23606 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Qt: Add key events to accept and reject changes in PreferenceEditorFrameStig Bjørlykke3-0/+22
Change-Id: I4a9c4b80b0438cd33c38b274a24a3b1b5db46cb8 Reviewed-on: https://code.wireshark.org/review/23605 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19Qt: Make ColumnEditorFrame use FieldFilterEdit to get a autocomplete listStig Bjørlykke2-1/+9
Change-Id: I81d5f46d572aa3f0fa1b5b94741697fc72554d2e Reviewed-on: https://code.wireshark.org/review/23587 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-19Qt: Add key events to accept and reject changes in ColumnEditorFrameStig Bjørlykke3-0/+26
Change-Id: I5f9ee01ee3aca5b2d75136fff3d8dc3e90ca1a4e Reviewed-on: https://code.wireshark.org/review/23585 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-19WebSocket: add permessage-deflate extension supportPascal Quantin3-31/+292
Bug: 14054 Change-Id: Ib6fbb58cab4d9eb140c0911391a9c330a036cfd1 Reviewed-on: https://code.wireshark.org/review/23515 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19automake: Add -Wcomma as a warning flag.Stig Bjørlykke1-0/+1
Change-Id: I93a8cefe08068f8028de01b3312f04cc05eb4f5c Reviewed-on: https://code.wireshark.org/review/23597 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-19TDS: Fix some URLs and add a note about our heuristic check.Gerald Combs1-2/+7
Wayback-ize a couple of URLs. Note that we might be able to improve our heuristic check by checking various string lengths. (I didn't add the checks myself because I don't have any TDS captures with login packets.) Change-Id: I3d67c66a292fd02035a15e1e047227f55314737a Reviewed-on: https://code.wireshark.org/review/23612 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-09-18sharkd: support flows (sequence analysis)Jakub Zawadzki1-0/+151
Change-Id: Ie85295dbcfab3efe7ba05c5c9c7ae22d0c6eedec Reviewed-on: https://code.wireshark.org/review/23572 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18Move most of sequence analysis code from ui/ to epan/Jakub Zawadzki15-557/+819
Create registration system to allow creation of analysis items to be localized to the dissector. For now only frame (all) and TCP are supported. VOIP functionality will be covered in a separate patch. Change-Id: I5b05ef6d5afff8d0b162b03a0f451ab810602e81 Reviewed-on: https://code.wireshark.org/review/23571 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18Update list of symbols for Debian.Guy Harris1-0/+5
Change-Id: I4ba02f37fcfbae01d43d7fdf5e5361373a2b0391 Reviewed-on: https://code.wireshark.org/review/23611 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-18[PFCP] Dissect more IEs.AndersBroman1-43/+685
Change-Id: Ic3a32f3317af81289da0be73474f4a8882d4bf43 Reviewed-on: https://code.wireshark.org/review/23603 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-18Qt: Fix -Wimplicit-fallthrough with GCCJoão Valverde1-0/+1
../../../ui/qt/models/decode_as_model.cpp: In member function ‘virtual QVariant DecodeAsModel::data(const QModelIndex&, int) const’: ../../../ui/qt/models/decode_as_model.cpp:155:13: error: this statement may fall through [-Werror=implicit-fallthrough=] Change-Id: I29654a0f6ce6cce7bc778231bc8d6e602875104f Reviewed-on: https://code.wireshark.org/review/23589 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-18[PFCP] Add more IE dissection.AndersBroman1-31/+1168
Change-Id: I26a75055d0a4fee209d2d118dd9403d614739d76 Reviewed-on: https://code.wireshark.org/review/23525 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-18TLS13: restore draft -18 support for HRRPeter Wu2-10/+23
Draft 18 is still the most current boringssl version, avoid a malformed packet exception by recognizing a draft -18 HelloRetryRequest. Change-Id: I43cf91350a8a2ebfad6c1e0e35eb9621a3b3e44b Fixes: v2.3.0rc0-2789-g18c4d1bb1f ("TLS13: update HRR for draft -19") Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/23544 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-08 17:18:38 +0000