diff options
| author | Guy Harris <guy@alum.mit.edu> | 2017-05-07 19:39:19 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2017-05-08 02:39:51 +0000 |
| commit | ee37135c67c7dfc3339dec7d13e665da56867b7c (patch) | |
| tree | ec3155337245dfaa12fdde177340172031ab65b4 /wiretap | |
| parent | 548e9762fb6e1c49a651b02b5e8c806dfdf74fa8 (diff) | |
Note that the HT MCS index macros can't return all possible MCS values.
I don't know whether this is a bug in the software or a lack of support
in the hardware.
This at least notes the issue in CID 1405905.
Change-Id: I481454bc38842a0f877cb8b52b73e1156fd362b5
Reviewed-on: https://code.wireshark.org/review/21558
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'wiretap')
| -rw-r--r-- | wiretap/vwr.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/wiretap/vwr.c b/wiretap/vwr.c index 69f79c4239..a912dcc85e 100644 --- a/wiretap/vwr.c +++ b/wiretap/vwr.c @@ -525,8 +525,13 @@ /* * HT - contains MCS index. + * + * XXX - MCS indices for HT go up to 76, which doesn't fit in 6 bits; + * either the mask is wrong, or the hardware can't receive packets + * with an MCS of 64 through 76, or the hardware can but misreports + * the MCS. */ -#define vVW510021_W_S2_MCS_INDEX_HT(l1p_1) ((l1p_1) & 0x3f) /* MCS index for HT */ +#define vVW510021_W_S2_MCS_INDEX_HT(l1p_1) ((l1p_1) & 0x3f) /* * VHT - contains MCS index and number of spatial streams. @@ -545,6 +550,11 @@ /* * HT - contains MCS index. + * + * XXX - MCS indices for HT go up to 76, which doesn't fit in 6 bits; + * either the mask is wrong, or the hardware can't receive packets + * with an MCS of 64 through 76, or the hardware can but misreports + * the MCS. */ #define vVW510021_W_S3_MCS_INDEX_HT(l1p_1) ((l1p_1) & 0x3f) |