diff options
| author | Moshe Kaplan <me@moshekaplan.com> | 2020-12-20 21:30:28 -0500 |
|---|---|---|
| committer | AndersBroman <a.broman58@gmail.com> | 2020-12-22 14:56:38 +0000 |
| commit | e16166a74cca1d66e2c302e257cf94aebb380599 (patch) | |
| tree | 8834b4b8390fca83dd7bc1b4b9e6a7bb276e1d7e /wiretap/k12.c | |
| parent | 7b27b444cbd94853b399da770e0dad4b91ef23ac (diff) | |
Detect and replace bad allocation patterns
Adds a pre-commit hook for detecting and replacing
occurrences of `g_malloc()` and `wmem_alloc()` with
`g_new()` and `wmem_new()`, to improve the
readability of Wireshark's code, and
occurrences of
`g_malloc(sizeof(struct myobj) * foo)`
with
`g_new(struct myobj, foo)`
to prevent integer overflows
Also fixes all existing occurrences across
the codebase.
Diffstat (limited to 'wiretap/k12.c')
| -rw-r--r-- | wiretap/k12.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/k12.c b/wiretap/k12.c index 81a1697ab7..7b8861f666 100644 --- a/wiretap/k12.c +++ b/wiretap/k12.c @@ -1380,7 +1380,7 @@ gboolean k12_dump_open(wtap_dumper *wdh, int *err, gchar **err_info _U_) { wdh->subtype_write = k12_dump; wdh->subtype_finish = k12_dump_finish; - k12 = (k12_dump_t *)g_malloc(sizeof(k12_dump_t)); + k12 = g_new(k12_dump_t, 1); wdh->priv = (void *)k12; k12->file_len = K12_FILE_HDR_LEN; k12->num_of_records = 0; |