diff options
| author | Jirka Novak <j.novak@netsystem.cz> | 2019-11-03 01:11:21 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-11-05 11:50:09 +0000 |
| commit | c0cec585640288ef2ab3509a3b3f40b9ebe30482 (patch) | |
| tree | 4887918b859e4251399bf757a3bceab12045d2d5 /ui/qt/rtp_audio_stream.cpp | |
| parent | 6fd51d5b25426c0c8f09776f2408d6e66cc50c5e (diff) | |
RTP: rtp_audio_stream.cpp: fixed excess silence in visualisation on waveform
When silence is inserted to waveform (VaD, no RTP, ...), waveform is shifted to correct time in visualisation. Code was inserting silence to audio waveform too therefore following audio was shifted twice.
This patch fixes it.
Change-Id: I4f3e02328662f92b1dabec80ce9da31d0a839046
Reviewed-on: https://code.wireshark.org/review/34917
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/rtp_audio_stream.cpp')
| -rw-r--r-- | ui/qt/rtp_audio_stream.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/ui/qt/rtp_audio_stream.cpp b/ui/qt/rtp_audio_stream.cpp index f5ed020b38..8b50783927 100644 --- a/ui/qt/rtp_audio_stream.cpp +++ b/ui/qt/rtp_audio_stream.cpp @@ -614,8 +614,10 @@ void RtpAudioStream::writeSilence(int samples) tempfile_->write(silence_buff, silence_bytes); g_free(silence_buff); - QVector<qint16> visual_fill(samples * visual_sample_rate_ / audio_out_rate_, 0); - visual_samples_ += visual_fill; + // Silence is inserted to audio file only. + // If inserted to visual_samples_ too, it shifts whole waveset + //QVector<qint16> visual_fill(samples * visual_sample_rate_ / audio_out_rate_, 0); + //visual_samples_ += visual_fill; } void RtpAudioStream::outputStateChanged(QAudio::State new_state) |