diff options
| author | Dario Lombardo <lomato@gmail.com> | 2016-05-30 16:34:03 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-05-31 12:42:04 +0000 |
| commit | 057d8a80f0a3d91c1346ff77e079539cad7887d6 (patch) | |
| tree | 6060c6b19fed0185d912e6a759b50d026cc5ffdd /ui/qt/rtp_analysis_dialog.cpp | |
| parent | ccb936eca508a586d9f5c5595615eab0bdc53098 (diff) | |
qt: fix crash when saving RTP audio
The UI crashes when saving a RTP due to a division by zero.
To reproduce: open a RTP capture file, Telephony->RTP->RTP Streams,
then choose a stream, ANALYZE, SAVE, AUDIO, choose a path.
Bug: 12211
Change-Id: I51d61eb6797fc82c1b03254abaec839d3a1e281d
Reviewed-on: https://code.wireshark.org/review/15621
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/rtp_analysis_dialog.cpp')
| -rw-r--r-- | ui/qt/rtp_analysis_dialog.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/qt/rtp_analysis_dialog.cpp b/ui/qt/rtp_analysis_dialog.cpp index d92ef23eae..e12da20fa0 100644 --- a/ui/qt/rtp_analysis_dialog.cpp +++ b/ui/qt/rtp_analysis_dialog.cpp @@ -1214,8 +1214,8 @@ void RtpAnalysisDialog::saveAudio(RtpAnalysisDialog::StreamDirection direction) if (stop_flag) { break; } - int fwd_pct = fwd_tempfile_->pos() * 100 / fwd_tempfile_->size(); - int rev_pct = rev_tempfile_->pos() * 100 / rev_tempfile_->size(); + int fwd_pct = (fwd_tempfile_->size() > 0 ? fwd_tempfile_->pos() * 100 / fwd_tempfile_->size() : 0); + int rev_pct = (rev_tempfile_->size() > 0 ? rev_tempfile_->pos() * 100 / rev_tempfile_->size() : 0); ui->progressFrame->setValue(qMin(fwd_pct, rev_pct)); if (f_write_silence > 0) { |