aboutsummaryrefslogtreecommitdiffstats
path: root/ui/qt/preference_editor_frame.ui
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2017-07-14 15:21:37 -0400
committerMichael Mann <mmann78@netscape.net>2017-09-16 11:11:50 +0000
commitd992e85fe8e9192cb730abf8796336d3b6d6fd50 (patch)
tree8dc40c70e01bdf3855f3e6950079bb0e28d622a5 /ui/qt/preference_editor_frame.ui
parentc98a7363dafdb1a261068a3e7312e66dcdf2c329 (diff)
Refactor Decode As dialog to use a model/delegate
The model provides a lot more flexibility and abstracting the data from the view (dialog) Noticeable changes from user perspective: 1. Value column doesn't always have a combobox. If registered decode as structure doesn't support multiple values, a simple edit box is used. 2. Existing value will always be a choice (default) in the Value combobox. 3. Duplicate values in Value combobox have been removed (for things like UDP port where source port and dest. port are same) 4. When adding/copying a decode as item, only first column (table) is editable, not the whole column. 5. Separator always present in Current protocol column to distinguish "none" from rest of protocols. 6. "Current" protocol defaults to "default value" when first added to the list instead of "none". Noticeable changes from developer perspective: 1. Code is much more spread out, but most new additions (like DCE/RPC support) should be limited to the model class (maybe delegate). The dialog class probably won't change much anymore. 2. decode_as_dialog.ui is much less useful because information is provided through model and delegate. Change-Id: I70a667cab2c07d251ab370430bc51e5c1f4a3a02 Reviewed-on: https://code.wireshark.org/review/22625 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt/preference_editor_frame.ui')
0 files changed, 0 insertions, 0 deletions