diff options
author | AndersBroman <anders.broman@ericsson.com> | 2016-04-29 15:23:28 +0200 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2016-05-03 10:17:46 +0000 |
commit | 6d2ea733ddedf9850883a2dbec43069b92e129bf (patch) | |
tree | d72fb4c216433f40fad65b22dc54a7dbac69f62c /ui/Makefile.common | |
parent | 1489c9e6ff1b98bee792c0cb98eb9e1dc1c1e875 (diff) |
Implement Export PDU for tshark
This patch introduces the "-U tap_name[,filter]" tshark option and
is similar to the "Export PDUs as file" option in Wireshark.
Wireshark implements this feature by reopening a capture file, applying
a tap and finally opening the temporary file. Since tshark knows
in advance that a PDU export is needed, it can optimize by not creating
the temporary file and perform the export at the first opportunity.
This patch splits the opening/tapping functionality from error reporting
since tshark does not need a temp file and has no dialogs.
The capture file comment is now specified explicitly as there is no
"current file" anymore if the tap is running without active file.
TODO:
- Review whether it is acceptable to overwrite save_file in tshark.
- Add documentation (tshark manpage).
Bug: 3444
Change-Id: Ie159495d42c32c2ba7400f2991b7b8185b3fda09
Reviewed-on: https://code.wireshark.org/review/5890
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/Makefile.common')
-rw-r--r-- | ui/Makefile.common | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ui/Makefile.common b/ui/Makefile.common index 05f738f41b..0cd6da548b 100644 --- a/ui/Makefile.common +++ b/ui/Makefile.common @@ -52,6 +52,7 @@ WIRESHARK_UI_SRC = \ export_object_http.c \ export_object_smb.c \ export_object_tftp.c \ + export_pdu_ui_utils.c \ iface_lists.c \ io_graph_item.c \ language.c \ @@ -90,6 +91,7 @@ noinst_HEADERS = \ console.h \ decode_as_utils.h \ export_object.h \ + export_pdu_ui_utils.h \ last_open_dir.h \ file_dialog.h \ help_url.h \ |