aboutsummaryrefslogtreecommitdiffstats
path: root/tools/win64-setup.sh
diff options
context:
space:
mode:
authorMichael Mann <mmann78@netscape.net>2013-03-09 00:21:56 +0000
committerMichael Mann <mmann78@netscape.net>2013-03-09 00:21:56 +0000
commit88205d4b7225bede5686d46fe7caa186abe27e2b (patch)
tree3c3a6de880240e18fec71b4850ba0d8981aedb53 /tools/win64-setup.sh
parent3721df7b19569cf31965f54e51cf92e37fd1f375 (diff)
RTPS Cleanup, Part 2
1. Convert more proto_tree_add_text to proto_tree_add_<something else>/expert_info. checkAPIs.pl is happy (for packet-rtps.c), but the raw number is a bit deceiving because of macros and wrappers. 2. Fixed the offending "uses snprintf + strlen to assemble strings" in packet-rtps.c. The exact same code is used in packet-rtps2.c, so just proper refactoring will fix it. There is still too much unnecessary use of g_snprintf/g_strlcpy/strlen, but that's for a later date. 3. Removed most of the "useless" wrapper functions. Again, the number of proto_tree_add_text is deceiving, so the number of hfs that really need to be created is much larger. 4. Whitespace cleanup. Removed a lot of whitespace so I could see more code on the screen, to help determine duplication between packet-rtps.c and packet-rtps2.c Comments/descriptions of fields remain untouched. The more I trim, the more I think this should all be in a single dissector file, which will be the goal of the next update. Trying to patch this in somewhat manageable chunks. Also need to submit sample traces generated for (fuzz)testing. svn path=/trunk/; revision=48206
Diffstat (limited to 'tools/win64-setup.sh')
0 files changed, 0 insertions, 0 deletions