diff options
author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /plugins/irda/packet-sir.c | |
parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'plugins/irda/packet-sir.c')
-rw-r--r-- | plugins/irda/packet-sir.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/plugins/irda/packet-sir.c b/plugins/irda/packet-sir.c index 57bdbc9da8..9060e42ece 100644 --- a/plugins/irda/packet-sir.c +++ b/plugins/irda/packet-sir.c @@ -49,6 +49,7 @@ void proto_register_irsir(void); /** Protocol handles. */ static dissector_handle_t irda_handle; +static dissector_handle_t sir_handle; /** Protocol fields. */ static int proto_sir = -1; @@ -174,7 +175,7 @@ dissect_sir(tvbuff_t *tvb, packet_info *pinfo, proto_tree *root, void* data _U_) void proto_reg_handoff_irsir(void) { - dissector_add_uint_with_preference("tcp.port", TCP_PORT_SIR, find_dissector("sir")); + dissector_add_uint_with_preference("tcp.port", TCP_PORT_SIR, sir_handle); irda_handle = find_dissector("irda"); } @@ -226,7 +227,7 @@ proto_register_irsir(void) expert_module_t* expert_sir; proto_sir = proto_register_protocol("Serial Infrared", "SIR", "sir"); - register_dissector("sir", dissect_sir, proto_sir); + sir_handle = register_dissector("sir", dissect_sir, proto_sir); proto_register_subtree_array(ett, array_length(ett)); proto_register_field_array( proto_sir, hf_sir, array_length(hf_sir)); expert_sir = expert_register_protocol(proto_sir); |