Convert IPX-and-friend dissectors in packet-ipx.c to use

tvbuffs.

In doing so, I realied that my recommendation for using
tvb_new_subset(pi.compat_top_tvb, -1, -1) was incorrect, because
some dissectors (ethernet!) change pi.len and pi.cap_len. So, I have
to take those two variables into account instead of using -1 and -1.

So, I provide a macro called tvb_create_from_top(offset), where
offset is the name of your offset variable. It is a wrapper around
tvb_new_subset().

I converted the lines that followed my suggestion to use
tvb_create_from_top().

In proto.c I added
proto_tree_add_debug_text(proto_tree*, const char*, ...)
It's much like proto_tree_add_text(), except that it takes no offset
or length; it's soley for temporarily putting debug text into the
proto_tree while debugging a dissector. In making sure that its
use is temporary, the funciton also prints the debug string to stdout
to remind the programmer that the debug code needs to be removed
before shipping the code.

svn path=/trunk/; revision=2068

1 files changed, 2 insertions, 3 deletions

diff --git a/packet-ddtp.c b/packet-ddtp.c
index 0474bdf8c5..ff73f6c3c4 100644
--- a/packet-ddtp.c
+++ b/packet-ddtp.c
@@ -3,7 +3,7 @@
  * see http://ddt.sourceforge.net/
  * Olivier Abad <oabad@cybercable.fr>
  *
- * $Id: packet-ddtp.c,v 1.7 2000/06/12 10:01:54 oabad Exp $
+ * $Id: packet-ddtp.c,v 1.8 2000/06/15 03:48:40 gram Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@zing.org>
@@ -109,9 +109,8 @@ dissect_ddtp(const u_char *pd, int offset, frame_data *fd, proto_tree *tree)
 {
     proto_tree  *ddtp_tree;
     proto_item  *ti;
-    tvbuff_t    *tvb;
     packet_info *pinfo = &pi;
-    tvb = tvb_new_subset(pinfo->compat_top_tvb, offset, -1, -1);
+    tvbuff_t	*tvb = tvb_create_from_top(offset);
 #endif
 
     pinfo->current_proto = "DDTP";