diff options
author | Tim Potter <tpot@samba.org> | 2003-06-26 04:30:31 +0000 |
---|---|---|
committer | Tim Potter <tpot@samba.org> | 2003-06-26 04:30:31 +0000 |
commit | 623f5b865d67fbdd54811628579feac4226c5a0b (patch) | |
tree | 6693a34e2ad66d7b8e9a1c29a3cb6ef9d391dd18 /packet-dcerpc-roverride.c | |
parent | 599a7bfd3968aefe1f38b52f7cded11a6367b2f9 (diff) |
Dynamically create DCERPC opnum value_strings from the subdissector
list rather than duplicating this information in the dissector. Some
of the opnum strings were starting to get out of date as developers
forgot to update the information in both places.
svn path=/trunk/; revision=7936
Diffstat (limited to 'packet-dcerpc-roverride.c')
-rw-r--r-- | packet-dcerpc-roverride.c | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/packet-dcerpc-roverride.c b/packet-dcerpc-roverride.c index b4cd088e5a..4666055ec2 100644 --- a/packet-dcerpc-roverride.c +++ b/packet-dcerpc-roverride.c @@ -5,7 +5,7 @@ * This information is based off the released idl files from opengroup. * ftp://ftp.opengroup.org/pub/dce122/dce/src/security.tar.gz security/idl/roverride.idl * - * $Id: packet-dcerpc-roverride.c,v 1.2 2002/11/08 19:42:39 guy Exp $ + * $Id: packet-dcerpc-roverride.c,v 1.3 2003/06/26 04:30:29 tpot Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -64,23 +64,12 @@ static dcerpc_sub_dissector roverride_dissectors[] = { { 0, NULL, NULL, NULL } }; -static const value_string roverride_opnum_vals[] = { - { 0, "roverride_get_login_info" }, - { 1, "roverride_check_passwd" }, - { 2, "roverride_is_passwd_overridden" }, - { 3, "roverride_get_by_unix_num" }, - { 4, "roverride_get_group_info" }, - { 5, "roverride_check_group_passwd" }, - { 6, "roverride_is_grp_pwd_overridden" }, - { 0, NULL } -}; - void proto_register_roverride (void) { static hf_register_info hf[] = { { &hf_roverride_opnum, - { "Operation", "roverride.opnum", FT_UINT16, BASE_DEC, VALS(roverride_opnum_vals), 0x0, "Operation", HFILL }}, + { "Operation", "roverride.opnum", FT_UINT16, BASE_DEC, NULL, 0x0, "Operation", HFILL }}, }; static gint *ett[] = { @@ -94,6 +83,14 @@ proto_register_roverride (void) void proto_reg_handoff_roverride (void) { + header_field_info *hf_info; + /* Register the protocol as dcerpc */ dcerpc_init_uuid (proto_roverride, ett_roverride, &uuid_roverride, ver_roverride, roverride_dissectors, hf_roverride_opnum); + + /* Set opnum strings from subdissector list */ + + hf_info = proto_registrar_get_nth(hf_roverride_opnum); + hf_info->strings = value_string_from_subdissectors( + roverride_dissectors, array_length(roverride_dissectors)); } |