diff options
| author | Guy Harris <guy@alum.mit.edu> | 2003-10-02 21:18:38 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2003-10-02 21:18:38 +0000 |
| commit | 6b7afbb5930b4085fc0639ca85fa4273495d4876 (patch) | |
| tree | 0fd8e074e3c6684c1f0e1f99b32aaf12e3b371a5 /gtk/prefs_dlg.c | |
| parent | 301bc24c438a713a19ca5b3c85286af879e3c721 (diff) | |
From Tomas Kukosa: radio button groups are GSLists, which means that the
radio button group for a button changes when new buttons are added to it
(adding to the beginning of a singly-linked list takes constant time,
adding to the end takes time linear in the length of the list, and a
GSList * points to the beginning of the list). Re-fetch the radio
button group each time through the loop that adds new radio buttons to a
radio button group for a preference.
svn path=/trunk/; revision=8591
Diffstat (limited to 'gtk/prefs_dlg.c')
| -rw-r--r-- | gtk/prefs_dlg.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/gtk/prefs_dlg.c b/gtk/prefs_dlg.c index 5ce5b1b26c..70d8db7125 100644 --- a/gtk/prefs_dlg.c +++ b/gtk/prefs_dlg.c @@ -1,7 +1,7 @@ /* prefs_dlg.c * Routines for handling preferences * - * $Id: prefs_dlg.c,v 1.62 2003/10/02 21:06:11 guy Exp $ + * $Id: prefs_dlg.c,v 1.63 2003/10/02 21:18:38 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -687,8 +687,7 @@ create_preference_radio_buttons(GtkWidget *main_tb, int table_position, button = gtk_radio_button_new_with_label(rb_group, enum_valp->name); gtk_widget_show(button); - if (rb_group == NULL) - rb_group = gtk_radio_button_group(GTK_RADIO_BUTTON(button)); + rb_group = gtk_radio_button_group(GTK_RADIO_BUTTON(button)); gtk_box_pack_start(GTK_BOX(radio_button_hbox), button, FALSE, FALSE, 10); if (enum_valp->value == current_val) { |