aboutsummaryrefslogtreecommitdiffstats
path: root/epan
diff options
context:
space:
mode:
authorJeff Morriss <jeff.morriss@ulticom.com>2012-03-21 22:18:15 +0000
committerJeff Morriss <jeff.morriss@ulticom.com>2012-03-21 22:18:15 +0000
commit1731fc958e6a34dac1297d4a7f45c6bc9d18bb92 (patch)
tree269fa64813c0501284789720d8309264064148cb /epan
parent5629a3fa00eeb23f3ef0b08c1fb958617ebefc67 (diff)
From Martin Kaiser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6977 :
The attached (trivial) patch adds some missing breaks in switch-case blocks. This fixes coverity defects #445, #446, #1316 and #1380. svn path=/trunk/; revision=41727
Diffstat (limited to 'epan')
-rw-r--r--epan/dissectors/packet-bacapp.c1
-rw-r--r--epan/dissectors/packet-bthci_cmd.c2
-rw-r--r--epan/dissectors/packet-bthci_evt.c2
-rw-r--r--epan/dissectors/packet-gsm_sim.c1
4 files changed, 4 insertions, 2 deletions
diff --git a/epan/dissectors/packet-bacapp.c b/epan/dissectors/packet-bacapp.c
index 5824b0586b..02ad2c1a5a 100644
--- a/epan/dissectors/packet-bacapp.c
+++ b/epan/dissectors/packet-bacapp.c
@@ -6250,6 +6250,7 @@ fLoggingRecord (tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, guint
break;
case 3: /* accumulatorStatus */
offset = fEnumeratedTag (tvb, tree, offset, "Accumulator Status: ", BACnetAccumulatorStatus);
+ break;
default:
return offset;
}
diff --git a/epan/dissectors/packet-bthci_cmd.c b/epan/dissectors/packet-bthci_cmd.c
index 18215af650..fca9dfd0bf 100644
--- a/epan/dissectors/packet-bthci_cmd.c
+++ b/epan/dissectors/packet-bthci_cmd.c
@@ -934,7 +934,7 @@ dissect_bthci_ext_inquiry_response(tvbuff_t *tvb, int offset, packet_info *pinfo
break;
case 0x0A: /* Tx Power Level */
proto_tree_add_item(ti_eir_struct_subtree, hf_bthci_cmd_tx_power, tvb, offset+i+2, 1, ENC_LITTLE_ENDIAN);
-
+ break;
default:
proto_tree_add_item(ti_eir_struct_subtree, hf_bthci_cmd_eir_data, tvb, offset+i+2, length-1, ENC_NA);
break;
diff --git a/epan/dissectors/packet-bthci_evt.c b/epan/dissectors/packet-bthci_evt.c
index a6f31349de..1c25280922 100644
--- a/epan/dissectors/packet-bthci_evt.c
+++ b/epan/dissectors/packet-bthci_evt.c
@@ -1331,7 +1331,7 @@ dissect_bthci_evt_ext_inquiry_response(tvbuff_t *tvb, int offset, packet_info *p
break;
case 0x0A: /* Tx Power Level */
proto_tree_add_item(ti_eir_struct_subtree, hf_bthci_evt_transmit_power_level, tvb, offset+i+2, 1, ENC_LITTLE_ENDIAN);
-
+ break;
default:
proto_tree_add_item(ti_eir_struct_subtree, hf_bthci_evt_eir_data, tvb, offset+i+2, length-1, ENC_NA);
break;
diff --git a/epan/dissectors/packet-gsm_sim.c b/epan/dissectors/packet-gsm_sim.c
index 2ab970141e..530526d926 100644
--- a/epan/dissectors/packet-gsm_sim.c
+++ b/epan/dissectors/packet-gsm_sim.c
@@ -760,6 +760,7 @@ static const gchar *get_sw_string(guint16 sw)
case 0x92:
if ((sw & 0xf0) == 0x00)
return "Command successful but after internal retry routine";
+ break;
case 0x67:
return "Incorrect parameter P3";
case 0x6d: