aboutsummaryrefslogtreecommitdiffstats
path: root/epan
diff options
context:
space:
mode:
authorBinh Trinh <beango@gmail.com>2016-08-31 00:18:17 -0400
committerAnders Broman <a.broman58@gmail.com>2016-08-31 06:27:59 +0000
commit1178ee68fbbea6dc096df0d69f776a2158de630e (patch)
treeb370abb8ae0d6106bcbecc5ab725730a8ac24cd4 /epan
parent5be39d98fb2fa07f250909989213496873f37a74 (diff)
GTP: patch for Target identification for non-compliance workaround
bug 3974 Change-Id: I2faa473c725a803056d6ffd0cb34b46d75121061 Reviewed-on: https://code.wireshark.org/review/17410 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan')
-rw-r--r--epan/dissectors/packet-gtp.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/epan/dissectors/packet-gtp.c b/epan/dissectors/packet-gtp.c
index 54535fdac1..cfc73b739c 100644
--- a/epan/dissectors/packet-gtp.c
+++ b/epan/dissectors/packet-gtp.c
@@ -5668,6 +5668,13 @@ decode_gtp_target_id(tvbuff_t * tvb, int offset, packet_info * pinfo, proto_tree
if (length == 0){
return 3 + length;
}
+
+ /* Patch for systems still not following NOTE 2 */
+ if (length == 9) {
+ proto_tree_add_expert_format(ext_tree, pinfo, &ei_gtp_undecoded, tvb, offset, 1, "Not Compliant with 3GPP TS 29.060 7.7.37: The preamble of the \"Target RNC-ID\" (numerical value of e.g. 0x20) however shall not be included in octets 4-n.");
+ offset+=1;
+ }
+
/* Quote from specification:
* The Target Identification information element contains the identification of a target RNC. Octets 4-n shall contain a
* non-transparent copy of the corresponding IEs (see subclause 7.7.2) and be encoded as specified in Figure 51 below.