aboutsummaryrefslogtreecommitdiffstats
path: root/epan/slow_protocol_subtypes.h
diff options
context:
space:
mode:
authorMartin Kaiser <wireshark@kaiser.cx>2016-12-22 22:16:43 +0100
committerMartin Kaiser <wireshark@kaiser.cx>2016-12-23 08:59:51 +0000
commit933a73177736171214c2ae853fa3819fc09016bc (patch)
tree6452b23bdd2dbddce8778c43e35f10712b639965 /epan/slow_protocol_subtypes.h
parentabe78e915e6d4aaa82b623865cadb95cc6402851 (diff)
DVB-CI: don't call proto_tree_add_subtree_format() with tvb==NULL
When I first implemented this, proto_tree_add_subtree_format() worked for tvb==NULL if len was also 0. The bounds check added in 56706427f53cc64793870bf072c2c06248ae88f3 breaks this use case and makes DVB-CI spill out dissector asserts. Warn Dissector bug, protocol DVB-CI, in packet 625: ../epan/tvbuff.c:532: failed assertion "tvb && tvb->initialized" Create a proto_item first and link the subtree to this item. This will work as long as proto_tree_add_uint() accepts tvb==NULL. Thanks to Kay Katzorke for reporting this bug. Change-Id: I25a071c21925f7d362c92852fd5a8136e4d361c8 Reviewed-on: https://code.wireshark.org/review/19389 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Diffstat (limited to 'epan/slow_protocol_subtypes.h')
0 files changed, 0 insertions, 0 deletions