diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-05-29 15:44:54 -0400 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-05-31 10:43:56 +0000 |
| commit | 33414fe175138a21f63813fdb51888f0066768a4 (patch) | |
| tree | 49327f38d863270a02ad5fdc241bfcc30a92b158 /epan/proto.h | |
| parent | 0add74fcc9b6a4ee433af36f5d796b319ca1f66b (diff) | |
Remove proto_item_append_string.
It requires some "extra work" to get it to work properly. Despite
documenting it, some previous use cases didn't do the extra work.
Let's just see how we get by without it.
Change-Id: I31dba1d5038d793085f6c9e4b4a6eda574e86872
Reviewed-on: https://code.wireshark.org/review/15610
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/proto.h')
| -rw-r--r-- | epan/proto.h | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/epan/proto.h b/epan/proto.h index 6378cc4f83..58c1367100 100644 --- a/epan/proto.h +++ b/epan/proto.h @@ -2066,26 +2066,6 @@ proto_tree_add_debug_text(proto_tree *tree, const char *format, ...) G_GNUC_PRINTF(2,3); - -/** Append a string to a protocol item.<br> - NOTE: this function will break with the TRY_TO_FAKE_THIS_ITEM() - speed optimization. - Currently only a few dissectors use this function so it is not - that bad but try to avoid using this one if possible. - IF you must use this function you MUST also disable the - TRY_TO_FAKE_THIS_ITEM() optimization for the proto_item you'll be - appending to with proto_item_append_string(). - Do that by faking that the tree is visible by calling - proto_tree_set_visible(tree, TRUE) (see packet-frame.c) - BEFORE you create the item you are later going to use - proto_item_append_string() on. - @param pi the item to append the string to - @param str the string to append */ -WS_DLL_PUBLIC void -proto_item_append_string(proto_item *pi, const char *str); - - - /** Fill given label_str with string representation of field @param fi the item to get the info from @param label_str the string to fill |