aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtpproxy.c
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2014-10-19 23:14:50 -0700
committerGuy Harris <guy@alum.mit.edu>2014-10-20 06:15:19 +0000
commit80e6f6251e96dd7b8a9ab0fdbf63b03a73ef6692 (patch)
tree92d519b9b19cccba0d083a6ad20152352daa5924 /epan/dissectors/packet-rtpproxy.c
parent0b9eb9f4b71b6632cfb4b87bcdefdfa75eaf2dd0 (diff)
Get rid of calls to ctype.h functions.
They don't handle values outside the range -1 to 127, and their behavior is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of isXXX() and toXXX(). If you're checking for printable ASCII, don't use isascii() and don't use iscntrl(), use g_ascii_isprint(). If you're checking for graphical ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph(). Use ws_xton() to convert a hex digit character to the corresponding numeric value. Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330 Reviewed-on: https://code.wireshark.org/review/4851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-rtpproxy.c')
-rw-r--r--epan/dissectors/packet-rtpproxy.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/epan/dissectors/packet-rtpproxy.c b/epan/dissectors/packet-rtpproxy.c
index f58163ae00..fa05af9f71 100644
--- a/epan/dissectors/packet-rtpproxy.c
+++ b/epan/dissectors/packet-rtpproxy.c
@@ -29,7 +29,6 @@
#include "config.h"
#include <stdlib.h>
-#include <ctype.h>
#include <glib.h>
#include <epan/address.h>
@@ -517,7 +516,7 @@ dissect_rtpproxy(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data
tvbuff_t *subtvb;
/* If it does not start with a printable character it's not RTPProxy */
- if(!isprint(tvb_get_guint8(tvb, 0)))
+ if(!g_ascii_isprint(tvb_get_guint8(tvb, 0)))
return 0;
/* Extract Cookie */