diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-08-15 14:34:50 +0100 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-08-16 21:49:04 +0000 |
| commit | e48ab21267c90bf5f870003299e00ea1656e2d7e (patch) | |
| tree | 088ba02fb029c930a2a048fb97dc180df4010291 /epan/dissectors/packet-q2931.c | |
| parent | 521180d8d7eed5a78841b938b8570bff6cca6d80 (diff) | |
BER: Fix order of loop tests to avoid overrunning array.
Reported by cppcheck:
epan/dissectors/packet-ber.c:2603:35: warning: Array index 'set_idx' is used before limits check. [arrayIndexThenCheck]
for (set_idx = 0; (cset = &set[set_idx])->func && (set_idx < MAX_SET_ELEMENTS); set_idx++) {
^
epan/dissectors/packet-ber.c:2759:40: warning: Array index 'set_idx' is used before limits check. [arrayIndexThenCheck]
for (set_idx = 0; (cset = &set[set_idx])->func && (set_idx < MAX_SET_ELEMENTS); set_idx++) {
^
Change-Id: Ifbb9f1d2e9062a5c55190ea68df2226f3af8f21a
Reviewed-on: https://code.wireshark.org/review/38166
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-q2931.c')
0 files changed, 0 insertions, 0 deletions