Dissectors don't need a journey of self discovery.

They already know who they are when they register themselves.  Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.

Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 3 insertions, 5 deletions

diff --git a/epan/dissectors/packet-hpsw.c b/epan/dissectors/packet-hpsw.c
index b91cdac274..ffc32f9b9a 100644
--- a/epan/dissectors/packet-hpsw.c
+++ b/epan/dissectors/packet-hpsw.c
@@ -60,6 +60,8 @@ static gint ett_hpsw_tlv = -1;
 
 static expert_field ei_hpsw_tlvlength_bad = EI_INIT;
 
+static dissector_handle_t hpsw_handle;
+
 #define HPFOO_DEVICE_NAME     0x1
 #define HPFOO_DEVICE_VERSION  0x2
 #define HPFOO_CONFIG_NAME     0x3
@@ -359,16 +361,12 @@ proto_register_hpsw(void)
     expert_hpsw = expert_register_protocol(proto_hpsw);
     expert_register_field_array(expert_hpsw, ei, array_length(ei));
 
-    register_dissector("hpsw", dissect_hpsw, proto_hpsw);
+    hpsw_handle = register_dissector("hpsw", dissect_hpsw, proto_hpsw);
 }
 
 void
 proto_reg_handoff_hpsw(void)
 {
-    dissector_handle_t hpsw_handle;
-
-    hpsw_handle = find_dissector("hpsw");
-
     dissector_add_uint("hpext.dxsap", HPEXT_HPSW, hpsw_handle);
 }