diff options
| author | Pascal Quantin <pascal.quantin@gmail.com> | 2013-03-18 20:26:47 +0000 |
|---|---|---|
| committer | Pascal Quantin <pascal.quantin@gmail.com> | 2013-03-18 20:26:47 +0000 |
| commit | 94f330030de8410b5f28798ad12da48a9944ab36 (patch) | |
| tree | 71cc02064eac3f36fd4234990f9e2f3a588c4a2c /epan/dissectors/packet-gsm_a_rp.c | |
| parent | 434aae5245f83f69bf3eb49ad34966c442117385 (diff) | |
use enum values instead of hardcoded values
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)
svn path=/trunk/; revision=48397
Diffstat (limited to 'epan/dissectors/packet-gsm_a_rp.c')
| -rw-r--r-- | epan/dissectors/packet-gsm_a_rp.c | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/epan/dissectors/packet-gsm_a_rp.c b/epan/dissectors/packet-gsm_a_rp.c index 7c3ab70754..04d0e48f2b 100644 --- a/epan/dissectors/packet-gsm_a_rp.c +++ b/epan/dissectors/packet-gsm_a_rp.c @@ -55,13 +55,25 @@ static const value_string gsm_rp_msg_strings[] = { { 0, NULL } }; +typedef enum +{ + /* Short Message Service Information Elements [5] 8.2 */ + DE_RP_MESSAGE_REF, /* RP-Message Reference */ + DE_RP_ORIG_ADDR, /* RP-Originator Address */ + DE_RP_DEST_ADDR, /* RP-Destination Address */ + DE_RP_USER_DATA, /* RP-User Data */ + DE_RP_CAUSE, /* RP-Cause */ + DE_RP_NONE /* NONE */ +} +rp_elem_idx_t; + const value_string gsm_rp_elem_strings[] = { /* Short Message Service RP Information Elements [5] 8.2 */ - { 0x00, "RP-Message Reference" }, - { 0x01, "RP-Originator Address" }, - { 0x02, "RP-Destination Address" }, - { 0x03, "RP-User Data" }, - { 0x04, "RP-Cause" }, + { DE_RP_MESSAGE_REF, "RP-Message Reference" }, + { DE_RP_ORIG_ADDR, "RP-Originator Address" }, + { DE_RP_DEST_ADDR, "RP-Destination Address" }, + { DE_RP_USER_DATA, "RP-User Data" }, + { DE_RP_CAUSE, "RP-Cause" }, { 0, NULL } }; @@ -80,18 +92,6 @@ static dissector_table_t sms_dissector_table; /* SMS TPDU */ static proto_tree *g_tree; -typedef enum -{ - /* Short Message Service Information Elements [5] 8.2 */ - DE_RP_MESSAGE_REF, /* RP-Message Reference */ - DE_RP_ORIG_ADDR, /* RP-Originator Address */ - DE_RP_DEST_ADDR, /* RP-Destination Address */ - DE_RP_USER_DATA, /* RP-User Data */ - DE_RP_CAUSE, /* RP-Cause */ - DE_RP_NONE /* NONE */ -} -rp_elem_idx_t; - #define NUM_GSM_RP_ELEM (sizeof(gsm_rp_elem_strings)/sizeof(value_string)) gint ett_gsm_rp_elem[NUM_GSM_RP_ELEM]; |