diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-ecp-oui.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-ecp-oui.c')
| -rw-r--r-- | epan/dissectors/packet-ecp-oui.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/epan/dissectors/packet-ecp-oui.c b/epan/dissectors/packet-ecp-oui.c index 6fcaf9418d..43566edef8 100644 --- a/epan/dissectors/packet-ecp-oui.c +++ b/epan/dissectors/packet-ecp-oui.c @@ -76,6 +76,8 @@ static gint ett_ecp = -1; static gint ett_end_of_vdpdu = -1; static gint ett_802_1qbg_capabilities_flags = -1; +static dissector_handle_t ecp_handle; + static const value_string ecp_pid_vals[] = { { 0x0000, "ECP draft 0" }, { 0, NULL } @@ -438,14 +440,11 @@ void proto_register_ecp_oui(void) ieee802a_add_oui(OUI_IEEE_802_1QBG, "ieee802a.ecp_pid", "IEEE802a ECP PID", &hf_reg, proto_ecp); - register_dissector("ecp", dissect_ecp, proto_ecp); + ecp_handle = register_dissector("ecp", dissect_ecp, proto_ecp); } void proto_reg_handoff_ecp(void) { - static dissector_handle_t ecp_handle; - - ecp_handle = find_dissector("ecp"); dissector_add_uint("ieee802a.ecp_pid", 0x0000, ecp_handle); } |