diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2018-07-30 18:18:40 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-08-08 11:23:55 +0000 |
| commit | d7187e0b1ba0303dc493c4a75d9949cfca8ede98 (patch) | |
| tree | 5020f7383683b77d341817992350ce55b06f1164 /debian/libwsutil0.symbols | |
| parent | e50ae0ad11c63d47b864db7319aa9163eefd2296 (diff) | |
wsutil: Add Curve25519 ECDH (X25519) using Gcrypt
The WireGuard dissector will need X25519 to enable decryption, add a
Gcrypt implementation that implements the NaCl/Sodium interface.
While inspired by the MPI example in t-cv25519.c, note subtle but
important correctness/interoperability fixes: add a check for infinity
(gcry_mpi_ec_get_affine) and handle short values from gcry_mpi_print.
The last issue is ugly, perhaps the high level API (gcry_pk_decrypt)
should be used instead (which < 2% slower than this MPI implementation).
(Both issues were found through fuzzing.)
As for alternative options, Sodium is superior but would be a new
dependency. For some older performance and usability notes (comparing
crypto_scalarmult_curve25519_base (note "_base") against others), see
https://lists.gnupg.org/pipermail/gcrypt-devel/2018-July/004532.html
Performance comparison on Ubuntu 18.04 (i7-3770) between Sodium 1.0.16
against Gcrypt 1.8.3 and Gcrypt 86e5e06a (git master, future 1.9.x) by
computing 65536 times X25519(1, 8) via crypto_scalarmult_curve25519:
Sodium (sandy2x): 1.4x faster than ref10
Sodium (ref10): 1 (baseline)
Gcrypt (git): 5x slower than ref10, 7x slower than sandy2x
Gcrypt (1.8.3): 17x ref10, 24x sandy2x (took 65 seconds)
Change-Id: Ia54e73cc3cc469a6697554729aff4edd19f55630
Ping-Bug: 15011
Reviewed-on: https://code.wireshark.org/review/28987
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'debian/libwsutil0.symbols')
| -rw-r--r-- | debian/libwsutil0.symbols | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/debian/libwsutil0.symbols b/debian/libwsutil0.symbols index 2149b023be..cf9c98ffaf 100644 --- a/debian/libwsutil0.symbols +++ b/debian/libwsutil0.symbols @@ -44,6 +44,8 @@ libwsutil.so.0 libwsutil0 #MINVER# create_tempfile@Base 1.12.0~rc1 create_timestamp@Base 2.5.0 crypt_des_ecb@Base 2.3.0 + crypto_scalarmult_curve25519@Base 2.9.0 + crypto_scalarmult_curve25519_base@Base 2.9.0 data_file_url@Base 2.3.0 decrypt_xtea_ecb@Base 2.5.0 decrypt_xtea_le_ecb@Base 2.5.0 |