diff options
| author | Luis Ontanon <luis.ontanon@gmail.com> | 2007-08-25 14:48:48 +0000 |
|---|---|---|
| committer | Luis Ontanon <luis.ontanon@gmail.com> | 2007-08-25 14:48:48 +0000 |
| commit | becf83594b3d3114f9426c78174306ad8d39d8b4 (patch) | |
| tree | d1faf78ae365c9f8a5e422b2b2078e8bb9095150 | |
| parent | 7c174c63f827576c33ca258b267987d5ad950248 (diff) | |
there's nothing like a MAX_OID_STR_LEN... get rid of a potential stack BO
svn path=/trunk/; revision=22657
| -rw-r--r-- | asn1/x411/packet-x411-template.c | 4 | ||||
| -rw-r--r-- | epan/dissectors/packet-x411.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/asn1/x411/packet-x411-template.c b/asn1/x411/packet-x411-template.c index 3adbe6b8ae..75f3eaf835 100644 --- a/asn1/x411/packet-x411-template.c +++ b/asn1/x411/packet-x411-template.c @@ -94,9 +94,9 @@ static int call_x411_oid_callback(char *base_oid, tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree) { const char *name = NULL; - char extension_oid[MAX_OID_STR_LEN]; + char* extension_oid; - sprintf(extension_oid, "%s.%d", base_oid, extension_id); + extension_oid = ep_strdup_printf("%s.%d", base_oid, extension_id); name = get_oid_str_name(extension_oid); proto_item_append_text(tree, " (%s)", name ? name : extension_oid); diff --git a/epan/dissectors/packet-x411.c b/epan/dissectors/packet-x411.c index c1b4209286..ab6c2b7ab5 100644 --- a/epan/dissectors/packet-x411.c +++ b/epan/dissectors/packet-x411.c @@ -7803,9 +7803,9 @@ static int call_x411_oid_callback(char *base_oid, tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree) { const char *name = NULL; - char extension_oid[MAX_OID_STR_LEN]; + char* extension_oid; - sprintf(extension_oid, "%s.%d", base_oid, extension_id); + extension_oid = ep_strdup_printf("%s.%d", base_oid, extension_id); name = get_oid_str_name(extension_oid); proto_item_append_text(tree, " (%s)", name ? name : extension_oid); |