diff options
| author | Erika Szelleova <szelleerika@gmail.com> | 2018-06-18 19:47:17 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-06-21 03:33:21 +0000 |
| commit | 6b13c05da11e7735b4a50995c23ecf309d55a62d (patch) | |
| tree | d073aae0e0c8d5bb5b2d546f4743804278471d5a | |
| parent | 11ba10dd4b8865d1d4b866cd808ec8fe4defe3b2 (diff) | |
OpcUa: fix in function getExtensionObjectType
The function getExtensionObjectType was not reading the corrects bytes,
this sometimes ended in reading outside the buffer and that way
exception was raised even for correct packets.
Bug: 14465
Change-Id: I5d7d9ca5f43f0afbc93f40487a78709c52f0658a
Reviewed-on: https://code.wireshark.org/review/28328
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | plugins/epan/opcua/opcua_simpletypes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/epan/opcua/opcua_simpletypes.c b/plugins/epan/opcua/opcua_simpletypes.c index 7f9a7ff765..a787f21c35 100644 --- a/plugins/epan/opcua/opcua_simpletypes.c +++ b/plugins/epan/opcua/opcua_simpletypes.c @@ -1274,7 +1274,7 @@ guint32 getExtensionObjectType(tvbuff_t *tvb, gint *pOffset) Numeric = tvb_get_letohs(tvb, iOffset); break; case 0x02: /* numeric, that does not fit into four bytes */ - iOffset+=4; + iOffset+=2; Numeric = tvb_get_letohl(tvb, iOffset); break; case 0x03: /* string */ |