diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2022-04-21 04:24:10 +0300 |
|---|---|---|
| committer | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2022-04-25 16:14:35 +0300 |
| commit | 8ecc266d8deab850851ef30c617b6c186355d23a (patch) | |
| tree | a91be3c3073df304ff9488c174035b05b3197f30 /src/target/firmware | |
| parent | 3f49d7a0fa6d2ae8368432781f68419c778ab4c5 (diff) | |
firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()
In this function we have the following condition:
if (pm_mode == PM_IDLE && (mode == MODE_MAIN || mode == MODE_SPECTRUM))
so the 'mode' can be either MODE_MAIN or MODE_SPECTRUM. Still,
GCC throws false-positive warnings that 'a' and 'e' may be used
uninitialized in handle_pm().
Let's eliminate these warnings by using 'if-else' statement.
Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890
Diffstat (limited to 'src/target/firmware')
| -rw-r--r-- | src/target/firmware/apps/rssi/main.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 9a3f87cc..94ecc3b0 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -920,8 +920,7 @@ static void handle_pm(void) a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; - } - if (mode == MODE_SPECTRUM) { + } else { /* mode == MODE_SPECTRUM */ if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) { a = PCS_MIN | ARFCN_PCS; e = PCS_MAX | ARFCN_PCS; |