summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2017-10-09 23:12:57 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2017-10-11 22:32:19 +0200
commitc5122f28292e4923f02bb645c6bb7fa4c270a5d5 (patch)
treeb85b153a67fd2cf6f1b91c6d03567c534452b003 /src
parent1cbdb70b27599b3a233184d01cee63cea5e8fee3 (diff)
code undup: use db_bind_text() in db_get_auth_data()
To make the db_bind_text() error reporting mention "imsi", change the DB_STMT_AUC_BY_IMSI to use a named parameter. Change-Id: I49bd5eb78170cf4cdf8abb386c766d20d9f1cf73
Diffstat (limited to 'src')
-rw-r--r--src/db.c2
-rw-r--r--src/db_auc.c10
2 files changed, 3 insertions, 9 deletions
diff --git a/src/db.c b/src/db.c
index f1c14c9..fbf5c76 100644
--- a/src/db.c
+++ b/src/db.c
@@ -52,7 +52,7 @@ static const char *stmt_sql[] = {
" FROM subscriber"
" LEFT JOIN auc_2g ON auc_2g.subscriber_id = subscriber.id"
" LEFT JOIN auc_3g ON auc_3g.subscriber_id = subscriber.id"
- " WHERE imsi = ?",
+ " WHERE imsi = $imsi",
[DB_STMT_AUC_UPD_SQN] = "UPDATE auc_3g SET sqn = $sqn WHERE subscriber_id = $subscriber_id",
[DB_STMT_UPD_PURGE_CS_BY_IMSI] = "UPDATE subscriber SET ms_purged_cs = $val WHERE imsi = $imsi",
[DB_STMT_UPD_PURGE_PS_BY_IMSI] = "UPDATE subscriber SET ms_purged_ps = $val WHERE imsi = $imsi",
diff --git a/src/db_auc.c b/src/db_auc.c
index eae5070..7bbc93f 100644
--- a/src/db_auc.c
+++ b/src/db_auc.c
@@ -87,14 +87,8 @@ int db_get_auth_data(struct db_context *dbc, const char *imsi,
memset(aud2g, 0, sizeof(*aud2g));
memset(aud3g, 0, sizeof(*aud3g));
- /* bind the IMSI value */
- rc = sqlite3_bind_text(stmt, 1, imsi, -1,
- SQLITE_STATIC);
- if (rc != SQLITE_OK) {
- LOGAUC(imsi, LOGL_ERROR, "Error binding IMSI: %d\n", rc);
- ret = -EIO;
- goto out;
- }
+ if (!db_bind_text(stmt, "$imsi", imsi))
+ return -EIO;
/* execute the statement */
rc = sqlite3_step(stmt);