diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2022-04-08 01:32:36 +0300 |
|---|---|---|
| committer | fixeria <vyanitskiy@sysmocom.de> | 2022-04-08 20:39:35 +0000 |
| commit | 94f7b4753a5ca1f95efec04d74c4f8abe688c79e (patch) | |
| tree | 3c2dd6fcb5603ab52b24b5ccbea12bd4fb37d063 | |
| parent | dd7bed3415a452ee80a082750b7acd41659ab9a9 (diff) | |
power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL2022q1
For the sake of consistency and code readability, initialize the
power loop control interval (P_Con_INTERVAL) for both Uplink and
Downlink directions in the same function.
Change-Id: If7c804e51eb104d9fe73294a3867ab3b551d83c3
| -rw-r--r-- | src/common/power_control.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/common/power_control.c b/src/common/power_control.c index 42d9d07f..0db53784 100644 --- a/src/common/power_control.c +++ b/src/common/power_control.c @@ -404,9 +404,6 @@ int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan, /* Default MS/BS Power Control parameters (see 3GPP TS 45.008, table A.1) */ const struct gsm_power_ctrl_params power_ctrl_params_def = { - - .ctrl_interval = 1, /* Trigger loop every second SACCH block. TS 45.008 sec 4.7.1 */ - /* Power increasing/reducing step size (optimal defaults) */ .inc_step_size_db = 4, /* quickly increase MS/BS power */ .red_step_size_db = 2, /* slowly decrease MS/BS power */ @@ -569,7 +566,10 @@ const struct gsm_power_ctrl_params power_ctrl_params_def = { void power_ctrl_params_def_reset(struct gsm_power_ctrl_params *params, bool is_bs_pwr) { *params = power_ctrl_params_def; + + /* Trigger loop every N-th SACCH block. See 3GPP TS 45.008 section 4.7.1. */ if (!is_bs_pwr) - /* Trigger loop every fourth SACCH block (1.92s). TS 45.008 sec 4.7.1: */ - params->ctrl_interval = 2; + params->ctrl_interval = 2; /* N=4 (1.92s) */ + else + params->ctrl_interval = 1; /* N=2 (0.960) */ } |