diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-07-26 20:33:15 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2018-07-28 12:18:23 +0200 |
| commit | bcdbfb740610bea2f1b51c5c331af5386a841393 (patch) | |
| tree | fdba1310ddda4254aa665cdd6cfd0e7b40db9767 /tests | |
| parent | 31f525e7560ad13e32cfc5e0b5f1862c0efcb991 (diff) | |
fix nanobts: timeslot FSM: use flags to remember OML,RSL status
Before this patch, the timeslot FSM receives OML and RSL ready events.
Afterwards, it relies on examining the RSL and OML status to match the received
events. This doesn't work for the ip.access nanobts, which fails to change the
CHANNEL OM's operational status even though it has sent an Opstart ACK. We
receive OML CHANNEL Opstart ACK, but the mo's state left at OP_STATE=Disabled.
We apparently cannot rely on the gsm_abis_mo state as assumed before this
patch, since changing the state depends on each BTS vendor's OML
implementation.
Also, implementation wise, it is better to not include assumptions on RSL and
OML implementations in the timeslot FSM. Simply receive the OML and RSL ready
events and remember that they arrived in dedicated flags.
Remove the no longer needed oml_is_ts_ready() callback from struct
gsm_bts_model added in:
commit 91aa68f762218906e45be4817c6ea54b480da5e1
"dyn TS: init only when both RSL and the Channel OM are established"
I99f29d2ba079f6f4b77f0af12d9784588d2f56b3
This keeps osmo-bts operational while fixing ip.access nanobts, where the
CHANNEL OM's state prevented the timeslot FSM from entering operation.
Change-Id: I4843d03b3237cdcca0ad2041ef6895ff253d8419
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/handover/handover_test.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 3a5748e5a..172e620fa 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -210,6 +210,7 @@ static struct gsm_bts *create_bts(int arfcn) for (i = 0; i < ARRAY_SIZE(bts->c0->ts); i++) { /* make sure ts->lchans[] get initialized */ + osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_RSL_READY, 0); osmo_fsm_inst_dispatch(bts->c0->ts[i].fi, TS_EV_OML_READY, 0); } return bts; |