diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-05-04 22:55:09 +0200 |
|---|---|---|
| committer | Neels Hofmeyr <neels@hofmeyr.de> | 2018-06-08 05:47:54 +0200 |
| commit | 0935546b2b30ead6183b6fde2f324f118e657125 (patch) | |
| tree | cde802a54bdf84d4e6077daa80f7257c6d917d9a /src/osmo-bsc/osmo_bsc_api.c | |
| parent | 13269b0f9b050de0100e5209b2e47942b43758b4 (diff) | |
assignment: signal assignment failure on chan act nack
When the BTS responds with a Chan Act NACK, i.e. the lchan could not be
activated, immediately signal Assignment Failure to the MSC (in
handle_chan_nack()).
In handle_chan_nack(), adjust log: instead of waiting for timeout, we now
signal Assignment Failure.
Drop misleading logging from bsc_assign_fail(): instead of transmitting the
Assignment Failure message, it actually signals an FSM event. Leave logging of
that to the FSM logging.
Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270
Diffstat (limited to 'src/osmo-bsc/osmo_bsc_api.c')
| -rw-r--r-- | src/osmo-bsc/osmo_bsc_api.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/osmo-bsc/osmo_bsc_api.c b/src/osmo-bsc/osmo_bsc_api.c index 51fbdd31b..f3c36c3c8 100644 --- a/src/osmo-bsc/osmo_bsc_api.c +++ b/src/osmo-bsc/osmo_bsc_api.c @@ -425,8 +425,9 @@ void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) /*! BSC->MSC: Assignment of lchan failed. */ void bsc_assign_fail(struct gsm_subscriber_connection *conn, uint8_t cause, uint8_t *rr_cause) { - LOGP(DMSC, LOGL_INFO, "Tx MSC ASSIGN FAIL\n"); - osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, NULL); + LOGPFSML(conn->fi, LOGL_ERROR, "Assignment failure: BSSMAP: '%s' from RR: '%s'\n", + gsm0808_cause_name(cause), rr_cause ? rr_cause_name(*rr_cause) : "(none)"); + osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, &cause); } /*! BSC->MSC: RR conn has been cleared. */ |