aboutsummaryrefslogtreecommitdiffstats
path: root/tests/tlv/tlv_test.c
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2023-04-28 17:33:36 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2023-05-02 15:20:53 +0200
commitbeb7c1741ee8f39a96d5fab6845f415b232d5fb4 (patch)
tree340768cd9971a759efc434cffcd65ead5a5c3f2f /tests/tlv/tlv_test.c
parente2217ee098426f6ea67bb3f60ccea5bd39628c01 (diff)
Fix 'Fix parsing of TLV_TYPE_SINGLE_TV'
A commit was merged recently attempting to fix decoding of TLV_TYPE_SINGLE_TV. It did mostly a good job, but missed updating the o_tag pointer used to fill in the structures. This commit fixes that specific part missing. Fixes: 559a6ee68359dab691a483573982e6f8c6439ae2 Change-Id: Id619459c17976b77cd2c7e4179123bb06807285c
Diffstat (limited to 'tests/tlv/tlv_test.c')
-rw-r--r--tests/tlv/tlv_test.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/tlv/tlv_test.c b/tests/tlv/tlv_test.c
index aaa86a3a..8e8bd603 100644
--- a/tests/tlv/tlv_test.c
+++ b/tests/tlv/tlv_test.c
@@ -470,14 +470,12 @@ static void test_tlv_type_single_tv(void)
rc = tlv_parse(&tp, &att_tlvdef, buf, sizeof(buf), 0, 0);
OSMO_ASSERT(rc == 1);
- OSMO_ASSERT(!TLVP_PRESENT(&tp, SAMPLE_SINGLE_TV_IE)); //FIXME!
+ OSMO_ASSERT(TLVP_PRESENT(&tp, SAMPLE_SINGLE_TV_IE));
val = TLVP_VAL(&tp, SAMPLE_SINGLE_TV_IE);
- OSMO_ASSERT(!val); //FIXME!
-#if 0
+ OSMO_ASSERT(val);
OSMO_ASSERT(val == &buf[0]);
OSMO_ASSERT(*val == buf[0]);
OSMO_ASSERT((*val & 0x0f) == exp_val);
-#endif
}
int main(int argc, char **argv)