2004-05-14 02:46 gerald * packaging/nsis/ethereal.nsi: Make the GTK2 interface the default. Remove GTK-Wimp from the GTK2 section. I originally tried to make it disabled by default (using "Section /o"), but this caused odd behavior in the installer. 2004-05-14 01:58 sahlberg * packet-kerberos.c: add dissection of pa-prov-srv-location preauthentication type used by packetcable. 2004-05-13 22:25 jmayer * configure.in: Paul Smith: bugfix: make loadable module support work when cross compiling 2004-05-13 22:09 jmayer * acinclude.m4: Fix --with-krb5 when given a directory 2004-05-13 21:56 gerald * packet-scsi.c: From Dinesh Dutt: Mode Sense (10) and Mode Select (10) bugfixes. 2004-05-13 21:56 jmayer * configure.in: Thomas Anders: fix usage of brk5_dir 2004-05-13 20:54 obiot * Makefile.nmake, packaging/nsis/Makefile.nmake: Fix a typo (seperate should be separate). 2004-05-13 20:45 obiot * NEWS: WBXML OPAQUE is not really a protocol. Add RTCP to updated protocols. 2004-05-13 20:20 gerald * AUTHORS, Makefile.common, NEWS, packet-ldp.c, packet-ldp.h, packet-mpls-echo.c, packet-ntp.c, packet-ntp.h, epan/Makefile.common: From Carlos Pignataro: Add MPLS Echo support. 2004-05-13 20:02 gerald * NEWS: Add a note about generic media dissection, and add WBXML updates. 2004-05-13 17:26 obiot * packet-wbxml.c: Fix a typo in the CHANNEL document ID. 2004-05-13 17:24 obiot * packet-rtcp.c: As noted by Frédéric Huet, RFC1889 section 6.4 says: "The list of items in each chunk is terminated by one or more null octets, the first of which is interpreted as an item type of zero to denote the end of the list, and the remainder as needed to pad until the next 32-bit boundary. A chunk with zero items (four null octets) is valid but useless." Process chunks with four zero octets as "padding". 2004-05-13 16:57 jmayer * acinclude.m4: Thomas Anders: Don't add library paths twice 2004-05-13 16:34 jmayer * prefs.h: Remove comma at end of enum 2004-05-13 15:28 ulfl * prefs.c, prefs.h, gtk/gui_prefs.c, gtk/main.c, gtk/main.h: Win32 only: Preference setting to open a console window, one of: never (default), automatic (like before), always 2004-05-13 13:49 sahlberg * packet-isns.c: dissect the authentication-block flag bit 2004-05-13 13:39 sahlberg * packet-isns.c: isns standard is unclear here but some servers do respond with a 0 length PGT in DevAttrRegRsp if the DevAttrReg contained it. Allow DevAttrRegRsp to contain 0 length PGTs. 2004-05-13 13:28 sahlberg * packet-isns.c: update to isns: make it handle PGT with length 0 properly only try to dissect the attributes if this is the first PDU in a sequence. 2004-05-13 12:19 ulfl * gtk/http_stat.c: fixed httpstat_reset, so reloading a capture file won't increase statistic values more and more 2004-05-13 10:10 ulfl * epan/: Makefile.nmake, doxygen.cfg: use sed to create a temporary doxygen config file, to get the version number from ..\config.nmake 2004-05-13 09:04 ulfl * NEWS: we now have export dialogs, and we can change the main windows layout 2004-05-13 03:34 gerald * NEWS, config.nmake, configure.in, epan/doxygen.cfg: Bump the version up to 0.10.4. Preliminary updates to the NEWS file. Updates welcome. 2004-05-12 20:20 guy * packet-mpls.c: From Carlos M. Pignataro: MPLS PW Control Channel Header support. 2004-05-12 19:55 guy * packet-bacnet.c: Make the calls to build the protocol tree regardless of whether we're building one or not - we have to do some of that work anyway, so we know the offset of the payload and so that we call sub-dissectors, and the easiest way to do that is to do all the work (you make more procedure calls that way than you'd like, but the procedures at least return quickly when they find they've been passed a null pointer; hopefully that won't add too much CPU time to dissection of BACNET traces on the first pass). Don't use "proto_tree_add_uint_format()" in a case where it's not necessary - and fix the field being used not to have a bitmask, as it's not a bitfield. 2004-05-12 19:23 guy * packet-time.c: From Thomas Anders: display the time in time protocol packets as a date and time rather than as a raw seconds-since-1900-01-01-00:00:00 GMT. Put it into the protocol tree as a named field (the named field was there but wasn't being used). Give the RFC number for the protocol in a comment. 2004-05-12 09:40 guy * packet-ptp.c: You can hand a string to "col_add_str()" as an argument - or to "col_set_str()", for that matter. Eliminate a compiler warning by initializing a variable. Don't use "match_strval()" on values you don't know for certain are in the value_string table - use "val_to_str()", so that you don't get a null pointer if the value isn't in that table. ("Know for certain" meaning "the code has made sure it's a value that's in the table", not "the protocol spec says the field must have one of the values in the table".) 2004-05-12 09:29 guy * packet-3g-a11.c: From Ryuji Somegawa: fix some typos. 2004-05-12 03:37 gerald * AUTHORS, packet-ptp.c, doc/ethereal.pod, epan/Makefile.common: From Dominic Béchaz: IEEE 1588 (Precision Time Protocol) support. 2004-05-11 22:07 jmayer * manuf, FAQ, help/faq.txt: Update manuf and FAQ to current master files 2004-05-11 14:21 nneul * packet-afs-defs.h, packet-afs-macros.h, packet-afs-register-info.h, packet-afs.c, packet-afs.h: add initial support for newer opcodes 2004-05-11 11:27 guy * packet-mq.c: From metatech: - Reassembly of MQ messages spanning several PDU - RESET message 2004-05-11 11:20 guy * packet-ldp.c: From Carlos M. Pignataro: interface parameter and VC type updates from the following internet drafts: o PWE updates: - draft-ietf-pwe3-control-protocol-06.txt - draft-ietf-pwe3-sonet-05.txt - draft-ietf-pwe3-fragmentation-05.txt - draft-ietf-pwe3-fcs-retention-00.txt - draft-vainshtein-pwe3-tdm-control-protocol-extensi-00.txt - draft-ietf-pwe3-vccv-02.txt - draft-ietf-pwe3-iana-allocation-04.txt 2004-05-11 11:19 guy * epan/Makefile.am: From Lars Roland: add the libethereal .def file to the list of files included in the distribution. 2004-05-11 11:04 guy * epan/.cvsignore: From Lars Roland: ignore the libethereal DLL and export file in CVS. 2004-05-11 10:57 guy * packet-ber.c: Add a colon to the top-level item for a sequence or set, to separate the name for the sequence or set from any summary items added as the members of the sequence or set are dissected. 2004-05-11 10:55 guy * packet-rtsp.c: A line is an RTSP request merely because it begins with a string that's an RTSP request name - either the line has to end after the request name or there has to be a whitespace character after the request name. 2004-05-11 07:30 guy * packet-kerberos.c: Kerberos encryption types are ASN.1 integers, meaning signed values, and at least one mail message: http://mailman.mit.edu/pipermail/kerberos/2004-February/004653.html shows some of the weird Microsoft encryption type values logged by some KDC implementation as negative integers. Also, show them as decimal in the top-level line for encryption types, just as we do in the lines for each encryption type. 2004-05-11 07:26 guy * packet-ber.c: In the top-level summary item for a bitstring, show the names of the bits as a parenthesized, comma-separated lists - using only blanks as separators doesn't work well if the names themselves have blanks in them, as some of them do. Note that "dissect_ber_integer()" won't work well if the length of the item isn't appropriate for the field, e.g. a length > 4 for an FT_INTn or FT_UINTn field. 2004-05-11 02:02 gerald * packet-spnego.c: Make sure next_level_value isn't NULL before trying to access one of its members. 2004-05-11 01:05 ulfl * config.nmake: add "configurable" path to doxygen.exe 2004-05-11 01:00 ulfl * epan/Makefile.am: add the new doxygen.cfg file to the EXTRA_DIST files 2004-05-11 00:56 ulfl * epan/doxygen.cfg: experimental doxygen support 2004-05-11 00:53 ulfl * epan/Makefile.nmake: adding a doxygen target 2004-05-10 23:13 ulfl * epan/proto.h: prepared for generate documentation using doxygen, added lot's of new (hopefully correct) comments 2004-05-10 22:20 obiot * packet-http.c, util.c, util.h: As noted by Thomas Anders, the Heimdal libroken library has a base64_decode() function with a different signature than the one defined in util.c/util.h. For this reason, we need to rename our base64_decode() routine. The routine is now called epan_base64_decode(). 2004-05-10 22:14 obiot * epan/tvbuff.c: From Jerry Talkington: speed up tvb_uncompress() by increasing the minimal and default uncompression buffer. 2004-05-10 14:02 ulfl * epan/proto.h: use GNUC_FORMAT_CHECK in every appropriate function 2004-05-10 08:29 ulfl * epan/proto.h: first try to get rid of annoying double definition of the proto_tree_add_xy_fromat functions, because of GNUC printf format checks 2004-05-10 03:30 gerald * Makefile.common: Add ps.c to BUILT_SOURCES, so that "make distcheck" doesn't burst into flames. 2004-05-09 18:54 guy * epan/: Makefile.nmake, libethereal.def: From Lars Roland: fix some MSVC build problems. 2004-05-09 10:03 guy * AUTHORS, Makefile.am, Makefile.common, Makefile.nmake, alert_box.c, capture.c, config.h.win32, config.nmake, configure.in, file.c, follow.h, packet-ansi_a.h, packet-ansi_map.h, packet-dcerpc.h, packet-fc.h, packet-gsm_a.h, packet-gsm_map.h, packet-h225.h, packet-isup.h, packet-mtp3.h, packet-rpc.h, packet-smb-sidsnooping.h, packet-wsp.h, prefs-int.h, prefs.h, print.h, smb.h, tap-ansi_astat.c, tap-gsm_astat.c, tap-h225counter.c, tap-rpcstat.c, tap-smbsids.c, tap-smbstat.c, tap-wspstat.c, tap.h, tethereal.c, doc/Makefile.nmake, epan/Makefile.common, epan/Makefile.nmake, epan/libethereal.def, epan/plugins.h, epan/proto.h, epan/resolv.h, epan/dfilter/dfilter.h, epan/ftypes/ftypes.h, gtk/Makefile.nmake, gtk/follow_dlg.c, packaging/nsis/Makefile.nmake, packaging/nsis/ethereal.nsi, plugins/mgcp/Makefile.nmake, plugins/mgcp/packet-mgcp.c: From Lars Roland: add support for building a libethereal.dll with MSVC: add a config.nmake option to control whether to build libethereal.dll or not; remove "./wiretap" from PATH to prevent problems due to wrongly-loaded files; build dissector.lib with MSVC; move "print.c" and "ps.c" to the dissector helpers, as "print.c" imports variables from packet-frame.c and packet-data.c, which are in libethereal; move "g711.c" out of the dissector helpers, as they're used only by Ethereal in a tap, not in Tethereal or in any dissector; add a .def file for libethereal; arrange to declare global variables exported from libethereal with "__declspec(dllimport)" when building programs that import those variables; update the NSIS installer. Make the "configure" script define ETH_VAR_IMPORT as "extern". 2004-05-09 09:26 ulfl * epan/proto.h: added changed some comments to better reflect current "behaviour" 2004-05-09 09:07 obiot * packet-http.c: Move the creation of the de-chunked data source to the place where the data is being dechunked; this will highlight the correct bytes when selecting the compressed data from the protocol tree. Add comments for explaining what happens where. Strip trailing white space. 2004-05-09 08:29 guy * epan/ftypes/ftypes.c: From Graeme Hewson: Fix off-by-one errors in slice_func 2004-05-09 08:25 guy * epan/ftypes/ftype-string.c: From Graeme Hewson: "aim.fnac.ssi.buddyname==ab" caused segmentation fault. Fix handling of unparsed value as byte string. 2004-05-09 08:17 guy * epan/dfilter/semcheck.c: From Graeme Hewson: Error if protocol specified on RHS of display filter comparison. If user specified "fc", they probably intended a byte value rather than the fibre channel protocol; fix makes mistake clear. Fix assertion failure with range on LHS of display filter comparison and field on RHS. 2004-05-09 07:01 ulfl * gtk/: menu.c, proto_draw.c: make notebook tabs scrollable, if not all fits into the pane, enable a popup menu on the notebook tabs, with the tab labels 2004-05-08 22:03 guy * epan/dfilter/scanner.l: From Graeme Hewson: get rid of unnecessary check (it's necessary for octal, as the maximum of 3 octal digits can be more than 0377, but not necessary for hex, as the maximum of 2 hex digits can't be more than 0xff). 2004-05-08 21:43 gerald * epan/Makefile.am: Don't try to include epan/config.h.win32 in the distribution. 2004-05-08 21:31 obiot * packet-dcm.c: From Richard Coe: only create a conversation on the first packet of a DICOM conversation. 2004-05-08 17:54 tuexen * packet-sctp.c: Fixed problems of handling PkTDRP chunks. 2004-05-08 13:39 obiot * packet-dcm.c: The DICOM dissector assumed that any existing conversation was a DICOM conversation. Fix this by checking whether there is conversation data for the DICOM dissector. If not, the conversatioj is not a DICOM conversation, and we do not attempt at dissecting it as DICOM. 2004-05-08 12:59 obiot * packet-http.c: D'oh - remove leading '+' marks from manually applying a patch. 2004-05-08 12:54 obiot * packet-http.c: From Jerry Talkington: * Add comments on why we may not use tvb_free() at some places. * Add a new data source for a reassembled chunked entity. 2004-05-08 11:40 obiot * epan/dfilter/README.dfilter: Add the valuable input from Gilbert Ramirez in reply to questions I had when thinking at implemeting an "in" display filter operation. 2004-05-08 10:28 obiot * packet-http.c: Fix a tvb_free() of a tvbuffer created as a tvb_new_subset(), which caused double freeing of memory. Add a comment at the tvb_new_subset() call so future developers will be warned. Always add the compressed entity as an item in the protocol tree, so it can be exported by selecting the packet bytes. 2004-05-08 08:49 guy * AUTHORS, packet-dcm.c, doc/ethereal.pod, epan/Makefile.common: From Rich Coe: DICOM support. 2004-05-07 18:15 obiot * epan/tvbuff.c: Memory management of tvb_uncompress() needs tvb_set_free_cb(). 2004-05-07 17:36 obiot * packet-http.c: Add Uncompressed/Compressed to the compressed data source label for clarity. 2004-05-07 12:29 tpot * packet-dcerpc.c, packet-smb-sidsnooping.c: Compile fixes for change to dcerpc_info structure. 2004-05-07 12:15 ulfl * gtk/: hostlist_table.c, main.c, menu.c, service_response_time_table.c: rename context menu items: Match -> Apply as Filter Prepare -> Prepare a Filter and prepended a ... at appropriate submenu items 2004-05-07 11:34 ulfl * epan/value_string.h: did some code cleanup, added some comments from value_string.c 2004-05-07 11:24 ulfl * packet-dcerpc.c, packet-dcerpc.h, tap-dcerpcstat.c, gtk/dcerpc_stat.c: replace info field "gboolean request" by "guint8 ptype", so the packet type can be better detected 2004-05-07 11:07 ulfl * packet-dcerpc.c: tag some protocol items as generated 2004-05-07 08:12 ulfl * gtk/recent.h: removed obsolete comments 2004-05-07 08:02 guy * AUTHORS, packet-bootp.c, doc/ethereal.pod: From Thomas Anders: - support vendor-specific DHCP option 43 interpretation per CableLabs standards (for compliant cable devices, identified by option 60) - support DHCP option 122 with all suboptions (RFC 3495: CableLabs Client Configuration; RFC 3594: PacketCable Security Ticket Control) - update DHCP options list: add options 117-122 (see http://www.iana.org/assignments/bootp-dhcp-parameters) - minor enhancements for DHCP options 2, 82 - minor code cleanup 2004-05-06 20:50 obiot * epan/config.h.win32: Get rid of epan/config.h.win32. 2004-05-06 20:48 obiot * Makefile.nmake, config.h.win32, epan/Makefile.nmake, epan/dfilter/Makefile.nmake: Get rid of epan/config.h.win32. Fix a missing ZLIB_CFLAGS in epan/Makefile.nmake. 2004-05-06 17:40 obiot * epan/tvbuff.c: From Kendy Kutzner: a char should be compared with '\0', not NULL. 2004-05-06 10:24 sahlberg * AUTHORS, packet-isns.c: add tcp reassembly to isns also make isns not dump core just because someone has encoded an integer in 0 bytes. still need to add reassembly of fragmented pdus (first fragment/last fragment) but have example captures of that so thats for tomorrow. 2004-05-05 20:12 ulfl * gtk/endpoint_talkers_table.c: various context menu related changes 2004-05-05 17:28 obiot * AUTHORS, packet-slsk.c, doc/ethereal.pod: From Kendy Kutzner: use the tvb_uncompress() routines instead of the own SLSK decompression routine. 2004-05-05 09:30 guy * packet-aim-bos.c, packet-aim-messaging.c, packet-aim.c, packet-aim.h: Use "tvb_reported_length_remaining()" in "until the end of the packet" loops, so we mark frames as short if they've been cut short by a snapshot length. The user class in buddy list TLVs appears to be 2 bytes, in at least some captures; make "dissect_aim_userclass()" take the user class value, and the length of the user class field, as arguments, and have the caller fetch the value. Also, display the numerical value of the user class in hex, as it's a bitset. Fix the messaging dissector to put stuff under the top-level item rather than at the top level. Fix a typo. Clean up indentation. 2004-05-05 08:49 guy * gtk/main.c: Note that hiding panes in the paned widgets doesn't do what we want with GTK+ 1.2[.x], although it does so with GTK+ 2.x. 2004-05-05 07:31 guy * prefs.c, prefs.h, gtk/layout_prefs.c: Use an enum when initializing "prefs.gui_layout_type". Add an entry to that enum at the end and use that to generate the value of LAYOUT_QTY. 2004-05-05 06:55 obiot * AUTHORS, packet-http.c, epan/tvbuff.c, epan/tvbuff.h: From Jerry Talkington: - Helper functions for uncompressing compressed tvbuffers. - Compressed content coding dissection in HTTP. 2004-05-05 03:05 gerald * packet-mmse.c: Check the value length in get_encoded_strval(), so that we don't feed a length less than 1 to tvb_get_string(). 2004-05-04 21:12 etxrab * packet-sip.c: Fixed a copy-paste error 2004-05-04 21:08 guy * gtk/: main.c, menu.c: Use "main_widgets_show_or_hide()" to control the visibility of all the main window widgets, rather than requiring a relayout if the visibility of the main toolbar, filter toolbar, or statusbar is changed. Clean up indentation. 2004-05-04 20:49 guy * gtk/: main.c, main.h, menu.c: If all we're doing is changing the visibility of a pane, we don't have to re-lay-out the main window, we just need to change the visibility of the appropriate widgets - that reduces the amount of drawing done, speeding things up a little and reducing flicker. 2004-05-04 20:40 guy * gtk/main.c: Display "main_second_pane" if, and only if, both widgets in it are displayed; otherwise, if you hide both of them (e.g., hiding the packet details and packet data panes in the default layout), "main_second_pane" remains but as a gray blob, rather than having the remaining pane take over the entire window. 2004-05-04 20:04 guy * gtk/menu.c: Put the coloring rules back under View. 2004-05-04 17:46 tuexen * packet-sctp.c: Clean up some variable names. 2004-05-04 09:12 guy * packet-sndcp.c: Get rid of a trailing comma. 2004-05-04 09:03 guy * packet-gprs-llc.c: Fix some typos, and get rid of an inapplicable boilerplate comment. Get rid of some trailing commas. Show the SAPI symbolically in the top-level item for the address field. 2004-05-04 08:30 guy * packet-ntlmssp.c: We don't need to save the challenge values as per-conversation or per-packet information. 2004-05-04 07:24 guy * packet-text-media.c: Add the RFC 3023 XML media types. 2004-05-04 07:12 guy * packet-http.c: Chunked data reassembly *is* done in "req_resp_hdrs_do_reassembly()". That means that the description of the "desegment HTTP bodies" preference setting shouldn't speak of it causing the dissector to trust the content length (which makes it somewhat long anyway), as it also desegments chunked bodies that lack a Content-Length header; expand the tooltip for the preference to speak of that. 2004-05-04 06:53 guy * req_resp_hdrs.c: "tvb_get_string()" returns a pointer to "g_malloc()"ed data, so you have to free it when you're done with it. It never returns a null pointer, however, so there's no need to check for that. Clean up the code to process Transfer-Encoding a bit. 2004-05-04 06:21 guy * packet-http.c: Note that the way we currently handle the chunked encoding doesn't work if the HTTP data takes more than one packet. 2004-05-04 06:14 guy * packet-dcerpc.c: Display a server boot time of 0 as "Unknown" (as that's what's sent when the client sends its first PDU to the server, and when the endpoint mapper sends back an error PDU on behalf of the server, because they don't know the server's boot time - it's unlikely that the server was booted precisely at January 1, 1970, 00:00:00 GMT). Clean up some white space. 2004-05-04 06:01 guy * packet-cops.c: Don't assume the length field in a PacketCable object is sane. 2004-05-03 23:47 guy * doc/ethereal.pod, gtk/menu.c: The GNOME HIG calls the View menu item for the status bar "Statusbar", not "Status Bar". 2004-05-03 23:37 guy * doc/ethereal.pod: The "View" menu has items to show or hide the three display panes; it calls the middle pane the "Packet Details" pane, which is perhaps less geeky than "Protocol Tree". Update the man page to call it the "packet details". Update the description of the menu items to more closely reflect current reality. 2004-05-03 23:34 guy * gtk/menu.c: Move "Coloring Rules" from "View" to "Edit" - you're editing the set of coloring rules Ethereal uses (yes, those views affect the way the packets are displayed, but that also applies to at least some the preferences, which are in Edit->Preferences). Get rid of the "Show" menu under "View", moving the items up to the main "View" menu, as per the GNOME HIG. Give some of them accelerators, and change the accelerators for some other "View" items to avoid collisions. 2004-05-03 22:55 guy * packet-ber.c: Squelch some compiler warnings. 2004-05-03 22:15 ulfl * gtk/: endpoint_talkers_table.c, endpoint_talkers_table.h, hostlist_table.c, hostlist_table.h: add name resolution to both endpoint and conversation lists 2004-05-03 19:03 guy * packet-dcerpc-lsa-ds.c: From Jean-Baptiste Marchand: add some more operation names. 2004-05-03 18:53 guy * make-reg-dotc, make-tapreg-dotc: Add an RCS ID. 2004-05-03 18:51 guy * register.h: "register_all_tap_menus()" no longer exists. 2004-05-02 21:35 guy * packet-chdlc.c: From Carlos Pignataro: handle the padding byte between the protocol type field and playload for OSI network layer packets. 2004-05-02 21:16 ulfl * gtk/: hostlist_eth.c, hostlist_fc.c, hostlist_fddi.c, hostlist_ip.c, hostlist_ipx.c, hostlist_table.c, hostlist_table.h, hostlist_tcpip.c, hostlist_tr.c, hostlist_udpip.c, menu.c: build a endpoints (aka hostlist) dialog, which shows all kinds of endpoints in a notebook 2004-05-02 21:10 ulfl * gtk/endpoint_talkers_table.c: slightly changed to prevent naming conflict with hostlist_table.c 2004-05-02 17:25 ulfl * gtk/: endpoint_talkers_eth.c, endpoint_talkers_fc.c, endpoint_talkers_fddi.c, endpoint_talkers_ip.c, endpoint_talkers_ipx.c, endpoint_talkers_table.c, endpoint_talkers_table.h, endpoint_talkers_tcpip.c, endpoint_talkers_tr.c, endpoint_talkers_udpip.c, menu.c: build a conversation (aka endpoint_talkers) dialog, which shows all kinds of conversations in a notebook 2004-05-02 15:23 ulfl * gtk/hostlist_table.c: after retapping, immediately redraw table to avoid annoying redraw even on "static" capture files 2004-05-02 15:04 ulfl * file.c: bugfix: reset the tap listeners, when the capture file is closed 2004-05-02 08:54 ulfl * gtk/: layout_prefs.c, ui_util.c, ui_util.h: move function xpm_to_widget() from layout_prefs to ui_util, as this can be useful not only in layout_prefs 2004-05-02 07:31 guy * epan/ftypes/ftype-string.c: Make sure the character values we pass to "isprint()" aren't sign-extended. 2004-05-02 00:43 guy * autogen.sh: Some versions of libtool stick extra stuff after the version number, e.g. some versions from the FreeBSD ports collection add "-freebsd-ports". Match non-white-space text after the version number. 2004-05-01 23:56 guy * epan/strutil.c: GLib 1.2[.x]'s "g_string_free()" doesn't return a value. 2004-05-01 22:55 obiot * file.c, simple_dialog.h, gtk/simple_dialog.c: The display filter engine can return an error message that is not safe when using GTK2 code for rendering the error. In order to correctly render the error message, it must be XML escaped. TODO: track down the remaining places where this XML escaping is required, and fix it there too (not sure if they exist though). 2004-05-01 21:34 guy * tap-sipstat.c: From Lars Roland: add message counts to the SIP statistics. 2004-05-01 21:33 guy * doc/: ethereal.pod, tethereal.pod: From Lars Roland: document the SIP statistics. 2004-05-01 21:18 guy * AUTHORS, Makefile.common, packet-mq-pcf.c, packet-mq.c, packet-mq.h, epan/Makefile.common: From metatech: for the MQ dissector: - PDU desegmentation; - XA messages; - Netbios, SPX, HTTP support; - Subdissector table; dissector for the MQ Programmable Command Formats protocol. 2004-05-01 21:04 obiot * print.c: Add escaping of an apostrophe in XML output. 2004-05-01 20:46 obiot * epan/: strutil.c, strutil.h: Add an XML escaping routine: xml_escape() 2004-05-01 20:15 obiot * epan/proto.h: Squelch a compiler warning (extraneous extern on struct). Fix the PROTO_ITEM_IS_XXX and PROTO_ITEM_SET_XXX macros by replacing the if(x) with trigraphs so the macros can still be used in subsequent conditional tests. 2004-05-01 19:24 ulfl * gtk/: endpoint_talkers_table.c, hostlist_table.c: bugfix: remove all elements on "tree reset", don't keep the first entry in the list 2004-05-01 18:40 ulfl * gtk/proto_hier_stats_dlg.c: GTK2: expand all tree elements when opening dialog 2004-05-01 18:39 ulfl * epan/proto.h: prevent null pointer exception 2004-05-01 17:22 obiot * gtk/: menu.c, color_dlg.c: From Richard Urwin: ensure that the initial colour is appropriate in all cases. The colouring rules are also available now when no packets have been captured or loaded from file. 2004-05-01 17:02 obiot * packet-ranap.c: From Michael Lum: - Write to the INFO column only if it is visible. - Add the RANAP message to the protocol tree. 2004-05-01 15:15 ulfl * file.c, packet-tcp.c, print.c, epan/proto.c, epan/proto.h, gtk/proto_draw.c: add PROTO_ITEM_SET_HIDDEN() and PROTO_ITEM_SET_GENERATED(), this sets flags for later rendering of the field data 2004-05-01 14:22 etxrab * packet-rtp-events.c: From Martin Mathieson :small patch for rtp-events that shows in the info column which packets that mark the end of events 2004-05-01 14:19 etxrab * packet-sip.c: From Martin Mathieson Update of SIP resend detection. 2004-05-01 06:21 ulfl * tools/win32-setup.sh: minor changes 2004-05-01 00:34 sahlberg * packet-dcerpc-netlogon.c: more deltatypes 2004-04-30 22:19 guy * packet-spnego.c: Clean up the creation of the tvbuff for a mechToken so that the length and reported length are both no larger than the length of the token. 2004-04-30 21:33 guy * packet-media.c: Get rid of a compiler warning. 2004-04-30 21:32 guy * gtk/layout_prefs.c: GCC warning removed. (ANSI C says it's "implementation-defined" what integral type an enum corresponds to; I guess GCC says "unsigned int" and MSVC says "int".) 2004-04-30 21:11 guy * packet-cops.c: Make some floating-point fields FT_FLOAT, rather than FT_UINT32. 2004-04-30 17:07 obiot * AUTHORS, packet-http.c, packet-media.c, packet-wsp.c, packet-multipart.c, epan/Makefile.common: Add a generic media dissector. The dissectors trying to find a suitable media dissector for a given media type (value of a Content-Type header) must provide the logic to fall-back to this media dissector upon no match. Note that you must set the pinfo->match_string to the media type name, and if the media type is specified with parameters, then those parameters can be added to pinfo->private_data. If there are no parameters, or the parameter decoding is not implemented, you must set pinfo->private_data to NULL. Known TODOs: - Fix the WSP parameter handling so it accompanies any media dissector. Simplest approach is to retrieve the header field label from the WSP Content-Type field and to search for a semicolon in it (or by using the string length of the content type string representation). - Verify that that subdissection always works in the WSP dissector, even when the protocol tree is not being built. - Implement the media dissector in the remaining dissectors that use the media type string table. 2004-04-30 15:26 obiot * packet-http.c: Beware: sscanf() only operates on C strings. A pointer returned by tvb_get_ptr() is not necessarily NULL terminated, hence a NULL terminated string must be generated from the returned pointer. 2004-04-30 07:56 ulfl * doc/README.xml-output: updated to reflect the latest changes of exporting PDML in ethereal 2004-04-30 06:56 ulfl * epan/: proto.h, dfilter/dfilter.c: removed unused things 2004-04-30 06:30 ulfl * gtk/layout_prefs.c: removed warnings of GTK1 compilation 2004-04-30 06:24 ulfl * packet-acse.c, packet-cops.c, packet-pres.c, packet-spnego.c, packet-tcp.c: MSVC warnings removed 2004-04-30 05:25 ulfl * gtk/layout_prefs.c: MVSC warning removed 2004-04-30 00:40 guy * prefs.c, prefs.h, gtk/layout_prefs.c, gtk/layout_prefs.h: The layout types and pane types don't depend on GTK+, so move their definitions to "prefs.h". Use them, rather than (incorrect) raw numerical values, when initializing the preferences. 2004-04-30 00:22 guy * gtk/layout_prefs.c, gtk/main.c, image/icon_layout_1.xpm, image/icon_layout_2.xpm, image/icon_layout_3.xpm, image/icon_layout_4.xpm, image/icon_layout_5.xpm, image/icon_layout_6.xpm: Squelch some compiler warnings. Clean up white space. 2004-04-29 22:40 sahlberg * AUTHORS, Makefile.common, packet-dcerpc-efs.c, packet-dcerpc-efs.h, epan/Makefile.common: From JBM Dissection of the EncryptedFileSystem dce/rpc interface. This dissector also contains a complete and fully tested IDL definition for the entire interface. 2004-04-29 20:28 obiot * AUTHORS: From Jerry Talkington: HTTP chunked transfer coding. 2004-04-29 20:26 obiot * packet-http.c: From Jerry Talkington: move the chunks subtree to the HTTP protocol tree. 2004-04-29 20:21 gerald * AUTHORS, packet-ppp.c: From Carlos Pignataro: PPP OSI Network Layer Control Protocol [RFC1377] support. 2004-04-29 18:11 tuexen * packet-sctp.c: Fixed a typo reported by Berward Meyknecht. 2004-04-29 17:03 ulfl * prefs.c, prefs.h, gtk/Makefile.am, gtk/Makefile.common, gtk/layout_prefs.c, gtk/layout_prefs.h, gtk/main.c, gtk/prefs_dlg.c: added selection of different main window pane layouts, also added some preferences and a new preference page for this 2004-04-29 16:49 ulfl * Makefile.am, image/icon_layout_1.xpm, image/icon_layout_2.xpm, image/icon_layout_3.xpm, image/icon_layout_4.xpm, image/icon_layout_5.xpm, image/icon_layout_6.xpm: added pane layout icons coming from pan (gnome newsreader) 2004-04-29 16:35 ulfl * gtk/gui_prefs.c: fixed a typo 2004-04-29 16:33 ulfl * packet-tcp.c: added "[CHECKSUM INCORRECT]" to the info column 2004-04-29 11:58 sahlberg * packet-rpc.c: technically speaking rpc duplicate replies are not retransmissions only the request is tecnically a restransmission the reply is technically not a retransmission (since it is a new reply to the retransmitted request) mark duplicated replies as RPC duplicate ... instead of as RPC retransmission thanks to Cal for pointing this out. 2004-04-29 08:13 sahlberg * packet-isns.c: update to isns and prettify is a bit. 2004-04-28 20:56 guy * gtk/proto_draw.c: Note that a custom widget might be the right way to speed up the construction of the hex dump pane (so we don't need a progress bar(!) while it's being filled in), and might have some other UI advantages as well. 2004-04-28 20:47 guy * gtk/capture_dlg.c: Change the punctuation in one tooltip (I think "select the desired one" would be an independent clause, so it should be separate from the other clause with a semicolon). Note that, in that tooltip, in some cases "link-layer types" would be appropriate and in others "link-layer header types" might be more appropriate. 2004-04-28 19:13 gram * gtk/capture_dlg.c: Minor wording changes in tooltips. 2004-04-28 18:39 ulfl * gtk/capture_dlg.c: added tooltips for various input fields 2004-04-28 17:50 obiot * doc/dfilter2pod.pl: When building the Ethereal documentation on MSVC++/cygwin the cygwin perl will not swallow the '\r\n' line end sequence when invoking chomp(), but instead the '\r' character will remain. For this reason, chomp() cannot be used and global removal of '\r' and '\n' characters must be used instead, like in: $_ =~ s/[\r\n]//g; 2004-04-28 15:38 gerald * AUTHORS, packet-ldp.c, doc/ethereal.pod: From Carlos Pignataro: Graceful Restart Mechanism for LDP [RFC3478] Fault Tolerance for LDP [RFC3479] Update IANA assigned Status codes Fixed some typos. 2004-04-28 05:47 guy * AUTHORS, doc/ethereal.pod, wiretap/file_access.c: From Joe Marcus Clarke: force the standard output to be in binary mode on Windows. 2004-04-27 19:54 guy * packet-aim.h: Declare "dissect_aim_userclass()" as it's used in files other than "packet-aim.c". 2004-04-27 19:16 ulfl * gtk/: main.c, recent.c, recent.h: Freely adjustable status line separations. 2004-04-26 21:11 obiot * packet-aim.c: From Jelmer Vernooij: Add 2 missing header fields. 2004-04-26 19:08 tuexen * packet-sctp.c: - added a hidden field sctp.initiate_tag - expanded data for tapping. 2004-04-26 18:21 obiot * packet-aim-admin.c, packet-aim-adverts.c, packet-aim-bos.c, packet-aim-buddylist.c, packet-aim-chat.c, packet-aim-directory.c, packet-aim-generic.c, packet-aim-icq.c, packet-aim-invitation.c, packet-aim-location.c, packet-aim-messaging.c, packet-aim-popup.c, packet-aim-signon.c, packet-aim-ssi.c, packet-aim-translate.c, packet-aim-userlookup.c, packet-aim.c, packet-aim.h: From Jelmer Vernooij: Add support form extra SNACs. All TLV's are now recognized. 2004-04-26 17:21 obiot * tools/win32-setup.sh: Some of the DLLs from the developer ZIP archives don't have the executable bit set. As a result, tethereal cannot run for the generation of the protocol field list for the ethereal-filter documentation. Fix this issue when unpacking the ddeveloper ZIP archives. 2004-04-26 17:10 obiot * AUTHORS, packet-http.c, packet-wccp.c, req_resp_hdrs.c, doc/ethereal.pod: From Jerry Talkington: - Dissect chunked transfer-coded body in HTTP - Update email address 2004-04-26 15:58 gram * print.c: Look for out of bounds data after calling tvb_length_remaining(). 2004-04-26 07:34 sahlberg * packet-per.c: the the restricted character string has 0 characters in the encoding, then we should NOT do any byte alignments. 2004-04-26 02:09 gram * epan/ftypes/ftype-string.c: When producing a display-filter representation of an FT_STRING*, represent any non-printable character in hex, as "\xNN". We rely on isprint(), which may not be the best solution because it is locale-specific. 2004-04-25 23:45 ulfl * gtk/: main.c, recent.c, recent.h: save the position of the main window panes in the recent file, and restore their position when program is started again (GTK2 only) 2004-04-25 22:34 ulfl * gtk/print_dlg.c: removed some labels 2004-04-25 22:25 jmayer * TODO: Add Heimdal detection 2004-04-25 22:14 obiot * tools/win32-setup.sh: Add code for HTTP proxy detection based on the http_proxy shell variable. Fix the tests with string equal empty_string: "$str" == "" is either "$str" = "" or -z "$str" 2004-04-25 22:14 ulfl * gtk/menu.c: changed the export dialog menu item names (added some descriptions) 2004-04-25 21:54 obiot * TODO: Remove "Display filters: add regexes to strings and byte ranges" as it has been done. Add the possibility to test the packet summary line and the packet dissection to take part in display filter tests: - summary matches "(?i)response" - dissection contains "Unknown" 2004-04-25 21:46 guy * gtk/print_dlg.c: Squelch a compiler warning. 2004-04-25 21:10 obiot * doc/README.plugins: Replace the plugin linkage libs into PLUGIN_LIBS which is generated from the top-level configure.in when running configure. 2004-04-25 21:07 obiot * configure.in, plugins/acn/Makefile.am, plugins/artnet/Makefile.am, plugins/asn1/Makefile.am, plugins/ciscosm/Makefile.am, plugins/docsis/Makefile.am, plugins/enttec/Makefile.am, plugins/giop/Makefile.am, plugins/gryphon/Makefile.am, plugins/irda/Makefile.am, plugins/lwres/Makefile.am, plugins/megaco/Makefile.am, plugins/mgcp/Makefile.am, plugins/pcli/Makefile.am, plugins/rdm/Makefile.am, plugins/rlm/Makefile.am, plugins/rtnet/Makefile.am, plugins/rudp/Makefile.am, plugins/v5ua/Makefile.am: Replace the plugin linkage libs into PLUGIN_LIBS which is generated from the top-level configure.in when running configure. 2004-04-25 20:42 obiot * packet-wsp.c: Fix highlighting of unknown typed parameter bytes (caused an exception to be thrown when expoerting as PDML. Implement the Size parameter (WSP 1.4 encoding). Add the word "parameter" to the parameter header field blurbs. Provide stubs for the not yet implemented typed parameter decoding, in order to make the distiction between a valid undecoded and an unknown (and potentially invalid) typed parameter. 2004-04-25 20:23 guy * packet-gprs-llc.c: From Josef Korelus: use "val_to_str()", not "match_strval()", so we don't crash with incorrect values. 2004-04-25 16:53 jmayer * FAQ, help/faq.txt: Updated to Arpil 20th 2004-04-25 16:52 jmayer * manuf: New entries 2004-04-25 16:04 ulfl * gtk/: main.h, menu.c, print_dlg.c: created new "export" dialogs for the current export file formats 2004-04-25 15:16 jmayer * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, rudp/packet-rudp.c: Fix the fix 2004-04-25 12:04 ulfl * file.c, print.h, gtk/print_dlg.c: put all required data into the print_args, instead of confusing seperation of data 2004-04-25 11:22 jmayer * doc/tethereal.pod: Typo: It's 'item *' not 'item*' 2004-04-25 11:20 jmayer * plugins/rudp/packet-rudp.c: It's proto_register_rudp not proto_reg_rudp 2004-04-25 11:13 jmayer * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, rudp/packet-rudp.c: Give --enable-static a chance to succeed: Some plugins failed to do initialization inside a #ifndef ENABLE_STATIC. 2004-04-25 10:40 etxrab * packet-diameter.c: Add a preferense wether console output should be made in case of unknown command codes, avps or flags etc Default is off. 2004-04-25 10:38 etxrab * xmlstub.c: Use the newly added "report_failure" rather than g_warning if no xml library present. 2004-04-25 09:02 ulfl * doc/Makefile.nmake, doc/editcap.pod, doc/idl2eth.pod, doc/mergecap.pod, doc/tethereal.pod, doc/text2pcap.pod, help/overview.txt: build a list of the input file formats instead of a floating text, added program names to HTML titles, various minor fixes 2004-04-25 08:01 ulfl * gtk/: print_dlg.c, range_utils.c: changed the print dialog, so it will keep the user settings after reopening the dialog and some code cleanup 2004-04-25 04:53 gram * epan/dfilter/scanner.l, tools/lemon/lemonflex-tail.inc: Add support for flex 2.5.31. 2004-04-25 04:01 guy * packet-cops.c: From Dick Gooris: add two extra PacketCable tables (and clean up some white space). 2004-04-24 23:13 ulfl * file.c, print.c, print.h, tethereal.c, gtk/print_dlg.c: some code cleanup of the printing system 2004-04-24 16:47 ulfl * packet-dcerpc.c: some additional output while reassembling fragments, to give the user better information about the fragmenting going on, some other minor changes 2004-04-24 06:46 ulfl * reassemble.c: add fragment length output to the payload output 2004-04-23 23:56 sahlberg * packet-dcerpc-netlogon.c: prettified a few netlogon calls and populate col_info with account names 2004-04-23 23:31 sahlberg * packet-dcerpc-netlogon.c, packet-dcerpc.c: update to netlogon to dissect the timestamps in VALIDATION_UAS_INFO update to dcerpc time_t dissector to print the string "No time specified" when the seconds field is 0xffffffff 2004-04-23 22:34 sahlberg * packet-dcerpc-netlogon.c: update to netlogon, now also decode the delete user/group/alias deltas. 2004-04-23 19:53 ulfl * doc/ethereal.pod: seperated the input file formats into list elements, instead of a "floating text" 2004-04-23 19:47 ulfl * epan/packet.c: added a byte count output to the packet details notebook tabs (only visible if desegmenting activated) 2004-04-23 19:43 ulfl * gtk/proto_draw.c: added a progress dialog box, while processing packet details, activating packet details notebook pages, to avoid desegmenting GUI confusion 2004-04-23 16:46 ulfl * packet-dcerpc-conv.c: some string clarifications 2004-04-23 05:19 guy * Makefile.nmake: From Lars Roland: "make distclean" now removes "cvsversion.h"; new "update_plugin_api" which just builds the "xyzzy" target in the plugins subdirectory but makes sure that "config.h" has been generated, added. 2004-04-23 05:16 guy * gtk/range_utils.c: Mark some parameters as unused (the GTK+ signal calling sequence requires that they be present). 2004-04-23 04:58 guy * packet-tcp.c: From Jon Oberheide: put the "this is a continuation of" item into the protocol tree under the TCP top-level item, rather than at the top level itself, as the protocol hierarchy statistics code can't handle non-protocol items at the top level. 2004-04-23 03:22 guy * gtk/file_dlg.c: Get rid of static forward declaration of "toggle_captured_cb()", as it's no longer defined here. 2004-04-23 03:20 guy * plugins/megaco/packet-megaco.c: Get rid of bogus extra "proto_tree_add_text()" arguments. 2004-04-23 02:00 gerald * gtk/Makefile.am: Add gsm_map_stat.h and mtp3_stat.h to the distribution. 2004-04-22 21:40 ulfl * gtk/: file_dlg.c, print_dlg.c: oops, forgotten to test with GTK1... 2004-04-22 21:29 ulfl * gtk/: file_dlg.c, Makefile.am, Makefile.common, range_utils.c, range_utils.h, print_dlg.c: seperated common packet range code from the save and the print dialog, and put it into new range_utils files. This will avoid: a) duplicate code in save and print dialog and b) yet another code duplication for future dialogs (export, ...) 2004-04-22 20:31 jmayer * packet-ipdc.h: No comma after last element in enum 2004-04-22 20:29 jmayer * packet-rtps.h: No C++ style comments 2004-04-22 20:08 etxrab * gtk/sip_stat.c, packet-sip.c, packet-sip.h: From Martin Mathieson add 2 hidden display filters for SIP - namely: (1) sip.error (for all responses with code >= 300) (2) sip.resend (for all packets that appear to have been retransmitted). A field showing a count of these is shown in the SIP stats window. 2004-04-22 20:02 obiot * acinclude.m4, configure.in: More correct implementation of the --disable-usr-local option. 2004-04-22 17:03 ulfl * file.c, print.c, print.h, print.ps, tethereal.c, gtk/print_dlg.c: added some options and enhancements to the print output: -ps: added formatting hints for ghostscript, so pdf conversion will be much better -ps: print a thin line at the top and bottom of each page -ps/text: add an option to start a new page for every packet (formfeed) 2004-04-22 08:22 guy * AUTHORS, packet-icmpv6.c, packet-ipv6.h: From Shinsuke Suzuki: - sync ICMPv6 Type number with the official assignment (as of Apr 14 2004) - decode MLDv2 query packet 2004-04-21 19:58 etxrab * plugins/megaco/packet-megaco.c: Skipp leading spaces in front of MEGACO and fix dissection of TransactionResponseAck 2004-04-21 17:57 guy * gtk/: gsm_map_stat.h, gsm_map_summary.c, mtp3_stat.c, mtp3_stat.h, mtp3_summary.c: From Michael Lum: ANSI and GSM MAP stats enhancements and cleanups; enhanced parameter dissection related to SS for GSM A-interface and MAP; minor GSM SMS fix; GSM SS enhancements for parameter dissection; MTP3 statistics tap. 2004-04-21 12:08 sahlberg * packet-dcerpc-netlogon.c: update to netlogon to show DsrGetDcNameEx2() Client account name, domain name and site name 2004-04-21 05:53 guy * AUTHORS, packet-ansi_map.c, packet-ansi_map.h, packet-gsm_a.c, packet-gsm_map.c, packet-gsm_map.h, packet-gsm_sms.c, packet-gsm_ss.c, packet-gsm_ss.h, packet-isup.h, packet-mtp3.c, packet-mtp3.h, epan/to_str.c, gtk/Makefile.common, gtk/ansi_map_stat.c, gtk/gsm_map_stat.c, gtk/isup_stat.c: From Michael Lum: ANSI and GSM MAP stats enhancements and cleanups; enhanced parameter dissection related to SS for GSM A-interface and MAP; minor GSM SMS fix; GSM SS enhancements for parameter dissection; MTP3 statistics tap. 2004-04-21 00:48 obiot * gtk/follow_dlg.c: Part 2 of Ulf's print update. 2004-04-20 23:54 obiot * packet-mmse.c: Provide MMSE 1.1 dissection. Please test with MMSE 1.1 captures! 2004-04-20 22:34 ulfl * file.c, print.c, print.h, print.ps, tethereal.c: changed postscript output: reduced print margin to 1/2 inch and font size to 8 point, include filename in page header, wrap too long lines 2004-04-20 19:27 obiot * packet-wsp.c: Fix the Content-Type parameter rendering as sometimes the code was adding its value to the header field and sometimes to its label in the protocol tree only. 2004-04-20 13:15 gerald * AUTHORS, doc/ethereal.pod: Update Thierry Pelle's address. 2004-04-20 08:33 sahlberg * packet-ldap.c: try to dissect the ms cldap netlogon rpc flags bits. the information comes from the samba sources and may or may not be reliable or menaingful. ms documentation in their knowledgebase says that the only really important part in the netlogon response is the sitename. (i have reasons to belive at least one of the flags, closest, is completely bogous) 2004-04-20 05:32 ulfl * packet-aim-icq.c, packet-aim-oft.c: fixed MSVC problems 2004-04-20 05:07 guy * AUTHORS, packet-tuxedo.c, epan/Makefile.common: From metatech: basic BEA Tuxedo protocol support. 2004-04-20 04:48 guy * packet-aim-admin.c, packet-aim-adverts.c, packet-aim-bos.c, packet-aim-buddylist.c, packet-aim-chat.c, packet-aim-chatnav.c, packet-aim-directory.c, packet-aim-generic.c, packet-aim-icq.c, packet-aim-location.c, packet-aim-messaging.c, packet-aim-oft.c, packet-aim-ssi.c, packet-aim-translate.c, packet-aim.c, packet-aim.h: From Jelmer Vernooij: Add support for a couple more SNAC's. Handle TLV's in a somewhat more extendible manner. Fix a bug in the buddylist dissector that caused pango warnings. 2004-04-20 04:17 guy * packet-acse.c, packet-ftam.c: From Yuriy Sidelnikov: add a dissector table for OIDs to the ACSE dissector, and make the FTAP dissector register itself in that table. 2004-04-19 23:36 obiot * packet-ip.c: Add a textual "(Dont Fragment)" and "(More Fragments)" to the ip.flags line in case the DF bit or the MF bit is set. 2004-04-19 23:26 obiot * packet-wbxml.c: Fix a bug in the processing of WV-CSP OPAQUE data (TCPAddress was Integer in WV-CSP 1.0 but became a String from WV-CSP 1.1 onwards). The token code page 3 of WV-CSP 1.2 is the same as in WV-CSP 1.1 (not 1.0). 2004-04-19 22:41 guy * packet-rtps.c: Put the value(s) of a parameter into the top-level item for that parameter, and clean up the display of the value(s) under that item. 2004-04-19 20:20 guy * packet-rtps.c: Add length checks to submessages. Clean up the handling of parameter sequences - add a bunch of length checking, give each parameter a protocol tree item with the ID/length/value under it, and don't format variable-length string parameters into fixed-length buffers. Use the parameter-sequence dissector for the ISSUE message. Use the "number of bits" value when dissecting a bitmap. 2004-04-19 08:26 guy * AUTHORS, doc/ethereal.pod: Update Pasi Eronen's e-mail address. 2004-04-19 08:19 guy * packet-rtps.c: Use a "while()" loop, rather than a "do { ... } while()" loop, in "dissect_rtps()", just in case a message with *no* submessages is sent. Fetch the flags field in that loop, as we need the E bit value to determine the byte order of the "next submessage offset" field; fetch that value in the loop as well, and pass both those values, and the byte-order flag, to submessage dissector routines as necessary. Make the main protocol tree item for each submessage cover the entire submessage; put into that protocol tree an item that covers the submessage ID, with a named field. Construct the submessage subtree in that loop, rather than in the submessage dissectors. Put into that subtree items for the flags and next submessage offset; we do that in the submessage dissector, as the interpretation of the bits in the flags field differs from submessage to submessage. 2004-04-18 20:08 guy * packet-rtps.c: The "next_submsg" argument passed to "get_bitmap()" is an offset within the tvbuff, not a relative offset, so it should just be a "gint". 2004-04-18 19:52 guy * packet-rtps.c: Get rid of an unused variable. 2004-04-18 18:55 guy * packet-rtps.c: Make "little_endian" local to the routines to parse submessages. Before checking for the "RTPS" tag, make sure we have at least 4 bytes in the message. Use "tvb_reported_length()" to get the length of the message, so we throw an exception on a packet cut short by a snapshot length. Put in a comment asking whether the byte order of the "offset to next submessage" field is little-endian or specified by the E bit. 2004-04-18 10:16 obiot * README.win32: Update the cygwin build instructions (plugins can now be compiled too). Hint on how cygwin gcc can be used to compile a native Win32 Ethereal. 2004-04-18 06:41 ulfl * README.win32: added a small section about the supported compilers 2004-04-18 06:40 ulfl * packet-rtps.c: removed some MSVC warnings 2004-04-18 06:39 ulfl * packet-rtps.h: replaced some integer types by glib ones, to be able to compile again on win32 2004-04-17 22:11 guy * packet-rtps.c: Put "#" in pre-processor keywords at the beginning of the line - I seem to remember that at least at one point in the history of C, at least one compiler required that. Clean up the byte-order stuff - LITTLE_ENDIAN and BIG_ENDIAN aren't defined by Ethereal or GLib, so we shouldn't use them (some platforms might define them, but at least some platforms define them *both* as non-zero values, so they can't be used as "true or false" values for "e_bit"), and we don't need to worry about the byte order of the machine running Ethereal - we should just use Ethereal's standard routines to fetch little-endian or big-endian values. Get rid of C++ comments. 2004-04-17 21:43 guy * AUTHORS, Makefile.common, packet-rtps.c, packet-rtps.h, doc/ethereal.pod, epan/Makefile.common: From Lukas Pokorny: RTPS (Real-Time Publish-Subscribe) support. 2004-04-17 20:58 guy * packet-mq.c: Updates from metatech: - Added SPI messages. - A bit a factorisation. 2004-04-17 11:50 ulfl * print.c, print.h, gtk/print_dlg.c: added PSML output to the printing dialog 2004-04-17 10:45 obiot * packet-wbxml.c: Fix a typo in %DateTime of length 7 (missing colon between minutes and seconds). 2004-04-17 09:02 ulfl * print.c: PDML output: if a protocol field is invisible, add the attribute: hide="yes" to the field node 2004-04-17 04:43 guy * packet-q931.c: Neaten up the display of the top-level protocol tree item for a number IE. 2004-04-17 03:38 guy * packet-x11.c, x11-fields: In EnterNotify and LeaveNotify events, the last byte isn't a Boolean, it's a bitmask with "focus" and "same-screen" bits. 2004-04-17 03:02 guy * packet-diameter.c: The value returned by "diameter_avp_get_value()" is used only in protocol tree items that also have the AVP value in the text, so there's no reason to have the string returned by "diameter_avp_get_value()" contain that value as well - it's redundant. 2004-04-17 01:12 guy * gtk/color_dlg.c: Confirmation dialogs should be marked as such. 2004-04-17 01:09 guy * gtk/: capture_dlg.c, capture_prefs.c: Failure to get the list of interfaces should be reported as an error. 2004-04-17 01:07 guy * capture.c: Failures when capturing should be reported as errors. 2004-04-17 01:05 guy * dftest.c: Update to handle the changed epan_init() API, with a "general failure" routine added. Add a missing newline to the end of read failure messages. 2004-04-17 01:01 guy * gtk/io_stat.c: Report problems due to the user specifying something we can't handle as errors, not warnings. 2004-04-16 23:57 guy * gtk/main.c: Report errors in opening various configuration files at the time the failure occurs; now that "simple_dialog()" queues up messages if we don't yet have the main window, those messages will be queued up until then. Move the point at which we pop up those queued messages after the "process all pending GUI events" is done, so that those messages are properly displayed on top of the main window. 2004-04-16 23:16 guy * alert_box.c, alert_box.h, packet-diameter.c, simple_dialog.h, tethereal.c, epan/epan.c, epan/epan.h, epan/report_err.h, gtk/main.c, gtk/simple_dialog.c, plugins/plugin_api_list.c, plugins/Xass-list, plugins/Xplugin_api.c, plugins/Xplugin_api.h, plugins/Xplugin_api_decls.h, plugins/Xplugin_table.h: Add a "report_failure()" routine to allow dissectors to report arbitrary errors to the user. Use that, rather than "g_warning()", in the Diameter dissector to report errors reading the dictionary. Make the format argument to "simple_dialog()" a "const" pointer. Fix up the read-error message in Tethereal to end with a newline. If a simple dialog is requested before the main window or the capture-control window is popped up, queue it up and pop the queued messages up once the main or capture-control window is displayed. 2004-04-16 22:44 obiot * packet-wbxml.c: Add a discriminator for WV-CSP so the correct version is used for rendering the WBXML tokens in WV-CSP. Provide rendering of OPAQUE data for media types, based on a framework of 4 functions that take care of well-known and literal tags and attribute names for deciding on the meaning of the OPAQUE data. Applied to SI, EMN and WV-CSP. Update reference URLs for WAP, OMA and related specs. Note: as the WBXML common code only takes ~2000 lines while the token mappings take ~4000 lines, maybe it is time to envisage writing the per-media mappings to dedicated source files (packet-wbxml-wml.c, packet-wbxml-wv_csp.c etc)? 2004-04-16 20:20 guy * file.c: If we're printing summaries and packet detail or hex dump information, print the header before each summary line, and print a blank line separating the summary line and the remaining information. 2004-04-16 19:36 guy * gtk/: color_dlg.c, color_filters.c, color_filters.h: Make "new_color_filter()" take the background and foreground colors, as GdkColors, as arguments. 2004-04-16 19:05 guy * gtk/color_filters.c: You have to initialize a GtkColor structure before passing it to "get_color()" - otherwise, GDK will allocate a color from the colormap to match whatever random values happen to be there. 2004-04-16 18:17 ulfl * file.c, print.c, tethereal.c, gtk/print_dlg.c: make print dialog "Packet Format" options somewhat similar to the Ethereal panes, thus better understandable 2004-04-16 05:30 ulfl * gtk/print_dlg.c: bugfix: make the "no dissections" radiobutton insensitive, if packet details isn't selected 2004-04-15 23:28 guy * cfile.h, file.c, gtk/find_dlg.c: Rename a bunch of variables and routines that pertain to string search with "string" rather than "ascii", to make it clearer what they're involved with. Use "gtk_toggle_button_set_active()", not "gtk_toggle_button_set_state()" (the latter is a deprecated alias for the former, probably dating back to GTK+ 1.0[.x] - 1.2[.x] and later have "gtk_toggle_button_set_active()"). Do *NOT* change the radio buttons for the type of string search to do based on whether we're doing a string search or not - doing so means we don't correctly remember the type of string search. Get rid of code to fetch some values that we don't subsequently use. 2004-04-15 22:38 obiot * packet-wbxml.c: Add two preferences to the WBXML dissector: - Control the rendering of WBXML tokens to a media type token mapping. - Control the dissection of the tokens that make up the WBXML body. Both preferences are OFF by default. Fix some comments as they did not reflect the current state anymore. 2004-04-15 19:56 ulfl * print.c, print.h, gtk/print_dlg.c: added print output option, to suppress dissection completely (for raw packet hexdump) 2004-04-15 19:05 ulfl * print.c, gtk/print_dlg.c: added print output of PDML format 2004-04-15 09:24 guy * AUTHORS, packet-cops.c: From Dick Gooris: PacketCable support in the COPS dissector. 2004-04-15 08:34 sahlberg * packet-kerberos.c: decryption and dissection of PA_ENC_TIMESTAMP 2004-04-15 07:47 sahlberg * packet-kerberos.c: dissect EncKDCRepPart applications 25 and 26 2004-04-15 00:18 guy * packet-tcp.c: Add some braces to squelch a GCC warning. 2004-04-14 22:13 obiot * doc/README.plugins, plugins/acn/Makefile.am, plugins/artnet/Makefile.am, plugins/asn1/Makefile.am, plugins/ciscosm/Makefile.am, plugins/docsis/Makefile.am, plugins/enttec/Makefile.am, plugins/giop/Makefile.am, plugins/gryphon/Makefile.am, plugins/irda/Makefile.am, plugins/lwres/Makefile.am, plugins/megaco/Makefile.am, plugins/mgcp/Makefile.am, plugins/pcli/Makefile.am, plugins/rdm/Makefile.am, plugins/rlm/Makefile.am, plugins/rtnet/Makefile.am, plugins/rudp/Makefile.am, plugins/v5ua/Makefile.am: Add support for plugin dissectors on cygwin builds, by adding the following line to every Makefile.am file for a given plugin XXX: XXX_la_LIBADD = -L../../epan -lethereal @GLIB_LIBS@ This way symbols defined in libethereal and GLib are resolved when linking the plugin dissector modules. 2004-04-14 18:42 obiot * configure.in, epan/ftypes/Makefile.am, wiretap/configure.in: At last compiling on CygWin works again! Added the missing PCRE and GLIB libraries to libftypes. Provide caching of computed configure tests. 2004-04-14 05:46 ulfl * file.c, gtk/capture_info_dlg.c: two memory leaks removed 2004-04-14 04:45 etxrab * packet-sip.c: Correct the removal of spaces before parameters in the Content type line, change some tags according to --sip-publish-03 2004-04-13 22:07 obiot * packet-mmse.c: Fix the default clause for not implemented MMS headers by adding more generic code from WSP (based on the wkh_default() method). Add initial support for MMS 1.1 and MMS 1.2 (header names, PDU types, response status codes, message status). TODO: implement the *full* header dissections for MMS 1.1 and MMS 1.2. 2004-04-13 21:32 guy * packet-gprs-llc.c: Use the "a_bit" true_false_string for the "llcgprs.as" field. 2004-04-13 21:29 guy * packet-sndcp.c: Change the decision tree for protocol and data compression so that it doesn't test all four possibilities - with the old code, GCC doesn't understand that one of the four possibilities must be true, so it complains that "compression_field_item" might not be set, but it does understand that with the new code. 2004-04-13 18:01 tuexen * capture.c, capture.h, file.c, gtk/capture_info_dlg.c: From Jon Oberheide: Add interface name to the capture and ethereal window while capturing. 2004-04-13 17:48 guy * packet-gprs-llc.c: Get rid of some unused variables, as per Josef Korelus. 2004-04-13 04:45 guy * packet-sndcp.c: Don't put blanks at the ends of strings added with "col_add_fstr()", put them at the beginnings of strings appended with "col_append_str()", so there won't be extra blanks at the end. 2004-04-13 04:36 guy * AUTHORS, packet-sndcp.c, epan/Makefile.common: From Christian Falckenberg: GPRS SNDCP support. 2004-04-13 04:21 guy * AUTHORS, packet-bssgp.c, packet-gprs-llc.c, epan/Makefile.common: From Josef Korelus: GPRS LLC support. 2004-04-13 04:04 guy * AUTHORS, packet-bpdu.c, packet-cisco-oui.c, doc/ethereal.pod: From Clinton Work: dissect Cisco PID 0x010b as STP (it's actually their own modified Per-VLAN STP, so there's some extra stuff at the end of the packet that needs to be decoded). Indicate in a comment in packet-cisco-oui.c what PVSTP is. 2004-04-12 22:14 guy * packet-http.c: Put in a comment noting a possible memory leak. 2004-04-12 18:01 ulfl * gtk/rtp_stream_dlg.c: ESC key presses Close button 2004-04-12 09:48 ulfl * gtk/: http_stat.c, rpc_progs.c, sip_stat.c, tcp_graph.c, wsp_stat.c: added a close button to the dialogs, use the dlg_window_new function for all dialogs 2004-04-12 08:59 ulfl * gtk/gsm_map_stat.c: added missing #include from my latest checkin 2004-04-12 08:53 ulfl * gtk/: ansi_a_stat.c, ansi_map_stat.c, bootp_stat.c, dcerpc_stat.c, fc_stat.c, gsm_a_stat.c, gsm_map_stat.c, h225_counter.c, h225_ras_srt.c, http_stat.c, isup_stat.c, ldap_stat.c, rpc_stat.c, smb_stat.c: added a close button to the dialogs, use the dlg_window_new function for all dialogs 2004-04-12 07:10 ulfl * gtk/: endpoint_talkers_table.c, hostlist_table.c: added a close button to the dialogs 2004-04-11 20:57 guy * packet-aim.c: From Jon Oberheide: add the "Password Hash" label to AIM_TLV_PASSWORD (0x0025) which was previously "Unknown". 2004-04-11 20:47 guy * AUTHORS, packet-aim-signon.c, doc/ethereal.pod: From Jon Oberheide: add a missing hf[] entry for a field. Fix up AUTHORS and the authors list in the Ethereal man page. 2004-04-10 09:10 ulfl * README.win32: did lot's of cleanup to the text, especially in the library sections 2004-04-10 07:29 ulfl * Makefile.nmake: Modify the "setup" target to download the packages we've defined, so that we don't download the GTK1 packages unless we have GTK1_DIR defined. 2004-04-09 19:44 gerald * gtk/follow_dlg.c: Make the hex dump byte counter a guint32, so that we don't wrap prematurely. 2004-04-09 16:54 gerald * Makefile.nmake, tools/win32-setup.sh: Modify the "setup" target to download the packages we've defined, so that we don't download the GTK2 packages unless we have GTK2_DIR defined. Fix some path checking in win32-setup.sh. 2004-04-09 09:15 guy * packet-mq.c: From metatech: - No registration of port 1414, only the heuristics. - More dissection of pre-defined MQ structures or messages types (MSH, DH, DLH, OR, RR, PMR, MDE, MQSET, MQINQ, MQPUT1, PING). 2004-04-09 08:39 guy * packet-ipdc.c, packet-ipdc.h: From Josh Bailey: Fix missing handling for tags 0x6F and 0x70 (send and receive encoding type). Shorten fields displayed in COL_INFO. Display information about all IPDC packets in COL_INFO if there's more than one. 2004-04-09 07:38 ulfl * Makefile.nmake: use the configured names from config.nmake for the required apps list 2004-04-09 07:37 ulfl * README.win32: do some more explanations how to use the new library download tool updated ADNS library version 2004-04-09 03:51 sahlberg * packet-h225.c: even more h235 dissection 2004-04-09 03:32 sahlberg * packet-h225.c: some more h235 dissection 2004-04-09 01:07 sahlberg * packet-h225.c: Add dissection of AuthenticationMechanism to h235 2004-04-09 00:31 sahlberg * packet-per.h: Make it more obvious when ethereal fails to dissect a PER contruct 1, put a hint why it failed in the COL_INFO line 2, abort dissecting any further (by reading from the arbitrary position 9999 in the tvb 3, put "something unknown here [xxx]" as the last entry in the tree. 2004-04-08 23:52 sahlberg * packet-h225.c: implement some basic dissection of H.235 ClearToken so that the capture reported on the list will be dissected properly. maybe someone should break out all the h.235 code sometime later and put it in packet-h235.c? 2004-04-08 20:36 gerald * Makefile.nmake, README.win32, config.nmake, tools/win32-setup.sh: Add a Makefile.nmake target called "setup" that uses the script tools\win32-setup.sh to - Check for applications required to build Ethereal - Download and unpack required packages into $ETHEREAL_LIBS Update ADNS to the latest version. Make Python 2.3 the default. 2004-04-08 19:07 ulfl * gtk/capture_dlg.c: catch the enter key from the interface drop-down list, so pressing enter will really start a capture 2004-04-08 10:21 sahlberg * packet-dcerpc-netlogon.c: update to netlogon: make it dissect all the bits of the UserAccountControl flags field in the pac structure and elsewhere in netlogon 2004-04-08 09:34 sahlberg * packet-dcerpc-netlogon.c: dissection of netlogon userflags in tha pac structure and elsewhere 2004-04-08 09:17 sahlberg * packet-dcerpc-netlogon.c: dissect group attributes for the pac structure and other places in netlogon 2004-04-08 08:05 guy * gtk/capture_dlg.c: On Windows, when looking for the ":" that separates the interface description from the interface name, don't count ":" followed by "//", as it might be part of "rpcap://". 2004-04-08 05:19 sahlberg * doc/ethereal.pod: update doc with better description of SUM/COUNT/MIN/MAX/AVG. 2004-04-08 05:09 sahlberg * packet-tcp.c: update tcp so that it will print the string "(relative sequence/ack number)" in the header for the fields affected by using human readable sequence and ack numbers. 2004-04-07 06:18 guy * packet-ipmi.c: From Duncan Laurie: the LUN field in IPMI packets is only in the lower 2 bits. 2004-04-07 06:04 guy * etypes.h, packet-eapol.c, packet-ethertype.c: From Jouni Malinen: add support for the 802.11i/RSN pre-authentication Ethertype. 2004-04-07 04:31 sahlberg * gtk/: rpc_stat.c, service_response_time_table.c: make service response time statistics work for "unknown" rpc programs. all proicedures will however get "interesting" names such as "proc-1" etc except procedure 0 which is ALWAYS "NULL" 2004-04-07 03:57 sahlberg * packet-rpc.c: when dealing with unknown rpc programs, create a fake program/version/procedure table so that we can get service response time tables working later. 2004-04-06 19:02 ulfl * AUTHORS, prefs.c, prefs.h, doc/ethereal.pod, gtk/gui_prefs.c, gtk/main.c: from Thomas Palmer: add a preference setting for filter toolbar placement 2004-04-06 16:08 gerald * gtk/main.c: Remove an extraneous 'break'. 2004-04-05 00:49 sahlberg * packet-kerberos.c: Add support to decrypt the encrypted part of AS/TSG -REP PDUs. Now we only need application 25/26 to be dissected as well for it to be useful ... 2004-04-05 00:28 sahlberg * packet-kerberos.c: Added some more principal name types from the kerberos draft 2004-04-04 07:12 sahlberg * AUTHORS, doc/ethereal.pod: Love contributed great help to get the heimdal decryption support working (wherein we also discovered an obscure bug inside heimdal itself) Great thanks to Love. 2004-04-03 22:33 etxrab * packet-sip.c: As pointed out by Chernishov Yury - strip of leading spaces of parameters 2004-04-03 22:13 etxrab * packet-isup.c, AUTHORS: From Chernishov Yury Don't destroy SIP dissector entrys in info column for application/isup 2004-04-03 03:50 guy * packet-smb-common.c: In "get_unicode_or_ascii_string()", treat a negative length argument as a very large unsigned integer (which it probably is), and trim it at INT_MAX, and fix the handling of too-long ASCII strings so that the "..." gets inserted. Make sure that all the bytes of the string exist before truncating the string length to the buffer length, so that the appropriate exception is thrown. 2004-04-03 00:29 sahlberg * packet-rpc.c: Add a new preference option so that users that really really want to can tell ethereal "I dont care if the heuristics are too weak" "I want to see the ONC-RPC layer for these weird protocols that are not known to ethereal" "If I get a lot of false positives it is my own fault and I will not complain" This allows ethereal to dissect the rpc layer (and do request/response matching) even for those onc-rpc protocols that ethereal doesnt know about yet. 2004-04-02 22:01 sahlberg * packet-spnego.c: If the packet is short, dont try to create a blob item that spans beyound the end of the short packet since that will raise an exception and we wont even attempt to dissect those (kerberos usually) bytes that we do have in the packet. 2004-04-02 21:38 sahlberg * packet-smb.c: dont bail out just because we dont have the entire security blob present in a pdu. even for short frames, try to pass on as mush as possible to gssapi. 2004-04-02 09:04 guy * epan/column-utils.c: From Olivier Biot: support AT_STRINGZ columns. 2004-04-02 08:27 guy * wiretap/: nettl.c, nettl.h: From Mark C. Brown: add support for FDDI and Token Ring cards. Set the file encapsulation the same way it's done for iptrace captures - leave it as "unknown" to start with, and, for each packet we see, set it to the packet's encapsulation type if the file encapsulation type is unknown and set it to "per-packet" if the file encapsulation type is "known" but isn't the type of that packet, so files that have all the same type of packet have that type as the file type and packets that *don't* have all the same type of packet have "per-packet". 2004-04-02 07:59 guy * packet-aim-messaging.c: From Devin Heitmueller: do a better job of decoding the AIM messaging SNAC for outgoing and incoming subtypes. 2004-04-02 07:40 guy * wiretap/eyesdn.c: From Rolf Fiedler: fix a comment, and fix the code to get the packet length. 2004-04-02 07:28 guy * AUTHORS, packet-ymsg.c: From Devin Heitmueller: do YMSG desegmentation. 2004-04-02 05:19 guy * packet-isup.c: Get rid of an extra "=" at the end of the file. 2004-04-02 05:07 guy * packet-diameter-defs.h: Get rid of CRs. 2004-04-01 20:34 etxrab * packet-isup.c: Fix a copy paste error 2004-04-01 09:15 sahlberg * packet-kerberos.c: add dissection of the canonicalize bit which some windows clients use 2004-03-31 21:04 guy * packet-isup.c: Get rid of CR's. 2004-03-31 20:57 guy * packet-radius.c: Get rid of CR's. 2004-03-31 20:25 etxrab * packet-radius.c: Add RADIUS AVP 101, the value string to go with it and some ACC vendor AVP:s 2004-03-31 20:23 etxrab * packet-isup.c: Add dissection of user to user indicators parameter, Split some lines and some white space changes 2004-03-31 01:31 jmayer * TODO: configure.in merging has been done. Add another point 2004-03-31 01:25 jmayer * epan/: acinclude.m4, configure.in: No longer needed after merging epan/configure.in into configure.in 2004-03-30 20:56 etxrab * packet-diameter-defs.h: Fixed some cut-and-paste errors, added some RADIUS AVPS sorted some value string... 2004-03-30 19:37 guy * packet-smb-mailslot.c, wiretap/wtap.c: From Albert Chin: "config.h" should come before all other #includes. 2004-03-30 19:36 guy * plugins/rudp/packet-rudp.c: From Albert Chin: the Sun WorkShop 5.0 compiler and HP-UX 10.20 compiler don't allow you to initialize aggregates with an initializer that includes non-constant values. 2004-03-30 19:34 guy * Makefile.am: From Albert Chin: on IRIX, if -la depends on -lb, you must link with -lb -la. 2004-03-30 19:15 guy * packet-eapol.c: From Jouni Malinen: add support for the most likely EAPOL-Key packet type. 2004-03-30 19:07 guy * config.guess, config.sub: Back out the previous change, as it checked in older versions of config.guess and config.sub. 2004-03-30 19:01 guy * packet-3g-a11.c: From Ryuji Somegawa: fix AirLink record dissection. 2004-03-30 18:55 guy * AUTHORS, Makefile.common, packet-sip.c, tap-sipstat.c, gtk/sip_stat.c: From Lars Roland: Tethereal version of SIP statistics tap, and fixes to the Ethereal version. 2004-03-30 18:45 guy * plugins/Makefile.nmake: From Lars Roland: have "make clean" and "make distclean" clean up the new Cisco VoIP plugins. 2004-03-30 18:30 guy * plugins/: ciscosm/packet-sm.c, rlm/packet-rlm.c, rudp/packet-rudp.c: From Duncan Sargeant: include "moduleinfo.h" so that the plugins get the right version number. 2004-03-30 18:23 guy * packet-radius.c: From Michael Kopp: add support for vendor-specific items for the Cisco VPN 3000 Concentrator, Cisco VPN 5000 Concentrator and Cisco Broadband Service Manager. 2004-03-30 18:14 guy * packet-gtp.c: The extension ID field in a Private Extension IU is 2 bytes, so the length of the IU must be at least 2 bytes in order to dissect the contents. Just use "proto_tree_add_item()" to add the value of the private extension, and do so only if it's not zero-length. 2004-03-30 17:52 guy * packet-mip6.c: Fix the length used for the protocol tree item for Mobile IPv6 options. 2004-03-30 17:38 guy * packet-aim-location.c: From Devin Heitmueller: put back the info level for the user info request. 2004-03-30 07:39 sharpe * config.guess, config.sub, packet-dcerpc-lsa.c, packet-dcerpc-samr.c, packet-dcerpc-spoolss.c, packet-dcerpc-svcctl.c, packet-smb-common.h, packet-smb.c: Add the mask for an NT ACL ACE to the summary list for each ACE. This means we don't have to expand the ACE to see what the permission mask is. There are a couple of other places where this could be used, but I have not done anything about them. 2004-03-29 23:14 guy * gtk/dlg_utils.c: It *appears* that if you don't explicitly request that a file chooser dialog be centered on its parent, it still gets so centered; we remove the call to do so from the GTK+ >= 2.4 file selection dialog creation code. 2004-03-29 23:03 guy * gtk/dlg_utils.c: In a "save" dialog, the "yes" button should be a "Save" button, not an "Open" button. 2004-03-29 22:55 guy * gtk/: dlg_utils.c, dlg_utils.h, file_dlg.c: Add another wrapper routine, "file_selection_set_extra_widget()", to set the "extra options" portion of a file selection dialog, and use it rather than #if'ed code. 2004-03-29 22:40 guy * gtk/: capture_dlg.c, dlg_utils.c, dlg_utils.h, file_dlg.c, follow_dlg.c, print_prefs.c: Make "file_selection_new()" take as its second argument an Ethereal-defined indication of the action (open vs. save), regardless of whether we're building for GTK+ >= 2.4 or not; we just ignore the argument in pre-2.4 GTK+. Use "file_selection_new()" rather than #if'ed code to use it or "gtk_file_chooser_dialog_new()" for GTK+ >= 2.4 and "gtk_file_selection_new()" or it for pre-2.4 GTK+. Add a "file_selection_set_current_folder()" routine that does the appropriate thing depending on whether we're GTK+ >= 2.4 or not, and use that rather than #if'ed code to use "gtk_file_chooser_set_current_folder()" or "gtk_file_selection_set_filename()". 2004-03-28 00:26 guy * packet-eapol.c: From Jouni Malinen: Small changes for EAPOL-Key dissector for IEEE 802.11i/RSN: - add Encrypted Key Data flag for key info - do not try to parse EAPOL-Key Key Data if it is encrypted (RSN: Encrypted Key Data flag, WPA: Group Key) - Key Index and Key ID are reserved in RSN 2004-03-27 12:18 ulfl * gtk/: capture_dlg.c, file_dlg.c: minor code cleanup, including removed MSVC warnings 2004-03-27 12:14 jmayer * aclocal-fallback/: glib-2.0.m4, glib.m4, gtk-2.0.m4, gtk.m4: Fix some aclocal warnings during autogen.sh 2004-03-27 12:07 jmayer * acinclude.m4, wiretap/acinclude.m4: Some aclocal warning fixes during autogen.sh 2004-03-27 11:53 guy * packet-tcp.c: From Ronnie Sahlberg: RST and FIN segments are neither zero-window packets nor duplicate ACKs. 2004-03-27 11:52 jmayer * autogen.sh, configure.in: OK, I'm impatient. In case of problems, I'm to blame, not Olivier. Olivier Biot: Merge epan/configure.in back into configure.in Leave epan/confiugre.in and epan/acinclude.m4 in case we need to undo this. 2004-03-27 11:33 guy * process-x11-fields.pl: From Gisle Vanem: add a "this is a generated file" comment to the output of process-x11-fields. 2004-03-27 11:32 guy * AUTHORS, Makefile.common, packet-ansi_801.c, packet-ansi_a.c, packet-ansi_map.c, packet-gsm_map.c, packet-gsm_sms.c, packet-gsm_sms.h, packet-gsm_ss.c, packet-gsm_ss.h, epan/Makefile.common: From Michael Lum: ANSI IS-801 support; dissect more GSM supplementary services messages and fields. 2004-03-27 11:16 oabad * gtk/: capture_dlg.c, dlg_utils.c, dlg_utils.h, file_dlg.c, follow_dlg.c, print_prefs.c: Use the new GtkFileChooserDialog when built with gtk+ 2.4 2004-03-27 11:16 guy * wiretap/: nettl.c, nettl.h: From Mark C. Brown: add support for iether (dual-port gigabit) cards in nettl files. 2004-03-27 11:13 guy * gtk/: bootp_stat.c, h225_counter.c, h225_ras_srt.c, http_stat.c, mgcp_stat.c, sip_stat.c, wsp_stat.c: From Lars Roland: use the generic filter dialog for the SIP, HTTP, WSP, and BOOTP taps. Get rid of the "dlg" variable in some of those taps - it's never set, so it's always null, and nothing useful is done with it if it's null. Make static some variables and functions not used outside the source file in which they're defined.