From 2aab706c5a5d61c61bbff6e9e36a57afc4ef3be8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Valverde?= Date: Sat, 21 Nov 2015 23:48:27 +0000 Subject: Remove -Wwrite-strings compiler flag The "-Wwrite-strings" flag produces nuisance warnings. These warnings are not useful, they're impossible to fix in a sane way and therefore are being handled with casts of static strings to (char *). This just moves the warning to [-Wcast-qual] and a compiler pragma is in turn required (and used) to squelch that warning. Remove the Wwrite-strings warning. Let that responsibility fall on the programmer (as is done by casting). Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5 Reviewed-on: https://code.wireshark.org/review/12162 Petri-Dish: Alexis La Goutte Reviewed-by: Alexis La Goutte Reviewed-by: Michael Mann --- wsutil/wsgetopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'wsutil') diff --git a/wsutil/wsgetopt.c b/wsutil/wsgetopt.c index eac72d5af4..5302bc7563 100644 --- a/wsutil/wsgetopt.c +++ b/wsutil/wsgetopt.c @@ -820,7 +820,7 @@ _getopt_internal_r (int argc, char *const *argv, const char *optstring, } #endif } - d->__nextchar = (char *) ""; + d->__nextchar = ""; d->optind++; d->optopt = 0; return '?'; -- cgit v1.2.3